Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051977POS2POSpublic2023-03-24 14:442023-06-12 10:53
ReporterAugustoMauch 
Assigned Tomeriem_azaf 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q3 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051977: BaseKeypad should accept an optional currency propery, if included its symbol should be added as a suffix to the label
DescriptionSee https://docs.google.com/document/d/1X-hpChl8S85QP8nb5UFBwIpKLlA8KXIWqO57GDIRpjQ/edit#heading=h.fttrevrac7ke [^]
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-03-24 14:44AugustoMauchNew Issue
2023-03-24 14:44AugustoMauchAssigned To => Retail
2023-03-24 14:44AugustoMauchTriggers an Emergency Pack => No
2023-03-24 14:44AugustoMauchAssigned ToRetail => gdagnesses
2023-03-24 14:44AugustoMauchStatusnew => scheduled
2023-05-29 09:46AugustoMauchAssigned Togdagnesses => meriem_azaf
2023-05-30 18:09hgbotNote Added: 0150488
2023-05-31 08:47hgbotNote Added: 0150507
2023-05-31 10:07hgbotNote Added: 0150513
2023-05-31 16:07AugustoMauchNote Deleted: 0150507
2023-05-31 16:07AugustoMauchNote Deleted: 0150513
2023-05-31 16:07hgbotResolutionopen => fixed
2023-05-31 16:07hgbotStatusscheduled => closed
2023-05-31 16:07hgbotNote Added: 0150552
2023-05-31 16:07hgbotFixed in Version => 23Q3
2023-05-31 16:07hgbotNote Added: 0150553
2023-06-08 19:39hgbotNote Added: 0150965
2023-06-08 19:59hgbotNote Added: 0150966
2023-06-08 20:13hgbotNote Added: 0150967
2023-06-09 11:46hgbotNote Added: 0150977
2023-06-09 11:46hgbotNote Added: 0150978
2023-06-12 10:53hgbotNote Added: 0151042

Notes
(0150488)
hgbot   
2023-05-30 18:09   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1115 [^]
(0150553)
hgbot   
2023-05-31 16:07   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 799cb2d12124b6d1fe5c7276a31fc50a67877b22
Author: Meriem Azaf <meriem.azaf@openbravo.com>
Date: 31-05-2023 15:26:29
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/799cb2d12124b6d1fe5c7276a31fc50a67877b22 [^]

Fixes ISSUE-51977: BaseKeypad should accept an optional currency propery, if included its symbol should be added as a suffix to the label

We want to improve some text inputs that will be used to express money quantities so that they include more context about what currency they are representing.

For that, we added a new property in BaseFormInput "labelSuffix" with test and story also another new property in BaseKeypad "currency" with test and story.

---
M web-jspack/org.openbravo.core2/src/components/BaseFormInput/BaseFormInput.jsx
M web-jspack/org.openbravo.core2/src/components/BaseFormInput/__test__/BaseFormInput.test.jsx
M web-jspack/org.openbravo.core2/src/components/BaseFormInput/stories/BaseFormInput.stories.jsx
M web-jspack/org.openbravo.core2/src/components/BaseKeypad/BaseKeypad.jsx
M web-jspack/org.openbravo.core2/src/components/BaseKeypad/__test__/BaseKeypad.test.jsx
M web-jspack/org.openbravo.core2/src/components/BaseKeypad/stories/BaseKeypad.stories.jsx
---
(0150552)
hgbot   
2023-05-31 16:07   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1115 [^]
(0150965)
hgbot   
2023-06-08 19:39   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: fd6392f0e7f2a2b487a2ddbc45d7d4191de97c55
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 08-06-2023 19:38:12
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/fd6392f0e7f2a2b487a2ddbc45d7d4191de97c55 [^]

[CashManagement] Related to ISSUE-51977: add currency symbol to amount keypad of cash management

---
M web-jspack/org.openbravo.pos2/src/components/CashManagement/CashManagementNewMovementForm/CashManagementNewMovementForm.jsx
---
(0150966)
hgbot   
2023-06-08 19:59   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: f0887f13ebf822214e443086844a0194731b00f2
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 08-06-2023 19:58:43
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/f0887f13ebf822214e443086844a0194731b00f2 [^]

Revert "[CashManagement] Related to ISSUE-51977: add currency symbol to amount keypad of cash management"

This reverts commit fd6392f0e7f2a2b487a2ddbc45d7d4191de97c55.
This commit break a test

---
M web-jspack/org.openbravo.pos2/src/components/CashManagement/CashManagementNewMovementForm/CashManagementNewMovementForm.jsx
---
(0150967)
hgbot   
2023-06-08 20:13   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1130 [^]
(0150977)
hgbot   
2023-06-09 11:46   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1130 [^]
(0150978)
hgbot   
2023-06-09 11:46   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 5030604cb0c0c6d9f33d9c4eb32369dff5a9e264
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 09-06-2023 09:46:10
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/5030604cb0c0c6d9f33d9c4eb32369dff5a9e264 [^]

Fixes ISSUE-51977: Incorrect props for currency in BaseFormKeypad

---
M web-jspack/org.openbravo.core2/src/components/BaseFormKeypad/BaseFormKeypad.jsx
---
(0151042)
hgbot   
2023-06-12 10:53   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 14213e32e1eff5fb183f557c54cd4311b965e813
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 12-06-2023 10:53:37
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/14213e32e1eff5fb183f557c54cd4311b965e813 [^]

Revert "Revert "[CashManagement] Related to ISSUE-51977: add currency symbol to amount keypad of cash management""

This reverts commit f0887f13ebf822214e443086844a0194731b00f2.
Revert of the revert, commit pushed but break the tets, it was reverted,
and now that the fix is pushed to core2, revert the revert to left enabled

This is the fix of core2:
https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1130 [^]

---
M web-jspack/org.openbravo.pos2/src/components/CashManagement/CashManagementNewMovementForm/CashManagementNewMovementForm.jsx
---