Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051970POS2POSpublic2023-03-24 12:302023-04-21 09:47
Reportermeriem_azaf 
Assigned Tomeriem_azaf 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q2 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051970: Checked return : product having modifiers reduced to 1 € if product having modifiers is added
DescriptionA use case concerning product verified return causes a price modification.
Steps To Reproduce1- Connect to Pos2.

2- Create a new ticket.

3- Add a product having modifiers.

4- Pay the ticket.

5- Go to sales history screen.

6- Open the previous ticket.

7- Select verified return option and select the product having modifiers.

8- Add a product having modifiers in the same ticket.

9- When the 1st modifier appears, select and validate it.

KO –> the first product amount switch to -1€.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 005197623Q1.2 closed meriem_azaf Checked return : product having modifiers reduced to 1 € if product having modifiers is added 
depends on backport 005211023Q2 closed meriem_azaf Checked return : product having modifiers reduced to 1 € if product having modifiers is added 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-03-24 12:30meriem_azafNew Issue
2023-03-24 12:30meriem_azafAssigned To => Retail
2023-03-24 12:30meriem_azafTriggers an Emergency Pack => No
2023-03-24 12:31meriem_azafAssigned ToRetail => meriem_azaf
2023-03-24 12:31meriem_azafStatusnew => scheduled
2023-03-24 12:40meriem_azafSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=25761#r25761
2023-03-24 12:43hgbotNote Added: 0147950
2023-03-24 14:25meriem_azafStatusscheduled => acknowledged
2023-03-24 14:25meriem_azafStatusacknowledged => scheduled
2023-04-12 15:12guilleaerStatusscheduled => acknowledged
2023-04-12 15:12guilleaerStatusacknowledged => scheduled
2023-04-21 09:46hgbotResolutionopen => fixed
2023-04-21 09:46hgbotStatusscheduled => closed
2023-04-21 09:46hgbotNote Added: 0148698
2023-04-21 09:46hgbotFixed in Version => 23Q3
2023-04-21 09:46hgbotNote Added: 0148699
2023-04-21 09:47hgbotFixed in Version23Q3 => 23Q1.2
2023-04-21 09:47hgbotNote Added: 0148703
2023-04-21 09:47hgbotFixed in Version23Q1.2 => 23Q2
2023-04-21 09:47hgbotNote Added: 0148705

Notes
(0147950)
hgbot   
2023-03-24 12:43   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1632 [^]
(0148698)
hgbot   
2023-04-21 09:46   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1632 [^]
(0148699)
hgbot   
2023-04-21 09:46   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 42f6f5a044744d289a81929cf24e682a73bb8467
Author: meriem azaf <meriem.azaf@openbravo.com>
Date: 21-04-2023 07:46:41
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/42f6f5a044744d289a81929cf24e682a73bb8467 [^]

Fixes ISSUE-51970: Checked return : product having modifiers reduced to 1 € if product having modifiers is added

A use case concerning product verified return causes a price modification, when you have already a ticket that contain a product that has modifiers and you want to do the verified return and add another product that has modifiers so the first product amount switch to -1€.

The problem here that we updated the price of the product even the its modifiers have not an extra price.

---
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketUtils.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/UpdateProductModifiersExtraPrice.test.js
---
(0148703)
hgbot   
2023-04-21 09:47   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 8703b06d32655e656e8c74f7319aa8449356fc11
Author: meriem azaf <meriem.azaf@openbravo.com>
Date: 21-04-2023 07:47:35
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/8703b06d32655e656e8c74f7319aa8449356fc11 [^]

Fixes ISSUE-51970: Checked return : product having modifiers reduced to 1 € if product having modifiers is added

A use case concerning product verified return causes a price modification, when you have already a ticket that contain a product that has modifiers and you want to do the verified return and add another product that has modifiers so the first product amount switch to -1€.

The problem here that we updated the price of the product even the its modifiers have not an extra price.

---
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketUtils.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/UpdateProductModifiersExtraPrice.test.js
---
(0148705)
hgbot   
2023-04-21 09:47   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 4009348d92240d53d95b0ee8c88f310fb10ca5aa
Author: meriem azaf <meriem.azaf@openbravo.com>
Date: 21-04-2023 07:47:43
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/4009348d92240d53d95b0ee8c88f310fb10ca5aa [^]

Fixes ISSUE-51970: Checked return : product having modifiers reduced to 1 € if product having modifiers is added

A use case concerning product verified return causes a price modification, when you have already a ticket that contain a product that has modifiers and you want to do the verified return and add another product that has modifiers so the first product amount switch to -1€.

The problem here that we updated the price of the product even the its modifiers have not an extra price.

---
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketUtils.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/UpdateProductModifiersExtraPrice.test.js
---