Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051943POS2POSpublic2023-03-22 11:132023-05-19 14:34
Reporterablasco 
Assigned ToAugustoMauch 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q3 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051943: Responsive Toolbar render every time Form updates
DescriptionResponsive Toolbar render every time Form updates , because buttonsList in Responsive Toolbar is linked to the form.

There is a useEffect hook with buttonList dependency required for the Form.
Steps To Reproduce- Login in portrait Mode
- Select a form, ( Follow Up Files, Customers )
- Be sure, Responsive Toolbar is working with three dots MoreButtons component
- Write anything or change some field in the Form.

Any time a form field changes, Responsive Toolbar renders to update.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
duplicate of defect 0052130 closed ablasco Responsive Toolbar render causing a Glitch in Forms 
related to defect 0053681 closed jarmendariz useIsOverflow is not working when overflow disappear 
Attached Filesgif ResponsiveToolbarRenderUpdatesInForm.gif (300,886) 2023-03-22 11:13
https://issues.openbravo.com/file_download.php?file_id=18295&type=bug
Issue History
Date ModifiedUsernameFieldChange
2023-03-22 11:13ablascoNew Issue
2023-03-22 11:13ablascoAssigned To => Triage Platform Base
2023-03-22 11:13ablascoFile Added: ResponsiveToolbarRenderUpdatesInForm.gif
2023-03-22 11:13ablascoTriggers an Emergency Pack => No
2023-04-17 13:17ablascoRelationship addedduplicate of 0052130
2023-04-17 13:21hgbotNote Added: 0148477
2023-05-18 12:47AugustoMauchAssigned ToTriage Platform Base => AugustoMauch
2023-05-18 12:47AugustoMauchStatusnew => scheduled
2023-05-19 14:34hgbotResolutionopen => fixed
2023-05-19 14:34hgbotStatusscheduled => closed
2023-05-19 14:34hgbotNote Added: 0149993
2023-05-19 14:34hgbotFixed in Version => 23Q3
2023-05-19 14:34hgbotNote Added: 0149994
2023-11-23 12:58jarmendarizRelationship addedrelated to 0053681

Notes
(0148477)
hgbot   
2023-04-17 13:21   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1048 [^]
(0149993)
hgbot   
2023-05-19 14:34   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1048 [^]
(0149994)
hgbot   
2023-05-19 14:34   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: fa7625ef29cd0743c96863c35aee4dafa3277dfd
Author: adrian.blasco <adrian.blasco@openbravo.com>
Date: 19-05-2023 14:32:20
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/fa7625ef29cd0743c96863c35aee4dafa3277dfd [^]

Fixes ISSUE-51943 Responsive Toolbar does not render anymore if input change in Forms

If the button structure has been modified, we need to reset the visible and aggregated buttons. But it the button list has other changes (i.e.
its events have been updated), we still need need to update (not reset) the visible and aggregated buttons with the new information, otherwise
(following the events example) when clicked they will execute a previous version of the event

When setting the list of buttons to be included in the aggregated button, the buttons were not being properly converted
to the format expected by the MoreButtonsMenu component

---
M web-jspack/org.openbravo.core2/src/components/ResponsiveToolbar/ResponsiveToolbar.jsx
---