0051940: Wrong query in ProductScanProductInfo component

Openbravo Issue Tracking System - POS2

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0051940

POS2

POS

public

2023-03-22 08:58

2023-03-23 08:27

Reporter

caristu

Assigned To

caristu

Priority

high

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

23Q2

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0051940: Wrong query in ProductScanProductInfo component

Description

The ProductScanProductInfo does a query for retrieving master data information of a product. This query is using a incorrect property on its where clause.

Steps To Reproduce

1) Login in the pos2
2) Go the orders window and select and order to open it
3) After the fix of 0051849 now the query fails. Before that fix, the query seemed to work but it was incorrectly defined.

Proposed Solution

Replace the current criteria:

      const productCriteria = new OB.App.Class.Criteria()
        .criterion('m_product_id', productId)
        .limit(1)
        .build();

with:

      const productCriteria = new OB.App.Class.Criteria()
        .criterion('id', productId)
        .limit(1)
        .build();

because the "m_product_id" property does not exists in the Product model, "id" must be used instead.

Additional Information