Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051932POS2Corepublic2023-03-21 16:262023-04-26 16:02
Reportercaristu 
Assigned Tocaristu 
PriorityimmediateSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q2 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression levelPre packaging ( pi )
Regression date2023-03-15
Regression introduced in release
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/c5dc904ad3e15c19bb99da437ccf090a873481b3 [^]
Triggers an Emergency PackNo
Summary0051932: Cannot persist reasons information when the selected reason is the empty option
DescriptionSelecting the empty option as reasons causes the following EWI when that information is persisted:

org.openbravo.base.exception.OBException: Could not save reasons and approvals
    at org.openbravo.core2.synchronization.ReasonAndApprovalDataPersister.saveReasonsAndApprovals(ReasonAndApprovalDataPersister.java:59)
Steps To Reproduce1) Add a product to a ticket
2) Click on the line and then in the "Return Line" button
3) A return reason will be requested, leave the reason blank (empty option) and click ok
4) Confirm the refund
5) In the backend a new EWI with the error mentioned in the description appears
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0051929 closed alostale removed cause of error from EWI when processing approvals 
related to defect 0051765 closed caristu Reasons and approvals of deleted ticket lines are not removed from the state 
caused by feature request 0051605 closed ignacio_deandres Support Return Reasons for return lines 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-03-21 16:26caristuNew Issue
2023-03-21 16:26caristuAssigned To => Triage Platform Base
2023-03-21 16:26caristuOBNetwork customer => No
2023-03-21 16:26caristuTriggers an Emergency Pack => No
2023-03-21 16:26caristuRelationship addedrelated to 0051929
2023-03-21 16:32caristuRegression level => Pre packaging ( pi )
2023-03-21 16:32caristuRegression date => 2023-03-15
2023-03-21 16:32caristuRegression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/c5dc904ad3e15c19bb99da437ccf090a873481b3 [^]
2023-03-21 16:32caristuAssigned ToTriage Platform Base => caristu
2023-03-21 16:32caristuRelationship addedcaused by 0051605
2023-03-21 16:52hgbotMerge Request Status => open
2023-03-21 16:52hgbotNote Added: 0147774
2023-03-28 07:44hgbotMerge Request Statusopen => approved
2023-03-28 07:44hgbotResolutionopen => fixed
2023-03-28 07:44hgbotStatusnew => closed
2023-03-28 07:44hgbotFixed in Version => 23Q2
2023-03-28 07:44hgbotNote Added: 0148011
2023-03-28 07:44hgbotNote Added: 0148012
2023-03-28 07:44hgbotNote Added: 0148013
2023-04-26 16:02rafarodaRelationship addedrelated to 0051765

Notes
(0147774)
hgbot   
2023-03-21 16:52   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1019 [^]
(0148011)
hgbot   
2023-03-28 07:44   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 89936d95157f5f325f666e74e578ddc5b7a945c5
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 28-03-2023 05:27:05
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/89936d95157f5f325f666e74e578ddc5b7a945c5 [^]

fixes BUG-51932: EWI caused when persisting an empty reason

---
M src-test/org/openbravo/core2/synchronization/ReasonAndApprovalPersisterTest.java
M src/org/openbravo/core2/synchronization/ReasonAndApprovalDataPersister.java
---
(0148012)
hgbot   
2023-03-28 07:44   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: af2ea74409b0a746d395c17a5b117ddcc3255d64
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 28-03-2023 05:27:05
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/af2ea74409b0a746d395c17a5b117ddcc3255d64 [^]

related to BUG-51932: avoid test failure when timezone changes

---
M src-test/org/openbravo/core2/synchronization/ReasonAndApprovalPersisterTest.java
---
(0148013)
hgbot   
2023-03-28 07:44   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1019 [^]