Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051897Retail ModulesDiscounts and Promotionspublic2023-03-17 10:162023-03-22 07:53
Reporternoemieroussel 
Assigned ToRetail 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR23Q2 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051897: [Promo] - Buy X Get Y - Promotion KO when product categories and / or product characteristics selected in the filters
DescriptionWith Buy X and get Y as a gift promo type, in two scenarios, the promo is not trigger:

->Product category only : Any X Any Y - KO

->Product characteristics only : Any X Any Y - KO

See video with product category: https://drive.google.com/file/d/1v5S-sUq5xRODHpZmmGIVXT4dzbxmn_Ly/view?usp=sharing [^]

See video with product characteristics:https://drive.google.com/file/d/1_faefp9B_ECTRg6QTGKTSJrABylaHGWN/view?usp=sharing [^]
Steps To ReproduceGo to the backoffice.

Create a new record in Discounts and promotions

Select "Buy X and get Y as a gift" promotion

Enter required fields (name, date, starting date=Yesterday, ending date=D+5)

Product category filter =Only those defined

Subtype = Buy Any X gift Any Y

X Unit=1

Y Unit MIN and MAX =1

Gift reminder notification= checked

Product category subtab = add one product

Gift product = add one product


Go to the POS and see that the promo is not displayed by adding eligible products
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0050706 closed prakashmurugesan88 [PROMO] - Product category and Characteristics KO in "Buy X and get Y as a gift" promotion 
related to defect 0051684 closed Retail Accumulating several filters for Promo type Buy X Get Y 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-03-17 10:16noemierousselNew Issue
2023-03-17 10:16noemierousselAssigned To => Retail
2023-03-17 10:16noemierousselTriggers an Emergency Pack => No
2023-03-17 12:00noemierousselSummaryBuy X Get Y is not displayed in POS => [Promo] - Buy X Get Y - Promotion KO when product categories and / or product characteristics selected in the filters
2023-03-17 12:00noemierousselDescription Updatedbug_revision_view_page.php?rev_id=25716#r25716
2023-03-20 09:36rafarodaRelationship addedrelated to 0051684
2023-03-20 11:12rafarodaRelationship addedrelated to 0050706
2023-03-20 12:40hgbotNote Added: 0147704
2023-03-22 07:53hgbotResolutionopen => fixed
2023-03-22 07:53hgbotStatusnew => closed
2023-03-22 07:53hgbotNote Added: 0147799
2023-03-22 07:53hgbotFixed in Version => RR23Q2
2023-03-22 07:53hgbotNote Added: 0147800

Notes
(0147704)
hgbot   
2023-03-20 12:40   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/96 [^]
(0147799)
hgbot   
2023-03-22 07:53   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/96 [^]
(0147800)
hgbot   
2023-03-22 07:53   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 40b69a4307131a0f7694ad64d8eeae4044d26aa3
Author: Prakash M <prakash@qualiantech.com>
Date: 22-03-2023 06:53:19
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/40b69a4307131a0f7694ad64d8eeae4044d26aa3 [^]

Fixed ISSUE-51897: Included Filter Option Validation for Buy Any X type in BuyXGiftY discount

---
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/buy-x-gift-y-discount.js
---