Openbravo Issue Tracking System - POS2
View Issue Details
0051891POS2POSpublic2023-03-16 18:382023-04-18 11:36
gorka_gil 
Vitaliy Malets 
normalmajoralways
closedfixed 
5
 
23Q3 
No
0051891: Pager flow: incorrect behavior in the pager flow
Finish button in pager flow (Apply) enable/disable behavior is not correct.

1st case:
- Till a code it is not entered, it should be disabled

2nd case:
- Next button in step 1 is disabled, after coming from step 2, when the finish button was disabled

3rd case:
- The Validate and Continue button should be disabled as well until pager code is not entered when we add new item.

4th case:
- The Line Popover should not be available on steps 1 and 2 when we edit an item


Also the finish button (Apply) has fewer checks that the ok button (validate and continue)
Case 1:
Go to the POS2 terminal and log in
Type 'Carbonio Helmet' in the POS2 search bar and add it
When the first step of the pager view appears, click 'Next' to go to the second step
ERROR : finish button (Apply) should be disabled, till entered a code

Case 2:
Go to the POS2 terminal and log in
Type 'Carbonio Helmet' in the POS2 search bar and add it
When the first step of the pager view appears, click 'Next' to go to the second step
Press any number of the keypad
Delete it -> Finish button gets disabled
Press back button (to go to step 1)
ERROR: Next button is disabled

Case 3:
The same as Case 1
ERROR : The Validate and Continue button should be disabled, till entered a code

Case 4:
The same as Case 1
Press Item line
ERROR: The Line Popover appears that allows the user to remove a line without finishing the editing process, and in this case, the pager still be visible in the Main window. The error exists for both steps.

Review all the logic to enable disable next and finish buttons.

Review finish logic to check if needed to add the missing validations, that ok button has.

Disable Validate and Continue buttons until pager code entered

Hide the Line Popover for steps 1 and 2
No tags attached.
related to defect 0050354 closed Vitaliy Malets Useless button in pager flow should be removed 
related to defect 0052143 closed Retail Pager flow: next button saves 
related to defect 0052146 scheduled Rajesh_18 0052143: Pager code is lost going back and forward 
png Screenshot from 2023-03-20 17-23-09.png (142,411) 2023-03-20 17:24
https://issues.openbravo.com/file_download.php?file_id=18282&type=bug
png

png Screenshot from 2023-03-20 17-31-04.png (70,835) 2023-03-20 17:31
https://issues.openbravo.com/file_download.php?file_id=18283&type=bug
png

png Screenshot from 2023-03-20 17-33-24.png (168,419) 2023-03-20 17:33
https://issues.openbravo.com/file_download.php?file_id=18284&type=bug
png

png Screenshot from 2023-03-20 17-33-55.png (117,295) 2023-03-20 17:34
https://issues.openbravo.com/file_download.php?file_id=18285&type=bug
png
Issue History
2023-03-16 18:38gorka_gilNew Issue
2023-03-16 18:38gorka_gilAssigned To => Vitaliy Malets
2023-03-16 18:38gorka_gilTriggers an Emergency Pack => No
2023-03-16 18:39gorka_gilRelationship addedrelated to 0050354
2023-03-20 17:22Vitaliy MaletsSummaryPager flow: incorrect disable behavior in finish button => Pager flow: incorrect behavior in the pager flow
2023-03-20 17:22Vitaliy MaletsDescription Updatedbug_revision_view_page.php?rev_id=25720#r25720
2023-03-20 17:22Vitaliy MaletsSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=25722#r25722
2023-03-20 17:22Vitaliy MaletsProposed Solution updated
2023-03-20 17:24Vitaliy MaletsProposed Solution updated
2023-03-20 17:24Vitaliy MaletsFile Added: Screenshot from 2023-03-20 17-23-09.png
2023-03-20 17:31Vitaliy MaletsFile Added: Screenshot from 2023-03-20 17-31-04.png
2023-03-20 17:33Vitaliy MaletsFile Added: Screenshot from 2023-03-20 17-33-24.png
2023-03-20 17:34Vitaliy MaletsFile Added: Screenshot from 2023-03-20 17-33-55.png
2023-03-22 12:58hgbotNote Added: 0147832
2023-03-24 13:17hgbotNote Added: 0147952
2023-04-17 18:36hgbotNote Added: 0148508
2023-04-17 18:36hgbotNote Added: 0148509
2023-04-17 18:39hgbotResolutionopen => fixed
2023-04-17 18:39hgbotStatusnew => closed
2023-04-17 18:39hgbotFixed in Version => 23Q3
2023-04-17 18:39hgbotNote Added: 0148510
2023-04-17 18:39hgbotNote Added: 0148511
2023-04-17 18:50gorka_gilRelationship addedrelated to 0052143
2023-04-18 11:36gorka_gilRelationship addedrelated to 0052146

Notes
(0147832)
hgbot   
2023-03-22 12:58   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1621 [^]
(0147952)
hgbot   
2023-03-24 13:17   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1027 [^]
(0148508)
hgbot   
2023-04-17 18:36   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 725ea0e9b1062cd7451cdc14ca08ca40aa2f6ec4
Author: Vitaliy <vitaliy.malets@openbravo.com>
Date: 17-04-2023 16:36:14
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/725ea0e9b1062cd7451cdc14ca08ca40aa2f6ec4 [^]

Related to ISSUE-51891: add test id to BaseSwipeableLine.jsx and ConfigSwipeableLine.jsx

---
M web-jspack/org.openbravo.core2/src/components/ConfigSwipeableLine/BaseSwipeableLine.jsx
M web-jspack/org.openbravo.core2/src/components/ConfigSwipeableLine/ConfigSwipeableLine.jsx
---
(0148509)
hgbot   
2023-04-17 18:36   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1027 [^]
(0148510)
hgbot   
2023-04-17 18:39   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: f22d8543ebc83ce7a4c5b6fae1ddd4015024ab2a
Author: Vitaliy <vitaliy.malets@openbravo.com>
Date: 17-04-2023 16:39:02
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/f22d8543ebc83ce7a4c5b6fae1ddd4015024ab2a [^]

Fixes ISSUE-51891: pager code button navigation behavior fixed

1) Finish button is disabled until the Pager code is entered.
2) Validate and Continue button is disabled until the Pager code is entered.
3) Next button is enabled when the user returns from the second step to the first step, even if the Pager code isn't entered.
4) Line popup is disabled for the first and second steps.

---
M web-jspack/org.openbravo.pos2/src/components/ScanPagerPanel/ScanPagerKeypad/BaseScanPagerKeypad.jsx
M web-jspack/org.openbravo.pos2/src/components/ScanPagerPanel/__test__/ScanPagerPanel.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLines.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/__test__/TicketLines.test.jsx
M web-jspack/org.openbravo.pos2/src/components/WaitingTimePanel/BaseWaitingTimePanel.jsx
M web-jspack/org.openbravo.pos2/src/components/WaitingTimePanel/__test__/BaseWaitingTimePanel.test.jsx
M web-jspack/org.openbravo.pos2/src/components/WaitingTimePanel/__test__/WaitingTimeDCMPanel.test.jsx
M web-jspack/org.openbravo.pos2/src/components/WaitingTimePanel/__test__/WaitingTimeProductPanel.test.jsx
M web-jspack/org.openbravo.pos2/src/core/pickupPoint/deliveryControl/pager/PagerDeliveryControlMethod.js
M web-jspack/org.openbravo.pos2/src/core/pickupPoint/deliveryControl/pager/__test__/PagerDeliveryControlMethod.test.js
---
(0148511)
hgbot   
2023-04-17 18:39   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1621 [^]