Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051864POS2Restaurantspublic2023-03-15 14:092023-03-23 09:28
Reporterruben_jimenez 
Assigned Toruben_jimenez 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version23Q1.1Fixed in Version23Q1.1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051864: RM-5481: Coupon reprint if return on order with counter product or coupon in an automatically detected menu
DescriptionIn case of automatic detected menu, the coupon can be printed twice (in case of coupon and counter mode). Actually the coupon is reprinted in that case and after going back to the ticket and pressing the payment button again.
Steps To Reproduce1- Create a sale by choosing a counter product or coupon included in the menu “Menu Flunch” and a drink from the menu “Menu Flunch”, for example: Cannelonis and Lipton ice tea

2- Click on pay, the menu is automatically generated

3- The menu “Menu Flunch” was detected automatically.

4- The product coupon is printed → OK it is the expected behavior

5 - Click on “back” button and then again on “PAY” -> Fail.The coupon is is printed again and it shouldn't
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0051881 closed ruben_jimenez RM-5481: Coupon reprint if return on order with counter product or coupon in an automatically detected menu 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-03-15 14:09ruben_jimenezNew Issue
2023-03-15 14:09ruben_jimenezAssigned To => ruben_jimenez
2023-03-15 14:09ruben_jimenezTriggers an Emergency Pack => No
2023-03-15 14:10ruben_jimenezStatusnew => scheduled
2023-03-15 14:18hgbotNote Added: 0147554
2023-03-16 10:32guilleaerStatusscheduled => acknowledged
2023-03-16 10:32guilleaerStatusacknowledged => scheduled
2023-03-16 10:33guilleaerTypedefect => backport
2023-03-16 10:33guilleaerTarget Version => 23Q1.1
2023-03-18 00:47hgbotNote Added: 0147667
2023-03-22 09:00ruben_jimenezNote Deleted: 0147554
2023-03-22 09:00ruben_jimenezNote Deleted: 0147667
2023-03-22 23:11hgbotNote Added: 0147856
2023-03-22 23:12hgbotNote Added: 0147859
2023-03-23 08:55ruben_jimenezNote Deleted: 0147856
2023-03-23 08:56ruben_jimenezNote Deleted: 0147859
2023-03-23 09:12hgbotNote Added: 0147875
2023-03-23 09:13hgbotNote Added: 0147876
2023-03-23 09:28hgbotResolutionopen => fixed
2023-03-23 09:28hgbotStatusscheduled => closed
2023-03-23 09:28hgbotNote Added: 0147877
2023-03-23 09:28hgbotFixed in Version => 23Q1.1
2023-03-23 09:28hgbotNote Added: 0147878
2023-03-23 09:28hgbotNote Added: 0147879
2023-03-23 09:28hgbotNote Added: 0147880

Notes
(0147875)
hgbot   
2023-03-23 09:12   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1624 [^]
(0147876)
hgbot   
2023-03-23 09:13   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/211 [^]
(0147877)
hgbot   
2023-03-23 09:28   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1624 [^]
(0147878)
hgbot   
2023-03-23 09:28   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: aae6b6937f89a1689ef4582de58d6eb47bea032f
Author: ruben.jimenez <ruben.jimenez@openbravo.com>
Date: 23-03-2023 09:11:21
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/aae6b6937f89a1689ef4582de58d6eb47bea032f [^]

Fixed ISSUE-51864:Prevent to revert auto discovered menus when auto discover menus is activated

---
A web-jspack/org.openbravo.pos2/src/core/pickupPoint/deliveryControl/coupon/CouponStateHandling.js
M web-jspack/org.openbravo.pos2/src/core/pickupPoint/PickupHandler.js
M web-jspack/org.openbravo.pos2/src/core/pickupPoint/deliveryControl/coupon/CouponDeliveryControlMethod.js
M web-jspack/org.openbravo.pos2/src/core/pickupPoint/deliveryControl/coupon/__test__/DoTicketPrepayment.test.js
M web-jspack/org.openbravo.pos2/src/core/pickupPoint/deliveryControl/registerDeliveryControlMethods.js
M web-jspack/org.openbravo.pos2/src/model/global/actions/DoCouponPrinting.js
---
(0147879)
hgbot   
2023-03-23 09:28   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/211 [^]
(0147880)
hgbot   
2023-03-23 09:28   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^]
Changeset: b1cb46f23f371ca1326af4039bfdb33455e4de73
Author: ruben.jimenez <ruben.jimenez@openbravo.com>
Date: 23-03-2023 09:08:53
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/b1cb46f23f371ca1326af4039bfdb33455e4de73 [^]

Fixed ISSUE-51864: Prevent to revert auto discovered menus when auto discover menus is activated

---
M web-jspack/org.openbravo.pos2.restaurant/src/core/pickupPoint/RestaurantPickupHandler.js
---