Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051840POS2POSpublic2023-03-13 10:162023-03-16 08:33
Reporterebecerra 
Assigned ToRetail 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version23Q1.1Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051840: Trying to do a VR of a ticket with menu with a discount of 100% fails
DescriptionWhen a menu is added to ticket and then a discount of 100% is applied, then VR cannot be done.
The taxes calculation fails because the menu lines have amount of zero and the calculation of line BOM taxes divide by sum of amount (div by zero exception).
Steps To ReproduceCreate an order
Add a menu
Apply a discount of 100%
Complete order
Search for previous order
Try to do VR
Error
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0051838 closed ebecerra Trying to do a VR of a ticket with menu with a discount of 100% fails 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-03-13 12:06guilleaerTypedefect => backport
2023-03-13 12:06guilleaerTarget Version => 23Q1.1
2023-03-16 08:31hgbotNote Added: 0147586
2023-03-16 08:33hgbotResolutionopen => fixed
2023-03-16 08:33hgbotStatusscheduled => closed
2023-03-16 08:33hgbotNote Added: 0147587
2023-03-16 08:33hgbotFixed in Version => RR23Q1.1
2023-03-16 08:33hgbotNote Added: 0147588

Notes
(0147586)
hgbot   
2023-03-16 08:31   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1103 [^]
(0147587)
hgbot   
2023-03-16 08:33   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1103 [^]
(0147588)
hgbot   
2023-03-16 08:33   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 63872c88e815751d98a561ff2e4cabbb4918c13a
Author: Eduardo Becerra <eduardo.becerra@openbravo.com>
Date: 16-03-2023 07:32:02
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/63872c88e815751d98a561ff2e4cabbb4918c13a [^]

Fixes ISSUE-51840: Fixes calculation of line BOM taxes when amount is zero

---
M web/org.openbravo.retail.posterminal/app/model/business-logic/taxes-engine/engine/tax-rules.js
---