Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051838POS2POSpublic2023-03-13 10:162023-03-15 14:05
Reporterebecerra 
Assigned Toebecerra 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051838: Trying to do a VR of a ticket with menu with a discount of 100% fails
DescriptionWhen a menu is added to ticket and then a discount of 100% is applied, then VR cannot be done.
The taxes calculation fails because the menu lines have amount of zero and the calculation of line BOM taxes divide by sum of amount (div by zero exception).
Steps To ReproduceCreate an order
Add a menu
Apply a discount of 100%
Complete order
Search for previous order
Try to do VR
Error
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 005184023Q1.1 closed Retail Trying to do a VR of a ticket with menu with a discount of 100% fails 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-03-13 10:16ebecerraNew Issue
2023-03-13 10:16ebecerraAssigned To => Retail
2023-03-13 10:16ebecerraOBNetwork customer => No
2023-03-13 10:16ebecerraTriggers an Emergency Pack => No
2023-03-13 10:29guilleaerSummaryWhen add a menu to ticket and applied a discount of 100% can not be a verified return => Trying to do a VR of a ticket with menu with a discount of 100% fails
2023-03-13 10:29guilleaerDescription Updatedbug_revision_view_page.php?rev_id=25674#r25674
2023-03-13 10:29guilleaerSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=25676#r25676
2023-03-13 10:45hgbotMerge Request Status => open
2023-03-13 10:45hgbotNote Added: 0147472
2023-03-13 12:06guilleaerStatusnew => scheduled
2023-03-15 14:05aferrazAssigned ToRetail => ebecerra
2023-03-15 14:05hgbotMerge Request Statusopen => approved
2023-03-15 14:05hgbotResolutionopen => fixed
2023-03-15 14:05hgbotStatusscheduled => closed
2023-03-15 14:05hgbotNote Added: 0147551
2023-03-15 14:05hgbotFixed in Version => RR23Q2
2023-03-15 14:05hgbotNote Added: 0147552

Notes
(0147472)
hgbot   
2023-03-13 10:45   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1095 [^]
(0147551)
hgbot   
2023-03-15 14:05   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1095 [^]
(0147552)
hgbot   
2023-03-15 14:05   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 8ca007a8d54b797febaf3d5be4a1f4990535bec6
Author: Eduardo Becerra (OB) <eduardo.becerra@openbravo.com>
Date: 15-03-2023 13:05:54
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/8ca007a8d54b797febaf3d5be4a1f4990535bec6 [^]

Fixes ISSUE-51838: Fixes calculation of line BOM taxes when amount is zero

---
M web/org.openbravo.retail.posterminal/app/model/business-logic/taxes-engine/engine/tax-rules.js
---