Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051804POS2POSpublic2023-03-08 11:332024-02-19 09:37
Reportercaristu 
Assigned ToRetail 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051804: Return Lines button label is not correct when used to "unreturn" multiple lines
DescriptionThe label of the Return Lines button is not properly updated when only returned lines are selected.
Steps To Reproduce1) Login in POS2
2) Add a couple of lines to the ticket
3) Select both lines
4) Open the Ticket popover by clicking on the three dots and press "Return Lines"
5) Click on the popover again. Note that if we press in the "Return Lines" button now the lines are correctly restored as not return lines, but the label of the button is incorrect, it is still "Return Lines"

Note that this behavior is different for the "Return Line" button, currently:

- The text is "Return Line" for returning
- The text is "Unreturn Line" for making the line a regular line again
Proposed SolutionThe same we do for the "Return Line" button when returning a single line: an special button that updates the text properly according to the current state and the received payload

TBD with UX the correct text to display
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0051605 closed ignacio_deandres Support Return Reasons for return lines 
related to defect 0054013 closed Rajesh_18 Return line missing in line multiselection 
Attached Filespng unreturn.png (36,315) 2023-03-08 11:34
https://issues.openbravo.com/file_download.php?file_id=18229&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2023-03-08 11:33caristuNew Issue
2023-03-08 11:33caristuAssigned To => Retail
2023-03-08 11:33caristuTriggers an Emergency Pack => No
2023-03-08 11:33caristuRelationship addedrelated to 0051605
2023-03-08 11:34caristuFile Added: unreturn.png
2023-03-08 12:06caristuProposed Solution updated
2023-03-08 12:08caristuSummaryReturn Lines button label should be "Unreturn Lines" when used to unreturn multiple lines => Return Lines button label is not correct when used to unreturn multiple lines
2023-03-08 12:08caristuDescription Updatedbug_revision_view_page.php?rev_id=25650#r25650
2023-03-08 12:08caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=25652#r25652
2023-03-08 12:08caristuProposed Solution updated
2023-03-08 12:09caristuSummaryReturn Lines button label is not correct when used to unreturn multiple lines => Return Lines button label is not correct when used to "unreturn" multiple lines
2023-03-08 12:09caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=25653#r25653
2024-02-19 09:37caristuReview Assigned To => caristu
2024-02-19 09:37caristuNote Added: 0160882
2024-02-19 09:37caristuStatusnew => closed
2024-02-19 09:37caristuResolutionopen => fixed
2024-02-19 09:37caristuRelationship addedrelated to 0054013

Notes
(0160882)
caristu   
2024-02-19 09:37   
Fixed with 0054013