Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051791Retail ModulesGift cards and gift voucherspublic2023-03-07 13:232023-04-04 07:53
Reportersofidossant 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Toguillermogil
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051791: Error in the creation of Gift Cards
DescriptionWhen we create a gift card with a user who does not have Admin permission,
Steps To Reproduce- We open a POS.
- We login with a user that does not have Admin permissions.
- We try to create a Gift Certificate.
- We define Expiration Date and Amount.
- We click on "Apply".
- The data is sent to the server, returns the Gift Card number, the ticket is printed at the POS,
but there is an error on the server and it is not created in BackOffice...

*The GiftCardCertificate class creates all the data correctly but does not make any flush at the end of the process. The next class that does the flush, does not have the setAdminMode enabled and an error occurs.
Proposed SolutionAttached diff
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0049511 closed adrianromero Gift cards push api and export improvements 
Attached Filesdiff giftCardCertificate.diff (438) 2023-03-07 13:23
https://issues.openbravo.com/file_download.php?file_id=18225&type=bug
Issue History
Date ModifiedUsernameFieldChange
2023-03-07 13:23sofidossantNew Issue
2023-03-07 13:23sofidossantAssigned To => Retail
2023-03-07 13:23sofidossantFile Added: giftCardCertificate.diff
2023-03-07 13:23sofidossantTriggers an Emergency Pack => No
2023-03-07 13:37PracticsIssue Monitored: Practics
2023-03-14 13:06ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2023-03-14 13:07ranjith_qualiantech_comStatusnew => scheduled
2023-03-15 06:34ranjith_qualiantech_comRelationship addedrelated to 0049511
2023-03-15 06:38ranjith_qualiantech_comNote Added: 0147526
2023-03-15 06:42hgbotNote Added: 0147527
2023-03-20 17:22hgbotResolutionopen => fixed
2023-03-20 17:22hgbotStatusscheduled => closed
2023-03-20 17:22hgbotNote Added: 0147718
2023-03-20 17:22hgbotNote Added: 0147719
2023-03-28 16:53sofidossantStatusclosed => new
2023-03-28 16:53sofidossantNote Added: 0148032
2023-04-03 06:52guillermogilNote Added: 0148171
2023-04-03 06:52guillermogilStatusnew => feedback
2023-04-04 07:53guillermogilStatusfeedback => scheduled
2023-04-04 07:53guillermogilStatusscheduled => resolved
2023-04-04 07:53guillermogilReview Assigned To => guillermogil
2023-04-04 07:53guillermogilNote Added: 0148220
2023-04-04 07:53guillermogilStatusresolved => closed

Notes
(0147526)
ranjith_qualiantech_com   
2023-03-15 06:38   
Problem mentioned in steps to reproduce is fixed in issue https://issues.openbravo.com/view.php?id=49511. [^] (By adding flush())
(0147527)
hgbot   
2023-03-15 06:42   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/197 [^]
(0147718)
hgbot   
2023-03-20 17:22   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 87484384f280d98bf8ea3b51fd4426f357c4f4c0
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 20-03-2023 17:20:36
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/87484384f280d98bf8ea3b51fd4426f357c4f4c0 [^]

Fixed ISSUE-51791: Session flush should be called after saving gift certificate
* Session flush should be called after saving gift certificate
  and updating giftcertificate sequence

---
M src/org/openbravo/retail/giftcards/GiftCardCertificate.java
---
(0147719)
hgbot   
2023-03-20 17:22   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/197 [^]
(0148032)
sofidossant   
2023-03-28 16:53   
We applied the fix and the problem continue
(0148171)
guillermogil   
2023-04-03 06:52   
Unable to reproduce.
Awaiting feedback from reporter
(0148220)
guillermogil   
2023-04-04 07:53   
Proposed patch was added in here: https://issues.openbravo.com/view.php?id=49511 [^]