Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051789Retail ModulesRetail APIpublic2023-03-07 12:282023-03-17 08:07
ReporterLeyre 
Assigned Toradhakrishnan 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR23Q2 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket58378
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051789: Using an external order loader it is possible to pay a canceled order
DescriptionUsing an external order loader it is possible to pay a canceled order
Steps To Reproduce1. Create a new layaway in the POS Terminal:
https://livebuilds.openbravo.com/retail_modules_pgsql_pi/web/org.openbravo.retail.posterminal/?terminal=VBS-1# [^]

2. Open the previous layaway in the POS Terminal and cancel it.

3. Configure Postman (Don't forget to add the Authorization) :
POST: https://livebuilds.openbravo.com/retail_modules_pgsql_pi/org.openbravo.mobile.core.service.jsonrest/org.openbravo.retail.posterminal.ExternalOrderLoader [^]

4. Add a json to update the payment for the previous canceled order and Send it.

- Result: verify that the order in the Backend has been updated, even it was previously canceled. The payment details have now a new line with the payment.

- Expected result: a new record should be created in the EWI window, indicating that it is not possible to pay a canceled order.

Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0052754 closed ranjith_qualiantech_com Order goes to Errors While Importing POS Data if the user tries to Cancel and Replace it twice 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-03-07 12:28LeyreNew Issue
2023-03-07 12:28LeyreAssigned To => Triage Platform Conn
2023-03-07 12:28LeyreOBNetwork customer => Gold
2023-03-07 12:28LeyreSupport ticket => 58378
2023-03-07 12:28LeyreTriggers an Emergency Pack => No
2023-03-07 12:28LeyrePrioritynormal => high
2023-03-07 12:46alostaleAssigned ToTriage Platform Conn => Retail
2023-03-14 08:40radhakrishnanAssigned ToRetail => radhakrishnan
2023-03-14 08:40radhakrishnanStatusnew => scheduled
2023-03-16 07:47hgbotMerge Request Status => open
2023-03-16 07:47hgbotNote Added: 0147583
2023-03-17 08:06hgbotMerge Request Statusopen => approved
2023-03-17 08:07hgbotResolutionopen => fixed
2023-03-17 08:07hgbotStatusscheduled => closed
2023-03-17 08:07hgbotNote Added: 0147639
2023-03-17 08:07hgbotFixed in Version => RR23Q2
2023-03-17 08:07hgbotNote Added: 0147640
2023-06-15 14:38ngarciaRelationship addedrelated to 0052754

Notes
(0147583)
hgbot   
2023-03-16 07:47   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1102 [^]
(0147639)
hgbot   
2023-03-17 08:07   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1102 [^]
(0147640)
hgbot   
2023-03-17 08:07   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 556ecdcee1ad0844a6e80400791840367167f57a
Author: Radhakrishnan Seeman <radhakrishnan@qualiantech.com>
Date: 17-03-2023 07:06:56
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/556ecdcee1ad0844a6e80400791840367167f57a [^]

Fixed ISSUE-51789: Cancelled order should not be allowed to modify
* When trying to modify a cancelled order/layaway from ExternalOrderLoader,
  the error should be shown

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/posterminal/OrderLoader.java
---