Openbravo Issue Tracking System - Modules
View Issue Details
0051776ModulesAdvanced Warehouse Operationspublic2023-03-03 20:022023-04-28 14:19
axelmercado 
AtulOpenbravo 
highmajoralways
closedfixed 
5
 
 
0051776: RM-4501: AWO - Put-away shows non-active target locations.
When a bin is deactivated in a warehouse for which a put-away task exists or is created, the deactivated slot appears as an option to perform the movement.

https://openbravo.atlassian.net/browse/RM-4501 [^]
1) In backoffice, deactivate (check Active = No) one of the storage bin in the warehouse.
2) In backoffice, go to "Warehouse Operations", select a line corresponding to the warehouse to be modified and click on the "Put-Away" button.
3) In the pop-up, enter a user assignment.
4) Access the FE with the previous user and check that there is a put-away task.
5) Click on the Target slot of the task and check that the non-active bin is offered as a candidate to move the product -> KO, non-active bins should be excluded.
No tags attached.
related to defect 0051018 closed AtulOpenbravo Openbravo ERP In AWO, If a storage bin is inactivated, it is possible to do a put away or reception in this storage bin 
Issue History
2023-03-03 20:02axelmercadoNew Issue
2023-03-03 20:02axelmercadoAssigned To => Triage Omni WMS
2023-03-03 20:25eugeniIssue Monitored: eugeni
2023-03-21 01:47AtulOpenbravoStatusnew => scheduled
2023-03-21 01:47AtulOpenbravoAssigned ToTriage Omni WMS => AtulOpenbravo
2023-03-21 02:26hgbotNote Added: 0147726
2023-03-21 02:33AtulOpenbravoNote Added: 0147727
2023-03-21 02:34AtulOpenbravoNote Edited: 0147727bug_revision_view_page.php?bugnote_id=0147727#r25725
2023-03-22 13:22SandrahuguetTypedefect => design defect
2023-03-22 13:24SandrahuguetNote Added: 0147834
2023-03-22 13:24hgbotNote Added: 0147835
2023-03-27 10:11AtulOpenbravoNote Added: 0147977
2023-03-27 10:11AtulOpenbravoTypedesign defect => defect
2023-03-27 13:18eugeniNote Added: 0147985
2023-03-27 13:19eugeniNote Edited: 0147985bug_revision_view_page.php?bugnote_id=0147985#r25771
2023-03-29 11:00mtaalSummaryAWO - Put-away shows non-active target locations. => RM-4501: AWO - Put-away shows non-active target locations.
2023-03-29 11:00mtaalDescription Updatedbug_revision_view_page.php?rev_id=25790#r25790
2023-03-30 15:08AtulOpenbravoNote Added: 0148120
2023-03-30 23:57axelmercadoNote Added: 0148131
2023-03-31 08:00hgbotNote Added: 0148142
2023-03-31 11:33mtaalRelationship addedrelated to 0051018
2023-04-03 08:50hgbotResolutionopen => fixed
2023-04-03 08:50hgbotStatusscheduled => closed
2023-04-03 08:50hgbotNote Added: 0148177
2023-04-03 08:50hgbotNote Added: 0148178
2023-04-03 08:50hgbotNote Added: 0148179
2023-04-03 10:12mtaalNote Added: 0148182
2023-04-03 10:13mtaalNote Edited: 0148182bug_revision_view_page.php?bugnote_id=0148182#r25811
2023-04-04 10:09eugeniNote Added: 0148240
2023-04-13 10:02mtaalNote Added: 0148427
2023-04-13 10:02mtaalStatusclosed => new
2023-04-13 10:02mtaalResolutionfixed => open
2023-04-13 10:02mtaalAssigned ToAtulOpenbravo => Sandrahuguet
2023-04-21 07:10mtaalNote Added: 0148672
2023-04-26 14:22hgbotNote Added: 0148926
2023-04-26 15:21AtulOpenbravoStatusnew => scheduled
2023-04-26 15:21AtulOpenbravoAssigned ToSandrahuguet => AtulOpenbravo
2023-04-26 15:28AtulOpenbravoNote Added: 0148930
2023-04-26 15:30AtulOpenbravoNote Edited: 0148930bug_revision_view_page.php?bugnote_id=0148930#r25970
2023-04-28 14:19hgbotResolutionopen => fixed
2023-04-28 14:19hgbotStatusscheduled => closed
2023-04-28 14:19hgbotNote Added: 0149078
2023-04-28 14:19hgbotNote Added: 0149079

Notes
(0147726)
hgbot   
2023-03-21 02:26   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/merge_requests/122 [^]
(0147727)
AtulOpenbravo   
2023-03-21 02:33   
(edited on: 2023-03-21 02:34)
Test Plan

- In backoffice, deactivate (check Active = No) one of the storage bin in the warehouse. If there is stock for any product available in the bin, it should be moved to some other bin using Goods Movement else application does not allow to set Active flag as No.
- In backoffice, go to "Warehouse Operations", select a line corresponding to the warehouse bin that was modified and click on the "Put-Away" button.
- In the pop-up, select a user for assignment.
- Access the FE with the previous selected user and check that there is a put-away task.
- Click on the task and in Storage Bin TO selector realize that the non-active bin is not available in the list.

(0147834)
Sandrahuguet   
2023-03-22 13:24   
Moved to design defect

If a bin with pending tasks is deactivated it is necessary to delete these tasks and generate again.
(0147835)
hgbot   
2023-03-22 13:24   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/merge_requests/122 [^]
(0147977)
AtulOpenbravo   
2023-03-27 10:11   
Axel:

Hi Atul, I am checking the issue https://issues.openbravo.com/view.php?id=51776 [^] because the client says that it is not reported correctly and that your test plan is also wrong. He has clarified to me that the problem is actually with a storage well that is disabled before creating the task. He showed me the following video: https://watch.screencastify.com/v/jmCt9dJFkXXrcqvZyqb1 [^]

What I find strange, is that I went in to check it but in the new tasks it no longer appears available for me to use. Could it be that the AWO terminal is taking too long to identify that the storage is not available?
(0147985)
eugeni   
2023-03-27 13:18   
(edited on: 2023-03-27 13:19)
Right video url is https://watch.screencastify.com/v/lW88auv7oDf3okC9iqeK [^]

(0148120)
AtulOpenbravo   
2023-03-30 15:08   
Changes done for issue https://issues.openbravo.com/view.php?id=51018 [^] would be reverted.

It is recommended to use Preference: No Auto Incremental Load at Login = No in order to have updated locator list by just refreshing the application.
(0148131)
axelmercado   
2023-03-30 23:57   
Several considerations for the customer:

1) I think it is not correct to revert https://issues.openbravo.com/view.php?id=51018, [^] without this fix, the full data load also considers the NOT active holes in the locator model.
2) I have configured the preference you mention (see attached) but I can't get it to force a full load (in the image I have left Entity = empty but I have also tried to put the customer entity, without success). How should it be configured to work?

In any case, enabling this preference is not an option for the client, since according to the documentation it affects the entire mobile infrastructure, including the POS (http://wiki.openbravo.com/wiki/Retail:MasterdataLoading#Configuration [^]). In this case, every time a POS terminal is logged in, 200 K customers, 30 K products, promotions, etc. would be refreshed, with a loading time of several minutes each time. In the case of the customer, who uses both AWO and POS, this option would not be feasible.
(0148142)
hgbot   
2023-03-31 08:00   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/merge_requests/124 [^]
(0148178)
hgbot   
2023-04-03 08:50   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/merge_requests/124 [^]
(0148179)
hgbot   
2023-04-03 08:50   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations [^]
Changeset: 56344afd38fe9f443c44765ce4ed60703b7b96bd
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 03-04-2023 06:49:44
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/commit/56344afd38fe9f443c44765ce4ed60703b7b96bd [^]

Fixes BUG-0051776: RM-4501: AWO - Put-away shows non-active target
locations.

**Remove activeCriteria from Locator query as it prevent master
data update in MasterDataController for inactive locators.
**Set preference No Auto Incremental Load at Login = No in order
to have updated list of locators that were changed in the back
office by just refreshing the application.

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/master/Locator.java
---
(0148177)
hgbot   
2023-04-03 08:50   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations [^]
Changeset: 1a0f57b115f74d115630b33ffa3c80e826410f9f
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 03-04-2023 06:49:44
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/commit/1a0f57b115f74d115630b33ffa3c80e826410f9f [^]

Fixes BUG-0051776: AWO - Put-away shows non-active target locators

**Added active filter in external locators hql query

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/master/Locator.java
---
(0148182)
mtaal   
2023-04-03 10:12   
(edited on: 2023-04-03 10:13)
Hi Axel,
1) I think it is not correct to revert https://issues.openbravo.com/view.php?id=51018, [^] [^] without this fix, the full data load also considers the NOT active holes in the locator model.
--> the 51018 solution was wrong, it causes incremental the not remove inactive records
--> is fine to read from the server, the non-active records will be removed/not inserted in the client indexed db

2) I have configured the preference you mention (see attached) but I can't get it to force a full load (in the image I have left Entity = empty but I have also tried to put the customer entity, without success). How should it be configured to work?
--> which image are you referring to?
--> the preference only influences if incremental load is always done at login, it does not force full load or influence periodic incremental load.
--> as far as we understand, even with this preference to Y, it should still do incremental loads periodically. What is the incremental load period for this client?

(0148240)
eugeni   
2023-04-04 10:09   
Hi Martin

- What is the incremental load period for this client? --> Don't know where we can configure this load period. For POS terminals it is defined at terminal type level, however for WMS terminals I didn't find the place
- Anyway, as suggested, we have configured preference "No Auto Incremental Load at Login" = N

1) We forced updated = now() for a non-active bin. Then login in WMS terminal 1, create a put-away task from the FE: non active bin is not shown (that's OK)
2) Then login in a different WMS terminal (terminal 2). Do the same. Even a full load has been performed at login, non-active bin is shown (that's not OK)

Thanks!
Eugeni
(0148427)
mtaal   
2023-04-13 10:02   
Re-opened to research the issue
(0148672)
mtaal   
2023-04-21 07:10   
Topic:
- if a storage bin is set to inactive it is loaded when login in --> this is correct as storage bin load uses the same logic as general POS masterdata loads
this means that inactive data is loaded from the server to the client
- on the client the inactive flag should be used to remove the data from indexeddb
- it could be that the issue is on the client somewhere that the inactive storage bins are still saved in the indexeddb
- to check: the same should happen for incremental load, so if you set a storage bin to inactive then it should still be sent from server to client in incremental load and then it should remove the storage bin from indexeddb
(0148926)
hgbot   
2023-04-26 14:22   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/merge_requests/133 [^]
(0148930)
AtulOpenbravo   
2023-04-26 15:28   
(edited on: 2023-04-26 15:30)
Test Plan

- Login with System Admin role.
- Set preference No Auto Incremental Load at Login with value N
- Log out

- Login with AWOQAAdmin in the Back Office.
- Create a new Locator Food004 under US West Coast Warehouse.
- Set Active = No.
- Login in AWO Front End using AWOQAdmin role in same browser or other browser session.
- Navigate to Put Away menu, search for product Ale Beer. Click on it.
- Navigate to Put Away task and click on it.
- Click on TO Bin selector.
- Realize that locator Food004 does not appear in the list.

- Login in other browser session with same or other user. (using new Incognito window)
- Navigate to Put Away menu, search for product Ale Beer. Click on it.
- Navigate to Put Away task and click on it.
- Click on TO Bin selector.
- Realize that locator Food004 does not appear in the list.

- Navigate to Locator definition in Back Office and set it as Active = Yes.
- Navigate to Front End again and do a refresh or press F5
- Navigate to Put Away task and click on it.
- Click on TO Bin selector.
- Realize that locator Food004 appears in the list.

- Login in other browser session with same or other user. (using new Incognito window)
- Navigate to Put Away menu, search for product Ale Beer. Click on it.
- Navigate to Put Away task and click on it.
- Click on TO Bin selector.
- Realize that locator Food004 appears in the list.

(0149078)
hgbot   
2023-04-28 14:19   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations [^]
Changeset: c70f7efd9c55df8b2de9ab1e887b132c6ee453c8
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 26-04-2023 12:22:56
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/commit/c70f7efd9c55df8b2de9ab1e887b132c6ee453c8 [^]

Fixes BUG-0051776: RM-4501: AWO - Put-away shows non-active
target locations.

**if it is incremental update do not apply active criteria
in locator query else apply active criteria.

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/master/Locator.java
---
(0149079)
hgbot   
2023-04-28 14:19   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/merge_requests/133 [^]