0051763: Problem with SVAP adjust price when you put a modification price reason

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0051763

Retail Modules

Web POS

public

2023-03-02 16:44

2023-03-29 09:49

Reporter

Benjamin Molin

Assigned To

ranjith_qualiantech_com

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Openbravo Appliance 14.04

Product Version

Target Version

Fixed in Version

RR23Q2

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0051763: Problem with SVAP adjust price when you put a modification price reason

Description

When discounting (price modification reason) 1 product with at least 2 products on the ticket, SVAP does not adjust the price for the modified product.

Steps To Reproduce

The addition is of these 2 back office preferences to enable SVAP:

Web POS Sales Loss Approval.
Configure it as follows:
Customer: White Valley Group
Organization: Vall Blanca Store
Property: Approval of lost sales on the Web POS
Value: Y

In the Visibility section
Visible in the client: The White Valley Group
Visible in the role: VallBlancaUser

Register

Web POS Enable sales at a loss
Configure it as follows:
Client: White Valley Group
Organization: Vall Blanca store
Property: Losses due to Web POS activation
Value: Y

In the Visibility section
Visible to the client: The White Valley Group
Visible to the Organization: Vall Blanca Store

Save

Window Price modification reason, activate or add 1 modification reason and check the box verifi price limit

Web POS:

add a product with a price limit set its price to 10 euros
add another product
press payment
press Adjust
the product with the modified price does not have its price to change.

Proposed Solution

We found this error on Weldom and we found this solution.

Please let me know if I can offer this solution to Weldom.

The error is reproducible on the livebuild.

Code:
OB.UTIL.LossSaleUtils.adjustPriceOnLossSaleLines = function(lossSaleLines) {
    var order = OB.MobileApp.model.receipt;
    lossSaleLines.forEach(function(lossSaleLine) {
      var line = order
          .get('lines')
          .models.find(l => l.get('id') === lossSaleLine.lineId),
        discountedPrice = line.get('discountedPrice'),
        productPriceLimit = line.get('product').get('priceLimit');
      if (line.get('promotions') && line.get('promotions').length) {
        line.get('promotions').forEach(function(p) {
          if (discountedPrice < productPriceLimit) {
            var promoAmtDiffToLimit = OB.Discounts.discountRules[p.discountType]
              .isPriceAdjustmentByProduct
              ? OB.DEC.sub(productPriceLimit, discountedPrice) * line.get('qty')
              : Math.min(
                  p.actualAmt,
                  OB.DEC.sub(productPriceLimit, discountedPrice) *
                    line.get('qty')
                );

            p.amt = p.fullAmt = p.actualAmt = p.displayedTotalAmount = OB.DEC.sub(
              p.actualAmt,
              promoAmtDiffToLimit
            );
            p.identifier =
              p.name +
              ' - ' +
              (p.manual
                ? OB.I18N.getLabel('OBPOS_LblSVAP')
                : OB.I18N.getLabel('OBPOS_LblLimitPrice'));
            discountedPrice += promoAmtDiffToLimit;
          }
        });
      } else {
        order.setPrices([line], productPriceLimit);
      }
      order.calculateGross();
    });
  };

Additional Information