Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051762POS2POSpublic2023-03-02 16:182023-07-10 10:01
Reportercharlotte_vasseur 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q4 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051762: Cashup report : total startings and total startings counted display payment methods not needed
DescriptionWhen ‘Hide count Information to cashier' and 'Hide cashup information to cashier' = N
In the cashup report, section 'Total Startings' : we should not see 'Starting Card' line (because nothing is expected as nothing is kept in the previous cashup)
Section 'Total Startings Counted' : we should not see 'Starting Card' and 'Starting Voucher' lines (because they are not counted in the initial count)
Steps To ReproduceIn backoffice, configure preferences 'Hide count Information to cashier' and 'Hide cashup information to cashier' = N

In POS, open the till, make a sell, close the till
In window 'Amount to keep', only Cash, USA Cash and Voucher are displayed (see Payment methods to keep.png)
Enter amounts and do the cash up

Open the till again
In window 'Initial count', only Cash and USA Cash are displayed (see Payment methods intial count.png)
Make a sell, close the till and go to cash up report
=> In 'Total Startings', Card payment method should not be displayed because nothing is expected as no amount is kept for this payment method
=> In 'Total Startings Counted', Card and Voucher should not be displayed as they are not counted in the initial count
See Hide N cash up report.png


Same if preferences 'Hide count Information to cashier' and 'Hide cashup information to cashier' = Y
=> In 'Total Startings Counted', Card and Voucher should not be displayed as they are not counted in the initial count
See Hide Y cash up report.png
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0051704 closed ranjith_qualiantech_com Closing report : display 'Initial Counted Amount' in the report 
Attached Filespng Payment methods to keep.png (66,707) 2023-03-02 16:18
https://issues.openbravo.com/file_download.php?file_id=18210&type=bug
png

png Payment methods intial count.png (58,313) 2023-03-02 16:18
https://issues.openbravo.com/file_download.php?file_id=18211&type=bug
png

png Hide N cash up report.png (106,389) 2023-03-02 16:18
https://issues.openbravo.com/file_download.php?file_id=18212&type=bug
png

png Hide Y cash up report.png (100,687) 2023-03-02 16:18
https://issues.openbravo.com/file_download.php?file_id=18213&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2023-03-02 16:18charlotte_vasseurNew Issue
2023-03-02 16:18charlotte_vasseurAssigned To => Retail
2023-03-02 16:18charlotte_vasseurFile Added: Payment methods to keep.png
2023-03-02 16:18charlotte_vasseurTriggers an Emergency Pack => No
2023-03-02 16:18charlotte_vasseurFile Added: Payment methods intial count.png
2023-03-02 16:18charlotte_vasseurFile Added: Hide N cash up report.png
2023-03-02 16:18charlotte_vasseurFile Added: Hide Y cash up report.png
2023-04-06 23:47rafarodaOBNetwork customer => Gold
2023-04-12 09:08ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2023-04-12 13:07ranjith_qualiantech_comStatusnew => scheduled
2023-06-01 06:40ranjith_qualiantech_comRelationship addeddepends on 0051704
2023-06-19 13:48hgbotMerge Request Status => open
2023-06-19 13:48hgbotNote Added: 0151302
2023-06-19 13:48hgbotNote Added: 0151303
2023-06-19 13:48hgbotNote Added: 0151304
2023-07-05 06:48hgbotNote Added: 0152116
2023-07-10 09:59hgbotMerge Request Statusopen => approved
2023-07-10 10:00hgbotNote Added: 0152248
2023-07-10 10:00hgbotNote Added: 0152249
2023-07-10 10:01hgbotNote Added: 0152250
2023-07-10 10:01hgbotNote Added: 0152251
2023-07-10 10:01hgbotNote Added: 0152252
2023-07-10 10:01hgbotNote Added: 0152253
2023-07-10 10:01hgbotNote Added: 0152254
2023-07-10 10:01hgbotResolutionopen => fixed
2023-07-10 10:01hgbotStatusscheduled => closed
2023-07-10 10:01hgbotFixed in Version => 23Q4
2023-07-10 10:01hgbotNote Added: 0152255

Notes
(0151302)
hgbot   
2023-06-19 13:48   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1901 [^]
(0151303)
hgbot   
2023-06-19 13:48   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1250 [^]
(0151304)
hgbot   
2023-06-19 13:48   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/merge_requests/88 [^]
(0152116)
hgbot   
2023-07-05 06:48   
Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/301 [^]
(0152248)
hgbot   
2023-07-10 10:00   
Merge request merged: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/301 [^]
(0152249)
hgbot   
2023-07-10 10:00   
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: ea336e0f1eb32634968edc793cdefaeec2e23a1d
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 10-07-2023 08:00:34
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/ea336e0f1eb32634968edc793cdefaeec2e23a1d [^]

Verifies ISSUE-51762: Updated Cashup Automated tests

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/CashupTwice.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I26806_CashupTotalNotShown.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I28181_CashupWrongWithdrawalSummary.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I28714_VerifyTotalReturns.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I28714_VerifyTotalReturnsII.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I29733_CashupQuantityButton.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I30872_CashupPaymentNamesI.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I31116_CashupSalesAndReturns.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I31243_CashupPaymentNames.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I38641_AgileCashUp.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/MultiterminalSaleAndCashupVerifyingDatabase.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/SaleAndCashupVerifyingDatabaseII.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I28322_WrongInvoiceWhenPayingLayawayWithCreditI.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I28322_WrongInvoiceWhenPayingLayawayWithCreditII.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/Layaway_Cre1Cancel2.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/Layaway_Cre1Fin1.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/Layaway_Cre1Fin2.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/Layaway_Cre1Par1Fin2.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/Layaway_Cre1Par2Cancel3.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/Layaway_Cre1Par2Fin1.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/Layaway_Cre1Par2Fin2.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/Layaway_Cre1Par2Fin3.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/I28714_NoCashAvailableWithCashupCheck.java
---
(0152250)
hgbot   
2023-07-10 10:01   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/merge_requests/88 [^]
(0152251)
hgbot   
2023-07-10 10:01   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1250 [^]
(0152252)
hgbot   
2023-07-10 10:01   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^]
Changeset: 1450b8d7d3035b2a60687aee1d55b0efb4b64146
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 10-07-2023 08:00:49
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/1450b8d7d3035b2a60687aee1d55b0efb4b64146 [^]

Related to ISSUE-51762: Total starting counted display logic updated in cashup report

---
M web/org.openbravo.retail.sessions/js/hook/editCashupReport.js
---
(0152253)
hgbot   
2023-07-10 10:01   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 6b5dcca75b02f7ff8ffd57f22fa12d8b29f08b3a
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 10-07-2023 08:00:55
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/6b5dcca75b02f7ff8ffd57f22fa12d8b29f08b3a [^]

Related to ISSUE-51762: Total starting display logic updated in cashup report

---
M web/org.openbravo.retail.posterminal/js/closecash/model/cashup/cashup-model.js
---
(0152254)
hgbot   
2023-07-10 10:01   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1901 [^]
(0152255)
hgbot   
2023-07-10 10:01   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: e6b7b1d8512fd4c3804a40ecc9de518120e7a62a
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 10-07-2023 08:01:19
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/e6b7b1d8512fd4c3804a40ecc9de518120e7a62a [^]

Fixed ISSUE-51762: Total starting display logic updated in cashup report

---
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/PostPrintAndCloseStep/utils/getCashupData.js
---