Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051756Retail ModulesOffline Modepublic2023-03-02 11:422023-03-15 14:33
Reportermigueldejuana 
Assigned Tomigueldejuana 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR23Q2 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression levelProduction - Confirmed Stable
Regression date
Regression introduced in releaseRR20Q3.4
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051756: There are several issues with Offline status icon and Pending Sync. popup
Description- When go to offline when doing a Failover request (i.e.:Search Orders) the Offline icon is not shown
- When go to offline when doing a Failover request (i.e.:Search Orders) and then, we synchronize something (i.e.:Process and Order) the Offline icon is not shown and Synchronizing icon is shown instead
- When we go back to online and we star synchronizing, the icon is not rotating
- When opening Pending Sync. popup in AWO we get a js error
Steps To Reproducen/a
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-03-02 11:42migueldejuanaNew Issue
2023-03-02 11:42migueldejuanaAssigned To => migueldejuana
2023-03-02 11:42migueldejuanaRegression level => Production - Confirmed Stable
2023-03-02 11:42migueldejuanaRegression introduced in release => RR20Q3.4
2023-03-02 11:42migueldejuanaTriggers an Emergency Pack => No
2023-03-02 11:46migueldejuanaSummaryThere are several issues with Offline status icon => There are several issues with Offline status icon and Pending Sync. popup
2023-03-02 11:46migueldejuanaDescription Updatedbug_revision_view_page.php?rev_id=25626#r25626
2023-03-02 12:17hgbotNote Added: 0147230
2023-03-09 08:11hgbotResolutionopen => fixed
2023-03-09 08:11hgbotStatusnew => closed
2023-03-09 08:11hgbotNote Added: 0147396
2023-03-09 08:11hgbotFixed in Version => RR23Q2
2023-03-09 08:11hgbotNote Added: 0147397
2023-03-09 08:11hgbotNote Added: 0147398
2023-03-10 10:43hgbotNote Added: 0147437
2023-03-13 10:43hgbotNote Added: 0147471
2023-03-15 14:33hgbotNote Added: 0147557
2023-03-15 14:33hgbotNote Added: 0147558
2023-03-15 14:33hgbotNote Added: 0147559

Notes
(0147230)
hgbot   
2023-03-02 12:17   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/478 [^]
(0147396)
hgbot   
2023-03-09 08:11   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/478 [^]
(0147397)
hgbot   
2023-03-09 08:11   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: b9f4570a884844cf8478d98542fe875b61aa1e34
Author: miguel.dejuana <miguel.dejuana@openbravo.com>
Date: 09-03-2023 07:11:18
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/b9f4570a884844cf8478d98542fe875b61aa1e34 [^]

Fixed ISSUE-51756: There are several issues with Offline status icon and Pending Sync. popup

- When openning Pending Sync. popup from AWO is failing because there messageIdentifiers, avoid this
- Spin animation has been removed, added it again and set icon to 15px to be a bit bigger. Use proper css class to allow icon execute the animation
- Execute showSyncStatus in processStarted for 'checkMessagesToSync' to allow apply changes also when the process starts
- In showSyncStatus handle properly offline and online flows to update the status and icon behaviour
- When showing Pending Sync. button, remove unneded if (processesInExec.models.length === 0)

---
M web/org.openbravo.mobile.core/app/model/application-state/StateAPI.js
M web/org.openbravo.mobile.core/assets/css/obmobc-main.css
M web/org.openbravo.mobile.core/source/component/legacy/ob-legacy.js
M web/org.openbravo.mobile.core/source/component/ob-menu.js
M web/org.openbravo.mobile.core/source/utils/SyncIconManagement.js
---
(0147398)
hgbot   
2023-03-09 08:11   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 7cc69c354f0ce7e1243598fd7358f0533e6d4f36
Author: miguel.dejuana <miguel.dejuana@openbravo.com>
Date: 09-03-2023 07:11:18
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/7cc69c354f0ce7e1243598fd7358f0533e6d4f36 [^]

Fixed ISSUE-51756: Show Synchronization Monitor error only after app is up

---
M web/org.openbravo.mobile.core/source/component/legacy/ob-legacy.js
---
(0147437)
hgbot   
2023-03-10 10:43   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: f5e13051daa654a0d3c2b69723a18d19e4873f8c
Author: Sandra Huguet <sandra.huguet@openbravo.com>
Date: 10-03-2023 10:42:44
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/f5e13051daa654a0d3c2b69723a18d19e4873f8c [^]

Revert "Fixed ISSUE-51756"

This reverts commit 7cc69c354f0ce7e1243598fd7358f0533e6d4f36.

This reverts commit b9f4570a884844cf8478d98542fe875b61aa1e34.

---
M web/org.openbravo.mobile.core/app/model/application-state/StateAPI.js
M web/org.openbravo.mobile.core/assets/css/obmobc-main.css
M web/org.openbravo.mobile.core/source/component/legacy/ob-legacy.js
M web/org.openbravo.mobile.core/source/component/ob-menu.js
M web/org.openbravo.mobile.core/source/utils/SyncIconManagement.js
---
(0147471)
hgbot   
2023-03-13 10:43   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/485 [^]
(0147557)
hgbot   
2023-03-15 14:33   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/485 [^]
(0147558)
hgbot   
2023-03-15 14:33   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 8c202bb5db7c12df40cda5104e80e7f1a641d0d2
Author: miguel.dejuana <miguel.dejuana@openbravo.com>
Date: 15-03-2023 06:58:13
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/8c202bb5db7c12df40cda5104e80e7f1a641d0d2 [^]

Fixed ISSUE-51756: There are several issues with Offline status icon and Pending Sync. popup

- When openning Pending Sync. popup from AWO is failing because there messageIdentifiers, avoid this
- Spin animation has been removed, added it again and set icon to 15px to be a bit bigger. Use proper css class to allow icon execute the animation
- Execute showSyncStatus in processStarted for 'checkMessagesToSync' to allow apply changes also when the process starts
- In showSyncStatus handle properly offline and online flows to update the status and icon behaviour
- When showing Pending Sync. button, remove unneded if (processesInExec.models.length === 0)

---
M web/org.openbravo.mobile.core/app/model/application-state/StateAPI.js
M web/org.openbravo.mobile.core/assets/css/obmobc-main.css
M web/org.openbravo.mobile.core/source/component/legacy/ob-legacy.js
M web/org.openbravo.mobile.core/source/component/ob-menu.js
M web/org.openbravo.mobile.core/source/utils/SyncIconManagement.js
---
(0147559)
hgbot   
2023-03-15 14:33   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: e99591a2dbd6c8ded06bf9e731b0f5491ea523ba
Author: miguel.dejuana <miguel.dejuana@openbravo.com>
Date: 15-03-2023 06:58:13
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/e99591a2dbd6c8ded06bf9e731b0f5491ea523ba [^]

Fixed ISSUE-51756: Remove unneeded validation

---
M web/org.openbravo.mobile.core/source/component/legacy/ob-legacy.js
M web/org.openbravo.mobile.core/source/component/ob-menu.js
---