Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051715POS2Corepublic2023-02-28 09:082023-02-28 10:29
ReporterAugustoMauch 
Assigned ToTriage Platform Base 
PriorityimmediateSeveritycriticalReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version23Q1.1Fixed in Version23Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression levelPackaging and release
Regression date2023-02-24
Regression introduced in releasemain
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/d1f188bffbee9b950e2adc631b3b8a222af54b4a [^]
Triggers an Emergency PackNo
Summary0051715: Keymap Categories cannot be edited
DescriptionThis [1] change was done to ensure that no keymap categories are defined with the same name for a given organization a given keymap version.

The change has a bug and as a consecuence it is not possible to edit a keymap category in the keymap editor

[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/d1f188bffbee9b950e2adc631b3b8a222af54b4a [^]
Steps To Reproduce- Open POS2
- Open the Keymap Editor
- Select a Keymap
- Select a Keymap Version
- Click on VIEW CATEGORIES
- Click on New Category -> Create a new one named Test -> Save
- Edit the category created in the step before -> Update its description -> A "Name is duplicated" error is displayed
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0051714 closed Triage Platform Base Keymap Categories cannot be edited 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-02-28 09:11AugustoMauchTypedefect => backport
2023-02-28 09:11AugustoMauchTarget Version => 23Q1.1
2023-02-28 10:28hgbotNote Added: 0147100
2023-02-28 10:29hgbotResolutionopen => fixed
2023-02-28 10:29hgbotStatusscheduled => closed
2023-02-28 10:29hgbotFixed in Version => 23Q1
2023-02-28 10:29hgbotNote Added: 0147101
2023-02-28 10:29hgbotNote Added: 0147102

Notes
(0147100)
hgbot   
2023-02-28 10:28   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1557 [^]
(0147101)
hgbot   
2023-02-28 10:29   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 09962896119845828a67493717d48a8f849b78ca
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 28-02-2023 09:25:58
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/09962896119845828a67493717d48a8f849b78ca [^]

Fixes ISSUE-51715: Categories can be edited, ID is taken into account when looking for duplicated names
When looking for categories that have the same name of a category that is being created/edited we are now taking into account the
 category ids, to ensure we dont detect as a duplicate the category we are currently editing

---
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/KeymapEditorNewCategoryDialog/KeymapEditorCategoryDialog.jsx
---
(0147102)
hgbot   
2023-02-28 10:29   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1557 [^]