Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051714POS2Corepublic2023-02-28 09:082023-02-28 09:33
ReporterAugustoMauch 
Assigned ToTriage Platform Base 
PriorityimmediateSeveritycriticalReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q2 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression levelPackaging and release
Regression date2023-02-24
Regression introduced in releasemain
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/d1f188bffbee9b950e2adc631b3b8a222af54b4a [^]
Triggers an Emergency PackNo
Summary0051714: Keymap Categories cannot be edited
DescriptionThis [1] change was done to ensure that no keymap categories are defined with the same name for a given organization a given keymap version.

The change has a bug and as a consecuence it is not possible to edit a keymap category in the keymap editor

[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/d1f188bffbee9b950e2adc631b3b8a222af54b4a [^]
Steps To Reproduce- Open POS2
- Open the Keymap Editor
- Select a Keymap
- Select a Keymap Version
- Click on VIEW CATEGORIES
- Click on New Category -> Create a new one named Test -> Save
- Edit the category created in the step before -> Update its description -> A "Name is duplicated" error is displayed
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 005171523Q1.1 closed Triage Platform Base Keymap Categories cannot be edited 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-02-28 09:08AugustoMauchNew Issue
2023-02-28 09:08AugustoMauchAssigned To => Triage Platform Base
2023-02-28 09:08AugustoMauchOBNetwork customer => No
2023-02-28 09:08AugustoMauchRegression level => Packaging and release
2023-02-28 09:08AugustoMauchRegression date => 2023-02-24
2023-02-28 09:08AugustoMauchRegression introduced in release => main
2023-02-28 09:08AugustoMauchRegression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/d1f188bffbee9b950e2adc631b3b8a222af54b4a [^]
2023-02-28 09:08AugustoMauchTriggers an Emergency Pack => No
2023-02-28 09:11hgbotMerge Request Status => open
2023-02-28 09:11hgbotNote Added: 0147084
2023-02-28 09:11AugustoMauchStatusnew => scheduled
2023-02-28 09:32hgbotMerge Request Statusopen => approved
2023-02-28 09:33hgbotResolutionopen => fixed
2023-02-28 09:33hgbotStatusscheduled => closed
2023-02-28 09:33hgbotFixed in Version => 23Q2
2023-02-28 09:33hgbotNote Added: 0147089
2023-02-28 09:33hgbotNote Added: 0147090

Notes
(0147084)
hgbot   
2023-02-28 09:11   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1554 [^]
(0147089)
hgbot   
2023-02-28 09:33   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 4f0f82df10653d2d59e09c0cec8c91166ebf6459
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 28-02-2023 09:12:20
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/4f0f82df10653d2d59e09c0cec8c91166ebf6459 [^]

Fixes ISSUE-51714: Categories can be edited, ID is taken into account when looking for duplicated names
When looking for categories that have the same name of a category that is being created/edited we are now taking into account the
 category ids, to ensure we dont detect as a duplicate the category we are currently editing

---
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/KeymapEditorNewCategoryDialog/KeymapEditorCategoryDialog.jsx
---
(0147090)
hgbot   
2023-02-28 09:33   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1554 [^]