Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051699ModulesDistribution Orderspublic2023-02-24 16:462023-02-27 19:23
Reporterjlopez 
Assigned Tojlopez 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary0051699: All JUnit test cases of the Distribution Orders module finish with errors
DescriptionIf you try to launch the Junit suite of the Distribution Orders module in an environment where the following module is not found:

 - org.openbravo.warehouse.advancedwarehouseoperations.distributionorders (Connector to support Distribution Orders in Advanced Warehouse Operations)

The execution of the tests will fail giving the following exception:

org.openbravo.base.validation.ValidationException: ADPreference.property: Property ADPreference.property, value (OBDOA_DeleteNonConfTaskAndResWhenCloseDO) is not allowed, it should be one of the following values: [...] but it is value OBDOA_DeleteNonConfTaskAndResWhenCloseDO

This preference is found in the mentioned module, which is not dependence on the Distribution Orders module.
Steps To ReproduceLaunch the test suite without the module: org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Proposed SolutionDelete the following lines of the next class to avoid dependence:

org.openbravo.distributionorder.testOBDO_FB_WeldBaseTest.java

Line 56: DistributionOrderTestUtils.setDeleteNonConfirmedTaskAndReservationsPreference();

Line 62: DistributionOrderTestUtils.unsetDeleteNonConfirmedTaskAndReservationsPreference();
Additional Information
TagsNo tags attached.
Relationships
blocks feature request 0051542 closed jlopez POS2 Stock for a product in Transit by Warehouse 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-02-24 16:46jlopezNew Issue
2023-02-24 16:46jlopezAssigned To => jlopez
2023-02-24 16:46jlopezOBNetwork customer => No
2023-02-24 16:53jlopezRelationship addedblocks 0051150
2023-02-24 16:55jlopezRelationship addedblocks 0051542
2023-02-24 16:57jlopezRelationship deletedblocks 0051150
2023-02-24 17:04hgbotMerge Request Status => open
2023-02-24 17:04hgbotNote Added: 0146998
2023-02-27 15:22hgbotMerge Request Statusopen => approved
2023-02-27 16:02hgbotNote Added: 0147056
2023-02-27 19:19hgbotNote Added: 0147065
2023-02-27 19:20hgbotResolutionopen => fixed
2023-02-27 19:20hgbotStatusnew => closed
2023-02-27 19:20hgbotNote Added: 0147066
2023-02-27 19:23hgbotNote Added: 0147067
2023-02-27 19:23hgbotNote Added: 0147068

Notes
(0146998)
hgbot   
2023-02-24 17:04   
Merge Request created: https://gitlab.com/openbravo/product/mods/org.openbravo.distributionorder/-/merge_requests/39 [^]
(0147056)
hgbot   
2023-02-27 16:02   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/-/merge_requests/51 [^]
(0147065)
hgbot   
2023-02-27 19:19   
Merge request merged: https://gitlab.com/openbravo/product/mods/org.openbravo.distributionorder/-/merge_requests/39 [^]
(0147066)
hgbot   
2023-02-27 19:20   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/mods/org.openbravo.distributionorder [^]
Changeset: 17daeccf79cf366e75f63bdced237cd856467ec3
Author: Javier López <javier.lopez@precognis.com>
Date: 27-02-2023 18:19:04
URL: https://gitlab.com/openbravo/product/mods/org.openbravo.distributionorder/-/commit/17daeccf79cf366e75f63bdced237cd856467ec3 [^]

Fixes ISSUE-51699: Move functions to module DO for AWO for fix JUnit test cases of the Distribution Orders module

---
M src-test/org/openbravo/distributionorder/test/OBDO_FB_WeldBaseTest.java
M src-test/org/openbravo/distributionorder/test/utils/DistributionOrderTestUtils.java
---
(0147067)
hgbot   
2023-02-27 19:23   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/-/merge_requests/51 [^]
(0147068)
hgbot   
2023-02-27 19:23   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders [^]
Changeset: e90b93fc8744228d65e16629afa0a456376e0a4d
Author: Javier López <javier.lopez@precognis.com>
Date: 27-02-2023 15:58:37
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/-/commit/e90b93fc8744228d65e16629afa0a456376e0a4d [^]

Fixes ISSUE-51699: Move functions relative to 'OBDOA_DeleteNonConfTaskAndResWhenCloseDO' preference from DO module

---
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/OBDOAWOCloseDistributionOrder.java
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/OBDOAWODeviationToCrossDocking.java
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/OBDOWithAWOTests.java
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/utils/DistributionOrdersWithAWOTestUtils.java
---