0051659: Wrong discounts in deleted Lines - Openbravo Issue Tracking System

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0051659

Retail Modules

Web POS

public

2023-02-21 15:00

2023-03-17 07:55

Reporter

gorkaion

Assigned To

ranjith_qualiantech_com

Priority

high

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

RR23Q2

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0051659: Wrong discounts in deleted Lines

Description

When the removed tickets are set to be stored the discount information on deleted lines is not correct. Currently there are 3 different scenarios depending on how the line is deleted and its source:

Case 1 OK. Create a ticket with a line that has discounts applied. Click on delete ticket. On backend the Discounts and Promotions tab has the discount with the correct information.

Case 2 KO. Create a ticket with 2 lines with discounts applied. Click on Delete Line on one of them and complete the ticket. On backend the deleted line does not have the Discounts and Promotions.

Case 3 KO. Create a Verified return of a ticket with 2 lines that have Discounts applied. Delete one of the lines and complete the ticket. On backend the deleted line has the Discounts and Promotion but the Base Gross Unit Price is ZERO instead of the original price when the discount was applied.

Steps To Reproduce

Prerequisite: Web POS Save Removed Ticket preference must be enabled.

Case 1.
- In POS:
1. Add a line and apply any discount
2. Click on delete ticket
- In Backend
1. Find the removed ticket and check the Discounts and Promotion tab has the discount with expected Base Gross Unit Price and discount amounts.

Case 2.
In POS:
1. Add 3 lines and apply any discount in both of them.
2. Delete one of the lines.
3. Complete the ticket.
In Backend:
1. Find the paid ticket
2. Check that deleted line has the Discount and Promotion tab empty

Case 3a:
In POS:
1. Open verified return and find ticket from case 2.
2. Return all lines
3. Delete one of the lines.
4. Click on Delete ticket
In Backend:
1. Find the deleted return ticket.
2. Check Discounts and Promotinos of line that WAS NOT deleted. Base Gross Unit Price and discount amounts are correct.
3. Check Discoutns and Promotions of line that WAS deleted. Base Gross Unit Price is ZERO which is wrong.

Case 3b (same as before but completing the return after deleting 1 line):
In POS:
1. Open verified return and find ticket from case 2.
2. Return all lines
3. Delete one of the lines.
4. Complete the ticket
In Backend:
1. Find the return ticket.
2. Check Discounts and Promotions of line that WAS NOT deleted. Base Gross Unit Price and discount amounts are correct.
3. Check Discoutns and Promotions of line that WAS deleted. Base Gross Unit Price is ZERO which is wrong.

Proposed Solution

Any form of deleting a ticket and/or any line must preserve the Discounts and Promotions tab information as it was in the moment of the deletion. As it is done when the ticket is deleted.

Base Gross Unit Price has to be the price in that moment. Including any manual price change.

Verified return line promotions are not removed per below ticket. But even if the promotion is not reset the original price is lost:
https://issues.openbravo.com/view.php?id=30755 [^]

calculate receipt reapplies the promotions when a line is deleted. but it is not considering 0 qty lines (deleted ones) because of below changesets:
https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/ab2ece3b1073ddc3e436b2dab10bc05733105520 [^]
https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/6cc38ae18ad8a1b7d4497a97aed2b96a0e730158 [^]

Additional Information

Tags

No tags attached.

Relationships

related to	defect	0030755	closed	fmolina	using verified return, discount is removed
related to	defect	0035974	closed	jorge-garcia	It's possible to apply a manual promotion to a negative or a return line
depends on	defect	0039495	closed	jorge-garcia	It is not possible to apply a manual promotion/discount to a negative line