Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051637POS2POSpublic2023-02-13 14:492023-02-24 14:01
Reportermeriem_azaf 
Assigned Tomeriem_azaf 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version23Q1.1Fixed in Version23Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051637: Create several key map category with the same label in the same restaurant
DescriptionPROD PROBLEM - It is possible to create several key map category with the same label in the same restaurant.

Caused by that, an error is logged in EWI.

org.postgresql.util.PSQLException: ERROR: duplicate key value violates unique constraint "obpos2_keymap_cat_uniq"
  Detail: Key (obpos2_keymap_version_id, name, ad_org_id)=(BCEA33C8F885468EA59A71DF67932601, TEST JIRA 3607, 8D0958A3134F47E08A4634B5F38E979F) already exists.
Steps To Reproduce1- Login in POS2.
2- Go to keymapEditor.
3- Choose one of them.
4- Click on view categories.
5- Create a first category.
6- Create a second one with the same label and save.

→ KO, after the second save an error appears in EWI as described below.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0051583 closed meriem_azaf Create several key map category with the same label in the same restaurant 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-02-16 17:43guilleaerTypedefect => backport
2023-02-16 17:43guilleaerTarget Version => 23Q1
2023-02-22 11:41marvintmTarget Version23Q1 => 23Q1.1
2023-02-24 08:51hgbotNote Added: 0146956
2023-02-24 14:01hgbotNote Added: 0146985
2023-02-24 14:01hgbotResolutionopen => fixed
2023-02-24 14:01hgbotStatusscheduled => closed
2023-02-24 14:01hgbotFixed in Version => 23Q1
2023-02-24 14:01hgbotNote Added: 0146986

Notes
(0146956)
hgbot   
2023-02-24 08:51   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1546 [^]
(0146985)
hgbot   
2023-02-24 14:01   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1546 [^]
(0146986)
hgbot   
2023-02-24 14:01   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: d1f188bffbee9b950e2adc631b3b8a222af54b4a
Author: Meriem Azaf <meriem.azaf@openbravo.com>
Date: 24-02-2023 13:51:01
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/d1f188bffbee9b950e2adc631b3b8a222af54b4a [^]

Fixes ISSUE-51637: Create several key map category with the same label in the same restaurant

PROD PROBLEM - It is possible to create several key map category with the same label in the same restaurant.

The problem was a violation of a unique constraint.

To prevent this, we added a part of the code that check if a category already exist with same label.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/KeymapEditorNewCategoryDialog/KeymapEditorCategoryDialog.jsx
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/KeymapEditorNewCategoryDialog/__test__/KeymapEditorCategoryDialog.test.jsx
---