Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051591ModulesNot Posted Transactionspublic2023-02-14 12:272023-03-08 12:33
Reportershuehner 
Assigned Tofrancisco_ofarril 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customer
Regression introduced in release
Summary0051591: NotPostedDocumentsDataSource.getFilteredDocumentTypes(String, int, int) is not using bind-parameters
DescriptionThis function is not using bind-parameters.

Looking at code looks like it can be (quite) easily converted.

Only non-trivial bit is the loop over various 'contains' entries if present.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks design defect 0038136 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-02-14 12:27shuehnerNew Issue
2023-02-14 12:27shuehnerAssigned To => shuehner
2023-02-14 12:27shuehnerRelationship addedblocks 0038136
2023-02-14 12:45shuehnerSticky IssueNo => Yes
2023-02-14 12:45shuehnerSticky IssueYes => No
2023-02-14 12:46shuehnerIssue cloned0051592
2023-02-22 09:53shuehnerAssigned Toshuehner => Triage Omni OMS
2023-02-24 15:09aferrazAssigned ToTriage Omni OMS => francisco_ofarril
2023-03-01 14:30francisco_ofarrilStatusnew => scheduled
2023-03-01 17:58hgbotNote Added: 0147202
2023-03-08 12:33hgbotResolutionopen => fixed
2023-03-08 12:33hgbotStatusscheduled => closed
2023-03-08 12:33hgbotNote Added: 0147375
2023-03-08 12:33hgbotNote Added: 0147376

Notes
(0147202)
hgbot   
2023-03-01 17:58   
Merge Request created: https://gitlab.com/openbravo/product/mods/org.openbravo.financialmgmt.accounting.report.notposted/-/merge_requests/1 [^]
(0147375)
hgbot   
2023-03-08 12:33   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/mods/org.openbravo.financialmgmt.accounting.report.notposted [^]
Changeset: 569bb9116567493e79f215cbb716d639a762afc1
Author: Francisco Javier Deler O'Farril <francisco.ofarril@openbravo.com>
Date: 08-03-2023 11:33:23
URL: https://gitlab.com/openbravo/product/mods/org.openbravo.financialmgmt.accounting.report.notposted/-/commit/569bb9116567493e79f215cbb716d639a762afc1 [^]

Fixes ISSUE-51591: NotPostedDocumentsDataSource.getFilteredDocumentTypes() is not using bind-parameters

---
M src/org/openbravo/financialmgmt/accounting/report/notposted/NotPostedDocumentsDataSource.java
---
(0147376)
hgbot   
2023-03-08 12:33   
Merge request merged: https://gitlab.com/openbravo/product/mods/org.openbravo.financialmgmt.accounting.report.notposted/-/merge_requests/1 [^]