Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051583POS2POSpublic2023-02-13 14:492023-02-24 00:17
Reportermeriem_azaf 
Assigned Tomeriem_azaf 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q2 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051583: Create several key map category with the same label in the same restaurant
DescriptionPROD PROBLEM - It is possible to create several key map category with the same label in the same restaurant.

Caused by that, an error is logged in EWI.

org.postgresql.util.PSQLException: ERROR: duplicate key value violates unique constraint "obpos2_keymap_cat_uniq"
  Detail: Key (obpos2_keymap_version_id, name, ad_org_id)=(BCEA33C8F885468EA59A71DF67932601, TEST JIRA 3607, 8D0958A3134F47E08A4634B5F38E979F) already exists.
Steps To Reproduce1- Login in POS2.
2- Go to keymapEditor.
3- Choose one of them.
4- Click on view categories.
5- Create a first category.
6- Create a second one with the same label and save.

→ KO, after the second save an error appears in EWI as described below.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 005163723Q1.1 closed meriem_azaf Create several key map category with the same label in the same restaurant 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-02-13 14:49meriem_azafNew Issue
2023-02-13 14:49meriem_azafAssigned To => Retail
2023-02-13 14:49meriem_azafOBNetwork customer => No
2023-02-13 14:49meriem_azafTriggers an Emergency Pack => No
2023-02-13 14:50meriem_azafAssigned ToRetail => meriem_azaf
2023-02-13 14:50meriem_azafStatusnew => scheduled
2023-02-13 14:55hgbotMerge Request Status => open
2023-02-13 14:55hgbotNote Added: 0146466
2023-02-16 17:43guilleaerStatusscheduled => acknowledged
2023-02-16 17:43guilleaerStatusacknowledged => scheduled
2023-02-24 00:17hgbotMerge Request Statusopen => approved
2023-02-24 00:17hgbotResolutionopen => fixed
2023-02-24 00:17hgbotStatusscheduled => closed
2023-02-24 00:17hgbotFixed in Version => 23Q2
2023-02-24 00:17hgbotNote Added: 0146947
2023-02-24 00:17hgbotNote Added: 0146948

Notes
(0146466)
hgbot   
2023-02-13 14:55   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1521 [^]
(0146947)
hgbot   
2023-02-24 00:17   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1521 [^]
(0146948)
hgbot   
2023-02-24 00:17   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: bcf7eea6c3b5d5c5b01b4082e12042b431f69acb
Author: Meriem Azaf <meriem.azaf@openbravo.com>
Date: 24-02-2023 00:16:20
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/bcf7eea6c3b5d5c5b01b4082e12042b431f69acb [^]

Fixes ISSUE-51583: Create several key map category with the same label in the same restaurant

PROD PROBLEM - It is possible to create several key map category with the same label in the same restaurant.

The problem was a violation of a unique constraint.

To prevent this, we added a part of the code that check if a category already exist with same label.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/KeymapEditorNewCategoryDialog/KeymapEditorCategoryDialog.jsx
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/KeymapEditorNewCategoryDialog/__test__/KeymapEditorCategoryDialog.test.jsx
---