Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051578POS2POSpublic2023-02-13 08:012023-05-30 12:53
Reporterjorge-garcia 
Assigned To 
PrioritynormalSeveritymajorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051578: Upgrade Avalara connector to be used also in ReactPOS
DescriptionAvalara is an external Tax Engine that could be used in EnyoPOS application to calculate ticket and line taxes in the US.

The requirement now is to upgrade this module to being able tp use Avalara Tax Engine also from ReactPOS.

https://openbravo.atlassian.net/browse/RM-4561 [^]
https://openbravo.atlassian.net/browse/RM-1918 [^]
Steps To Reproduce-
Proposed SolutionThis feature will be done in two phases:
  - The first phase consist in being able to use Avalara connector code in both Enyo and React POS ( the goal of this FR)
  - The second phase consist on create an OB Tax Engine API and being able to, in the future, use the OB Tax Engine or any other external tax engine (like Avalara)
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0051608 closed Retail If terminal's price list is set to price excluding taxes, render in ticket line net prices instead of gross 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-02-13 08:01jorge-garciaNew Issue
2023-02-13 08:01jorge-garciaAssigned To => jorge-garcia
2023-02-13 08:01jorge-garciaOBNetwork customer => No
2023-02-13 08:01jorge-garciaTriggers an Emergency Pack => No
2023-02-13 08:01jorge-garciaStatusnew => scheduled
2023-02-13 08:45hgbotMerge Request Status => open
2023-02-13 08:45hgbotNote Added: 0146423
2023-02-15 12:19jorge-garciaRelationship addeddepends on 0051608
2023-02-15 20:01aferrazDescription Updatedbug_revision_view_page.php?rev_id=25544#r25544
2023-02-22 08:55hgbotNote Added: 0146857
2023-02-24 11:53hgbotNote Added: 0146975
2023-03-30 18:40hgbotNote Added: 0148125
2023-03-31 14:35hgbotNote Added: 0148158
2023-04-01 13:21hgbotNote Added: 0148167
2023-04-01 14:57hgbotMerge Request Statusopen => approved
2023-04-04 10:38hgbotNote Added: 0148241
2023-04-04 10:39hgbotNote Added: 0148242
2023-04-04 14:05hgbotNote Added: 0148251
2023-04-04 14:23hgbotNote Added: 0148252
2023-04-04 14:23hgbotResolutionopen => fixed
2023-04-04 14:23hgbotStatusscheduled => closed
2023-04-04 14:23hgbotNote Added: 0148253
2023-04-04 14:23hgbotNote Added: 0148254
2023-04-04 14:23hgbotNote Added: 0148255
2023-04-04 14:24hgbotNote Added: 0148256
2023-04-04 14:24hgbotNote Added: 0148257
2023-04-04 14:31hgbotNote Added: 0148258
2023-04-04 14:31hgbotNote Added: 0148259
2023-04-04 14:33hgbotNote Added: 0148260
2023-04-04 14:33hgbotNote Added: 0148261
2023-04-04 14:34hgbotNote Added: 0148262
2023-04-04 14:34hgbotNote Added: 0148263
2023-04-04 14:34hgbotNote Added: 0148264
2023-04-04 14:34hgbotNote Added: 0148265
2023-05-02 12:15aferrazAssigned Tojorge-garcia =>
2023-05-02 12:15aferrazDescription Updatedbug_revision_view_page.php?rev_id=25989#r25989
2023-05-30 12:53hgbotNote Added: 0150466

Notes
(0146423)
hgbot   
2023-02-13 08:45   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.avalaraconnector/-/merge_requests/5 [^]
(0146857)
hgbot   
2023-02-22 08:55   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.taxes/-/merge_requests/1 [^]
(0146975)
hgbot   
2023-02-24 11:53   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1078 [^]
(0148125)
hgbot   
2023-03-30 18:40   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.samplebpintegration/-/merge_requests/9 [^]
(0148158)
hgbot   
2023-03-31 14:35   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/848 [^]
(0148167)
hgbot   
2023-04-01 13:21   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1661 [^]
(0148241)
hgbot   
2023-04-04 10:38   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata [^]
Changeset: 7850f1f068d4c1806926d4d5067a0d6b7c32a0e3
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 04-04-2023 10:38:38
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/commit/7850f1f068d4c1806926d4d5067a0d6b7c32a0e3 [^]

Related to FR-51578: Remove avalaraconnector from retail jsons

---
M referencedata/sampledata/Retail_Test/AD_ORG.xml
M referencedata/sampledata/Retail_Test/AD_WINDOW_ACCESS.xml
M referencedata/sampledata/Retail_Test/OBUIAPP_PROCESS_ACCESS.xml
---
(0148242)
hgbot   
2023-04-04 10:39   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata [^]
Changeset: 7845d8940b67b28823fe38d3a3ec4721c99db621
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 04-04-2023 10:39:03
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/commit/7845d8940b67b28823fe38d3a3ec4721c99db621 [^]

Related to FR-51578: Remove avalaraconnector from retail jsons

---
M referencedata/sampledata/The_White_Valley_Group/AD_ORG.xml
M referencedata/sampledata/The_White_Valley_Group/AD_WINDOW_ACCESS.xml
M referencedata/sampledata/The_White_Valley_Group/OBUIAPP_PROCESS_ACCESS.xml
---
(0148251)
hgbot   
2023-04-04 14:05   
Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/284 [^]
(0148252)
hgbot   
2023-04-04 14:23   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.taxes/-/merge_requests/1 [^]
(0148253)
hgbot   
2023-04-04 14:23   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.taxes [^]
Changeset: 1b0ec0bbdae91037bbca402bd75760af016b04c0
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 04-04-2023 14:12:08
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.taxes/-/commit/1b0ec0bbdae91037bbca402bd75760af016b04c0 [^]

Fixes FR-51578: Create event for taxes module as an external tax engine API

Merge branch 'fr/51578'
MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.taxes/-/merge_requests/1 [^]

---
---
(0148254)
hgbot   
2023-04-04 14:23   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.avalaraconnector [^]
Changeset: 9861a3056c04ccf86f856b9a4ab6294044a33cbc
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 04-04-2023 14:13:50
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.avalaraconnector/-/commit/9861a3056c04ccf86f856b9a4ab6294044a33cbc [^]

Fixes FR-51578: Upgrade Avalara connector to be used in ReactPOS through external tax engine API

Merge branch 'fr/51578'
MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.avalaraconnector/-/merge_requests/5 [^]

---
---
(0148255)
hgbot   
2023-04-04 14:23   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.avalaraconnector/-/merge_requests/5 [^]
(0148256)
hgbot   
2023-04-04 14:24   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 4d3e0e0541d5781ebe85a49df04838b0a0015931
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 04-04-2023 14:21:04
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/4d3e0e0541d5781ebe85a49df04838b0a0015931 [^]

Related to FR-51578: Upgrade Avalara connector to be used in ReactPOS through external tax engine API

- Include fillBobFromJson for c_ordertax, c_orderlinetax, c_invoicetax and c_invoicelinetax tables during OrderLoader process to automatically fill external tax name and external tax rate values.
- Use tax object id property in case it is defined, instead of tax object key, to allow having same dummy tax more than once for same order or order line.
- Allow to extend OrderLineTax model from external tax engine module in PaidReceipts process.
- Add country iSOCountryCode to location Terminal property to allow sending it through external tax engine API.

Merge branch 'fr/51578'
MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1078 [^]

---
A src/org/openbravo/retail/posterminal/PaidReceiptLineTaxesProperties.java
A src/org/openbravo/retail/posterminal/term/LocationProperties.java
M src/org/openbravo/retail/posterminal/OrderLoader.java
M src/org/openbravo/retail/posterminal/PaidReceipts.java
M src/org/openbravo/retail/posterminal/term/Location.java
M src/org/openbravo/retail/posterminal/utility/InvoiceUtils.java
M web/org.openbravo.retail.posterminal/app/model/business-logic/taxes-engine/interface/tax-posinterface.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/LoadTicketUtils.js
M web/org.openbravo.retail.posterminal/js/components/order.js
---
(0148257)
hgbot   
2023-04-04 14:24   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1078 [^]
(0148258)
hgbot   
2023-04-04 14:31   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/848 [^]
(0148259)
hgbot   
2023-04-04 14:31   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: cf57d15d982652ac818b6909c8925b41703525b9
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 04-04-2023 12:31:47
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/cf57d15d982652ac818b6909c8925b41703525b9 [^]

Related to FR-51578: Remove C_ORDERTAX_ORDER_TAX_UN and C_ORDERLINETAX_DERLINE_TAX_UN unique contraints

Remove C_ORDERTAX_ORDER_TAX_UN and C_ORDERLINETAX_DERLINE_TAX_UN unique contraints to allow having same dummy tax more than once for same order or order line.

---
M src-db/database/model/tables/C_ORDERLINETAX.xml
M src-db/database/model/tables/C_ORDERTAX.xml
---
(0148260)
hgbot   
2023-04-04 14:33   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: ac816f4d2555190b13469d1c41eeec7358a552bb
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 04-04-2023 12:33:12
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/ac816f4d2555190b13469d1c41eeec7358a552bb [^]

Related to FR-51578: Use tax id property instead of taxes key to allow having same tax more than once for same line

---
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketSummary/TicketSummaryView.jsx
---
(0148261)
hgbot   
2023-04-04 14:33   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1661 [^]
(0148262)
hgbot   
2023-04-04 14:34   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.samplebpintegration [^]
Changeset: eb0e836944528b424f8b412be4039d63a7967aec
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 04-04-2023 12:34:06
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.samplebpintegration/-/commit/eb0e836944528b424f8b412be4039d63a7967aec [^]

Related to FR-51578: Send spain country iso code ES instead of SP

---
M src/org/openbravo/retail/samplebpintegration/ws/request_updateBP_ID.json
M src/org/openbravo/retail/samplebpintegration/ws/request_updateBP_Object.json
M src/org/openbravo/retail/samplebpintegration/ws/response_oneBP_Object.json
M src/org/openbravo/retail/samplebpintegration/ws/response_twoBPs_Objects.json
M src/org/openbravo/retail/samplebpintegration/ws/response_updateBP.json
---
(0148263)
hgbot   
2023-04-04 14:34   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.samplebpintegration/-/merge_requests/9 [^]
(0148264)
hgbot   
2023-04-04 14:34   
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: 9dd03aea50fc7a8a5a888825f255012d54112ef6
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 04-04-2023 13:29:24
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/9dd03aea50fc7a8a5a888825f255012d54112ef6 [^]

Related to FR-51578: Use tax id instead of key to do the verification in CheckMultitaxCategory test

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/multitaxcategory/CheckMultitaxCategory.java
---
(0148265)
hgbot   
2023-04-04 14:34   
Merge request merged: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/284 [^]
(0150466)
hgbot   
2023-05-30 12:53   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.taxes [^]
Changeset: 4fc42fa8a918fab34547ec343c9e95b159ff5c1c
Author: Frank González <frank.gonzalez@openbravo.com>
Date: 30-05-2023 10:53:47
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.taxes/-/commit/4fc42fa8a918fab34547ec343c9e95b159ff5c1c [^]

Related to FR-51578: Fixes org.openbravo.events.taxes dbconsistency issue

---
M web/org.openbravo.events.taxes/app/.eslintrc.json
---