Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051539POS2POSpublic2023-02-03 11:362023-02-24 10:57
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q2 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051539: MainPOSApp should be refactored to facilitate its port to portrait mode
DescriptionThe way MainPOSApp is currently built, it is quite difficult to port to portrait mode. It should be refactored and the main pos app content extracted to its own component, in order to be reused in portrait mode, where we want to render only that component.

That way we will be able to reuse the content of the main pos app in two differents layouts: the landscape and the portrait one. Once we do that we can create different versions if needed for each of the flows that are included in the main pos app content,
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-02-03 11:36AugustoMauchNew Issue
2023-02-03 11:36AugustoMauchAssigned To => Retail
2023-02-03 11:36AugustoMauchOBNetwork customer => No
2023-02-03 11:36AugustoMauchTriggers an Emergency Pack => No
2023-02-03 11:36AugustoMauchAssigned ToRetail => AugustoMauch
2023-02-03 11:36AugustoMauchStatusnew => scheduled
2023-02-03 11:38hgbotMerge Request Status => open
2023-02-03 11:38hgbotNote Added: 0146262
2023-02-03 12:06hgbotNote Added: 0146265
2023-02-03 12:07hgbotNote Added: 0146266
2023-02-24 09:28AugustoMauchDescription Updatedbug_revision_view_page.php?rev_id=25584#r25584
2023-02-24 10:41hgbotMerge Request Statusopen => approved
2023-02-24 10:55hgbotNote Added: 0146967
2023-02-24 10:55hgbotNote Added: 0146968
2023-02-24 10:57hgbotResolutionopen => fixed
2023-02-24 10:57hgbotStatusscheduled => closed
2023-02-24 10:57hgbotFixed in Version => 23Q2
2023-02-24 10:57hgbotNote Added: 0146969
2023-02-24 10:57hgbotNote Added: 0146970
2023-02-24 10:57hgbotNote Added: 0146971

Notes
(0146262)
hgbot   
2023-02-03 11:38   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/975 [^]
(0146265)
hgbot   
2023-02-03 12:06   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/203 [^]
(0146266)
hgbot   
2023-02-03 12:07   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1511 [^]
(0146967)
hgbot   
2023-02-24 10:55   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 530b5ca81bcf9b442528af41b7c2d3738849d58e
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 24-02-2023 10:55:01
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/530b5ca81bcf9b442528af41b7c2d3738849d58e [^]

Related to ISSUE-51539: core2 changes related to POS main content refactor

---
M web-jspack/org.openbravo.core2/src/components/BaseDialog/BaseDialog.scss
M web-jspack/org.openbravo.core2/src/components/BaseFormInput/BaseFormInput.scss
M web-jspack/org.openbravo.core2/src/components/BaseNavigationButton/BaseNavigationButton.jsx
M web-jspack/org.openbravo.core2/src/components/ChipList/ChipList.scss
M web-jspack/org.openbravo.core2/src/components/ConfigurableLayout/ConfigurableLayout.scss
M web-jspack/org.openbravo.core2/src/components/PickAndExecutePopup/PickAndExecuteOptionTreeList/PickAndExecuteOptionTreeList.scss
---
(0146968)
hgbot   
2023-02-24 10:55   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/975 [^]
(0146969)
hgbot   
2023-02-24 10:57   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 2e0b0236a7321f97d2fb1a77ce9d55485e5d3ea9
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 24-02-2023 10:56:39
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/2e0b0236a7321f97d2fb1a77ce9d55485e5d3ea9 [^]

Fixes ISSUE-51539: Refactors pos2 main content to make it reusable in portrait mode

---
A web-jspack/org.openbravo.pos2/src/components/MainPOSApp/MainPOSAppContent/MainPOSAppContent.config.json
A web-jspack/org.openbravo.pos2/src/components/MainPOSApp/MainPOSAppContent/MainPOSAppContent.jsx
A web-jspack/org.openbravo.pos2/src/components/MainPOSApp/MainPOSAppContent/MainPOSAppContent.scss
A web-jspack/org.openbravo.pos2/src/components/MainPOSApp/MainPOSAppContent/index.js
A web-jspack/org.openbravo.pos2/src/components/ProductBrowse/ProductBrowse.portrait.config.json
A web-jspack/org.openbravo.pos2/src/components/ProductScan/ProductScan.portrait.config.json
A web-jspack/org.openbravo.pos2/src/components/ProductSearch/ProductSearchContent/ProductSearchContent.portrait.config.json
A web-jspack/org.openbravo.pos2/src/components/Ticket/TicketArea/TicketLinesWindow/TicketLinesWindow.config.json
A web-jspack/org.openbravo.pos2/src/components/Ticket/TicketArea/TicketLinesWindow/TicketLinesWindow.jsx
A web-jspack/org.openbravo.pos2/src/components/Ticket/TicketArea/TicketLinesWindow/TicketLinesWindow.scss
A web-jspack/org.openbravo.pos2/src/components/Ticket/TicketArea/TicketLinesWindow/index.js
M web-jspack/org.openbravo.pos2/src/components/ApplicationButtonBar/ApplicationButtonBar.config.json
M web-jspack/org.openbravo.pos2/src/components/ButtonBar1/ButtonBar1.scss
M web-jspack/org.openbravo.pos2/src/components/ButtonBar2/ButtonBar2.scss
M web-jspack/org.openbravo.pos2/src/components/MainPOSApp/MainPOSApp.config.json
M web-jspack/org.openbravo.pos2/src/components/MainPOSApp/MainPOSApp.scss
M web-jspack/org.openbravo.pos2/src/components/MainPOSApp/config/MainPOSApp.portrait.config.json
M web-jspack/org.openbravo.pos2/src/components/ProductBrowse/ProductBrowse.config.json
M web-jspack/org.openbravo.pos2/src/components/ProductConfigurationPanel/ProductConfigurationButton.jsx
M web-jspack/org.openbravo.pos2/src/components/ProductConfigurationPanel/ProductConfigurationPanel.scss
M web-jspack/org.openbravo.pos2/src/components/ProductScan/ProductScan.config.json
M web-jspack/org.openbravo.pos2/src/components/ProductScan/ProductScan.scss
M web-jspack/org.openbravo.pos2/src/components/ProductSearch/AvailableProductFilterButtonContent/AvailableProductFilterButtonContent.scss
M web-jspack/org.openbravo.pos2/src/components/ProductSearch/FilteredProductsKeymap/FilteredProductsKeymap.scss
M web-jspack/org.openbravo.pos2/src/components/ProductSearch/ProductSearchContent/ProductSearchContent.config.json
M web-jspack/org.openbravo.pos2/src/components/ProductSearch/ProductSearchContent/ProductSearchContent.scss
M web-jspack/org.openbravo.pos2/src/components/ProductSearch/ProductSearchContent/ProductSearchContentTitle/ProductSearchContentTitle.scss
M web-jspack/org.openbravo.pos2/src/components/ProductSearch/ProductSorting/ProductSorting.scss
M web-jspack/org.openbravo.pos2/src/components/Service/ServiceConfigurationStep/ServiceConfigurationProductSearchContentNew.config.json
M web-jspack/org.openbravo.pos2/src/components/ShoppingCart/ShoppingCartButton.jsx
M web-jspack/org.openbravo.pos2/src/components/ShoppingCart/ShoppingCartButton.scss
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketArea/TicketArea.scss
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLines.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLines.scss
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLinesLite.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/__test__/TicketLinesLite.test.jsx
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/SetAddProductMode.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/SwitchToDiscounts.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/SwitchToPayments.js
M web-jspack/org.openbravo.pos2/src/ob-init.js
---
(0146970)
hgbot   
2023-02-24 10:57   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1511 [^]
(0146971)
hgbot   
2023-02-24 10:57   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/203 [^]