Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051527Retail ModulesWeb POSpublic2023-02-01 13:312023-02-20 11:13
Reporterjorgewederago 
Assigned Tojustin_patterson 
PrioritynormalSeveritymajorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051527: It should be possible to define if a product should apply discounts or not
DescriptionIt is needed to create a new configuration at product level that defines if a product should apply any discount in the ticket.
Steps To ReproduceN/A
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-02-01 13:31jorgewederagoNew Issue
2023-02-01 13:31jorgewederagoAssigned To => Retail
2023-02-01 13:31jorgewederagoOBNetwork customer => No
2023-02-01 13:31jorgewederagoTriggers an Emergency Pack => No
2023-02-01 13:31jorgewederagoAssigned ToRetail => justin_patterson
2023-02-01 13:31jorgewederagoStatusnew => scheduled
2023-02-01 16:39hgbotMerge Request Status => open
2023-02-01 16:39hgbotNote Added: 0146137
2023-02-03 14:32hgbotNote Added: 0146267
2023-02-03 14:33hgbotNote Added: 0146268
2023-02-03 14:33hgbotNote Added: 0146269
2023-02-10 13:06hgbotNote Added: 0146380
2023-02-10 13:16hgbotNote Added: 0146381
2023-02-13 13:14hgbotNote Added: 0146453
2023-02-13 13:17hgbotNote Added: 0146454
2023-02-20 11:12hgbotNote Added: 0146753
2023-02-20 11:12hgbotResolutionopen => fixed
2023-02-20 11:12hgbotStatusscheduled => resolved
2023-02-20 11:12hgbotFixed in Version => RR23Q2
2023-02-20 11:12hgbotNote Added: 0146754
2023-02-20 11:12hgbotMerge Request Statusopen => merged
2023-02-20 11:12hgbotNote Added: 0146755
2023-02-20 11:12hgbotNote Added: 0146756
2023-02-20 11:12hgbotNote Added: 0146757
2023-02-20 11:12hgbotNote Added: 0146758
2023-02-20 11:12hgbotMerge Request Statusmerged => approved
2023-02-20 11:13hgbotStatusresolved => closed
2023-02-20 11:13hgbotNote Added: 0146759
2023-02-20 11:13hgbotNote Added: 0146760
2023-02-20 11:13hgbotNote Added: 0146761
2023-02-20 11:13hgbotNote Added: 0146762
2023-02-20 11:13hgbotNote Added: 0146763
2023-02-20 11:13hgbotFixed in VersionRR23Q2 => 23Q2
2023-02-20 11:13hgbotNote Added: 0146764
2023-02-20 11:13hgbotNote Added: 0146765
2023-02-20 11:13hgbotNote Added: 0146766
2023-02-20 11:13hgbotNote Added: 0146767

Notes
(0146137)
hgbot   
2023-02-01 16:39   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1053 [^]
(0146267)
hgbot   
2023-02-03 14:32   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/merge_requests/43 [^]
(0146268)
hgbot   
2023-02-03 14:33   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/59 [^]
(0146269)
hgbot   
2023-02-03 14:33   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/merge_requests/38 [^]
(0146380)
hgbot   
2023-02-10 13:06   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/87 [^]
(0146381)
hgbot   
2023-02-10 13:16   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1518 [^]
(0146453)
hgbot   
2023-02-13 13:14   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1053 [^]
(0146454)
hgbot   
2023-02-13 13:17   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1066 [^]
(0146753)
hgbot   
2023-02-20 11:12   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 968bd779ac7afb5e0b017f6cafe563e60803e2b6
Author: Justin Patterson <justin.patterson@openbravo.com>
Date: 20-02-2023 08:38:35
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/968bd779ac7afb5e0b017f6cafe563e60803e2b6 [^]

Fixes ISSUE-FR-51527: define flag to ignore discounts

-Added new column to table M_PRODUCT: em_obpos_skipapplypromotions
-Added entry in AD_ELEMENT associated with new column
-Added new field to POS Properties field group on Product window to
toggle property
-Exposed property to front end in ProductProperty.java /POS2) and product.js model (POS1)

---
M src-db/database/model/modifiedTables/M_PRODUCT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src/org/openbravo/retail/posterminal/master/ProductProperty.java
M web/org.openbravo.retail.posterminal/js/model/product.js
---
(0146754)
hgbot   
2023-02-20 11:12   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 26615d840033c8b59ff72639affa6f8952dfbfc7
Author: Aaron Calero <aaron.calero@openbravo.com>
Date: 20-02-2023 09:43:56
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/26615d840033c8b59ff72639affa6f8952dfbfc7 [^]

Fixes ISSUE-51527: Merge branch 'fr/51527'

---
M src-db/database/model/modifiedTables/M_PRODUCT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src/org/openbravo/retail/posterminal/master/ProductProperty.java
M web/org.openbravo.retail.posterminal/js/model/product.js
---
(0146755)
hgbot   
2023-02-20 11:12   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1066 [^]
(0146756)
hgbot   
2023-02-20 11:12   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 8e12d654100dd982a6043b46d60d4b73ffb7a0df
Author: Justin Patterson <justin.patterson@openbravo.com>
Date: 20-02-2023 08:35:50
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/8e12d654100dd982a6043b46d60d4b73ffb7a0df [^]

Fixes ISSUE-51527: add hook to skip discounts

-Added new registerIsApplicableToLineHook to check if product should ignore discounts

---
A web-test/model/business-logic/discounts-engine/engine/obpos-skipPromotionsHook.test.js
A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/obpos-skipPromotionsHook.js
M src/org/openbravo/retail/discounts/DiscountsEngineAppComponentProvider.java
---
(0146758)
hgbot   
2023-02-20 11:12   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: ebf1b03f09d6f750b72dee6d428b0ac07fe763fe
Author: Aaron Calero <aaron.calero@openbravo.com>
Date: 20-02-2023 10:53:14
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/ebf1b03f09d6f750b72dee6d428b0ac07fe763fe [^]

Fixed ISSUE-51527: Merge branch 'fr/51527'

---
A web-test/model/business-logic/discounts-engine/engine/obpos-skipPromotionsHook.test.js
A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/obpos-skipPromotionsHook.js
M src/org/openbravo/retail/discounts/DiscountsEngineAppComponentProvider.java
---
(0146757)
hgbot   
2023-02-20 11:12   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/87 [^]
(0146759)
hgbot   
2023-02-20 11:13   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata [^]
Changeset: 90544493c97f927b39585d8967a00c09184bf9c0
Author: Justin Patterson <justin.patterson@openbravo.com>
Date: 20-02-2023 07:39:19
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/commit/90544493c97f927b39585d8967a00c09184bf9c0 [^]

Fixes FR-51527: define flag to ignore discounts

-Applied patch with new column data for M_PRODUCT.xml

---
M referencedata/sampledata/The_White_Valley_Group/M_PRODUCT.xml
---
(0146760)
hgbot   
2023-02-20 11:13   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/59 [^]
(0146761)
hgbot   
2023-02-20 11:13   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata [^]
Changeset: 03dbc3c2cefe5792c3c6b38817818ddf6018d6ce
Author: Justin Patterson <justin.patterson@openbravo.com>
Date: 20-02-2023 07:37:54
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/commit/03dbc3c2cefe5792c3c6b38817818ddf6018d6ce [^]

Fixes FR-51527: define flag to ignore discounts

-Applied patch with new column data for M_PRODUCT.xml

---
M referencedata/sampledata/Retail_Test/M_PRODUCT.xml
---
(0146762)
hgbot   
2023-02-20 11:13   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/merge_requests/38 [^]
(0146763)
hgbot   
2023-02-20 11:13   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata [^]
Changeset: d2029041b44831e5134e44b604e47b3386cc3857
Author: Justin Patterson <justin.patterson@openbravo.com>
Date: 20-02-2023 08:36:52
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/commit/d2029041b44831e5134e44b604e47b3386cc3857 [^]

Fixes FR-51527: define flag to ignore discounts

-Applied patch with new column data for M_PRODUCT.xml

---
M referencedata/sampledata/The_White_Valley_Group/M_OFFER.xml
M referencedata/sampledata/The_White_Valley_Group/M_PRODUCT.xml
M referencedata/sampledata/The_White_Valley_Group/OBPOS_APPLICATIONS.xml
M referencedata/sampledata/The_White_Valley_Group/OBPOS_APP_PAYMENT.xml
M referencedata/sampledata/The_White_Valley_Group/OBPOS_APP_PAYMENT_TYPE.xml
M referencedata/sampledata/The_White_Valley_Group/OBPOS_TERMINALTYPE.xml
---
(0146764)
hgbot   
2023-02-20 11:13   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: d09956215e88d423f5fb7f8e120cec8fdb131ae7
Author: Justin Patterson <justin.patterson@openbravo.com>
Date: 20-02-2023 07:40:20
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/d09956215e88d423f5fb7f8e120cec8fdb131ae7 [^]

Fixes ISSUE-51527: define flag to ignore discounts

-Added new function in file skipApplyPromotions.js which changes UI state depending on if a product with skipApplyPromotions flag is checked
-Added new executability rule in SwitchToDiscounts.js

---
A web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/__test__/skipApplyPromotionsRule.test.js
A web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/skipApplyPromotions.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/SwitchToDiscounts.js
---
(0146765)
hgbot   
2023-02-20 11:13   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1518 [^]
(0146766)
hgbot   
2023-02-20 11:13   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/merge_requests/43 [^]
(0146767)
hgbot   
2023-02-20 11:13   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 79ed2e160b5efc3355b39b45af7af9772469c9bc
Author: Jorge Wederago <jorge.wederago@openbravo.com>
Date: 20-02-2023 11:07:11
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/79ed2e160b5efc3355b39b45af7af9772469c9bc [^]

Fixes ISSUE-51527: Merge branch 'fr/51527'

---
A web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/__test__/skipApplyPromotionsRule.test.js
A web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/skipApplyPromotions.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/SwitchToDiscounts.js
---