Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051474POS2POSpublic2023-01-26 16:572023-02-21 18:20
Reporterablasco 
Assigned Toablasco 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q2 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051474: Portrait Responsive Dialog
DescriptionIn portrait Mode, Dialogs should be adapted to the device in width and height.

Steps To Reproduce*
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
causes defect 0051805 closed Triage Platform Base Storyshots.test.js fails under some circumstances 
Attached Filespng Screenshot from 2023-01-19 09-57-20.png (34,276) 2023-01-26 16:57
https://issues.openbravo.com/file_download.php?file_id=18068&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2023-01-26 16:57ablascoNew Issue
2023-01-26 16:57ablascoAssigned To => ablasco
2023-01-26 16:57ablascoFile Added: Screenshot from 2023-01-19 09-57-20.png
2023-01-26 16:57ablascoTriggers an Emergency Pack => No
2023-01-30 09:26hgbotNote Added: 0145999
2023-02-16 09:39hgbotNote Added: 0146615
2023-02-20 18:21hgbotNote Added: 0146797
2023-02-21 13:41hgbotNote Added: 0146813
2023-02-21 18:06hgbotNote Added: 0146834
2023-02-21 18:06hgbotNote Added: 0146835
2023-02-21 18:20hgbotNote Added: 0146839
2023-02-21 18:20hgbotNote Added: 0146840
2023-02-21 18:20hgbotNote Added: 0146841
2023-02-21 18:20hgbotNote Added: 0146842
2023-02-21 18:20hgbotNote Added: 0146843
2023-02-21 18:20hgbotResolutionopen => fixed
2023-02-21 18:20hgbotStatusnew => closed
2023-02-21 18:20hgbotNote Added: 0146844
2023-02-21 18:20hgbotFixed in Version => 23Q2
2023-02-21 18:20hgbotNote Added: 0146845
2023-03-08 11:57caristuRelationship addedcauses 0051805

Notes
(0145999)
hgbot   
2023-01-30 09:26   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/970 [^]
(0146615)
hgbot   
2023-02-16 09:39   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/979 [^]
(0146797)
hgbot   
2023-02-20 18:21   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1536 [^]
(0146813)
hgbot   
2023-02-21 13:41   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/970 [^]
(0146834)
hgbot   
2023-02-21 18:06   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 729e4b1cb0a75f243a3b08c44a9e7f30b6646794
Author: adrian.blasco <adrian.blasco@openbravo.com>
Date: 21-02-2023 18:05:54
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/729e4b1cb0a75f243a3b08c44a9e7f30b6646794 [^]

Related to ISSUE-51474 Responsive BaseDialog Test solved for TicketBPButton

Test ConfigurationSet void

---
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPButton/__test__/TicketBPButton.test.jsx
---
(0146835)
hgbot   
2023-02-21 18:06   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1536 [^]
(0146839)
hgbot   
2023-02-21 18:20   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 1ffef4756ad9fcb7a25ab151a6e68fb21819e3c8
Author: adrian.blasco <adrian.blasco@openbravo.com>
Date: 21-02-2023 18:17:58
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/1ffef4756ad9fcb7a25ab151a6e68fb21819e3c8 [^]

Related to ISSUE-51474 Responsive Dialog fullScreen property in BaseDialog for portrait mode

---
M web-jspack/org.openbravo.core2/src/components/PickAndExecutePopup/PickAndExecutePopup.scss
---
(0146840)
hgbot   
2023-02-21 18:20   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 906b4806731491cd71d2aa40b91c027d789ccd77
Author: adrian.blasco <adrian.blasco@openbravo.com>
Date: 21-02-2023 18:18:26
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/906b4806731491cd71d2aa40b91c027d789ccd77 [^]

Related to ISSUE-51474 Responsive Dialog fixed landscape and portrait conflicts

---
M web-jspack/org.openbravo.core2/src/components/BaseDialog/BaseDialog.jsx
---
(0146841)
hgbot   
2023-02-21 18:20   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 3fe59af3d819e6e93aec32fd105eddd586e840a8
Author: adrian.blasco <adrian.blasco@openbravo.com>
Date: 21-02-2023 18:18:27
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/3fe59af3d819e6e93aec32fd105eddd586e840a8 [^]

Related to ISSUE-51474 Confirmation Dialogs not Full Screen in Portrait

---
M web-jspack/org.openbravo.core2/src/components/BaseDialog/BaseDialog.jsx
M web-jspack/org.openbravo.core2/src/components/ConfirmationDialog/ConfirmationDialog.jsx
M web-jspack/org.openbravo.core2/src/components/StandardDialog/StandardDialog.jsx
---
(0146842)
hgbot   
2023-02-21 18:20   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: f23464e0745418ab482ddc63c9afa3de0aab69a6
Author: adrian.blasco <adrian.blasco@openbravo.com>
Date: 21-02-2023 18:18:27
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/f23464e0745418ab482ddc63c9afa3de0aab69a6 [^]

Related to ISSUE-51474 Dialog Max-Height unset

---
M web-jspack/org.openbravo.core2/src/components/PickAndExecutePopup/PickAndExecuteOptionTreeList/PickAndExecuteOptionTreeList.scss
---
(0146843)
hgbot   
2023-02-21 18:20   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: a799aa4c437d3b91e96bc4e4ae876dc38495e8ce
Author: adrian.blasco <adrian.blasco@openbravo.com>
Date: 21-02-2023 18:18:27
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/a799aa4c437d3b91e96bc4e4ae876dc38495e8ce [^]

Related to ISSUE-51474 Responsive BaseDialog review for tests

---
M web-jspack/org.openbravo.core2/src/components/BaseDialog/BaseDialog.jsx
M web-jspack/org.openbravo.core2/src/components/ConfirmationDialog/ConfirmationDialog.jsx
---
(0146844)
hgbot   
2023-02-21 18:20   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/979 [^]
(0146845)
hgbot   
2023-02-21 18:20   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 27a1674e0ec87a8d1c28cc09c003f706a7c68e1e
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 21-02-2023 18:20:11
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/27a1674e0ec87a8d1c28cc09c003f706a7c68e1e [^]

Fixes ISSUE-51474: Improves styling of dialongs in portrait mode

---
A web-jspack/org.openbravo.core2/src/components/PickAndExecutePopup/config/PickAndExecutePopup.portrait.config.json
M web-jspack/org.openbravo.core2/src/components/BaseDialog/BaseDialog.jsx
M web-jspack/org.openbravo.core2/src/components/BaseDialog/BaseDialog.scss
M web-jspack/org.openbravo.core2/src/components/ConfirmationDialog/ConfirmationDialog.jsx
M web-jspack/org.openbravo.core2/src/components/MultiButtonStandardDialog/MultiButtonStandardDialog.scss
M web-jspack/org.openbravo.core2/src/components/PickAndExecutePopup/PickAndExecuteOptionTree/PickAndExecuteOptionTree.scss
M web-jspack/org.openbravo.core2/src/components/PickAndExecutePopup/PickAndExecuteOptionTreeList/PickAndExecuteOptionTreeList.scss
M web-jspack/org.openbravo.core2/src/components/PickAndExecutePopup/PickAndExecutePopup.config.json
M web-jspack/org.openbravo.core2/src/components/PickAndExecutePopup/PickAndExecutePopup.scss
M web-jspack/org.openbravo.core2/src/components/PickAndExecutePopup/PickAndExecutePopupFilterBar/PickAndExecutePopupFilterBar.jsx
M web-jspack/org.openbravo.core2/src/components/PickAndExecutePopup/PickAndExecutePopupFilterBar/PickAndExecutePopupFilterBar.scss
M web-jspack/org.openbravo.core2/src/components/StandardDialog/StandardDialog.jsx
M web-jspack/org.openbravo.core2/src/ob-init.js
---