Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051448Retail ModulesWeb POSpublic2023-01-24 15:522023-01-27 07:40
Reportermarvintm 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR23Q1Fixed in VersionRR23Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2022-08-29
Regression introduced in releaseRR22Q4
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/9b9213cd7d8c8c10553a4a4b2dfffe1256e970f6 [^]
Triggers an Emergency PackNo
Summary0051448: Cashup update happening in orders and cashups is failing if the "paymentMethods" property is not defined, generating EWIs
DescriptionAs part of this project:

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/886 [^]

new data was added to the cashup information, and the corresponding classes that process and save it were changed, and they are now expecting it to be there (and specifically, the "paymentMethods" object inside the cashupReportInformation data).

However, if orders or cashups were generated while being offline, and then the customer is updated, this data will not be in the JSON, and the process will fail, generating records in Errors While Importing.

This is not correct, the code should be smart and first check if the "paymentMethods" property exist, and if it doesn't the corresponding code to save it should not be executed.
Steps To Reproduce- Create orders or cashups while being offline in a release before this development
- Update to the newer version with this development, and then synchronize those orders
- Verify that they generate Errors While importing
Proposed SolutionHandle the case of "paymentMethods" property not being present, by just ignoring this part of the code.
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0051446 closed ranjith_qualiantech_com Cashup update happening in orders and cashups is failing if the "paymentMethods" property is not defined, generating EWIs 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-01-24 15:53marvintmTypedefect => backport
2023-01-24 15:53marvintmTarget Version => RR18Q4.4
2023-01-24 15:54marvintmTarget VersionRR18Q4.4 => RR23Q1
2023-01-25 06:05ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2023-01-27 06:34hgbotNote Added: 0145893
2023-01-27 07:40hgbotResolutionopen => fixed
2023-01-27 07:40hgbotStatusscheduled => closed
2023-01-27 07:40hgbotNote Added: 0145896
2023-01-27 07:40hgbotFixed in Version => RR23Q1
2023-01-27 07:40hgbotNote Added: 0145897

Notes
(0145893)
hgbot   
2023-01-27 06:34   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1048 [^]
(0145896)
hgbot   
2023-01-27 07:40   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1048 [^]
(0145897)
hgbot   
2023-01-27 07:40   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 5e51ef10338b589bf8c66f37b7292c61dbf8a8f4
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 27-01-2023 10:54:28
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/5e51ef10338b589bf8c66f37b7292c61dbf8a8f4 [^]

Fixed ISSUE-51448: PaymentMethodCashup should updated with paymentMethods if exists
* If paymentMethods is exists in cashup json, then it should be used
  to create the PaymentMethodCashup

---
M src/org/openbravo/retail/posterminal/UpdateCashup.java
---