Openbravo Issue Tracking System - Retail Modules
View Issue Details
0051446Retail ModulesWeb POSpublic2023-01-24 15:522023-01-26 12:36
marvintm 
ranjith_qualiantech_com 
normalmajorhave not tried
closedfixed 
5
 
RR23Q2 
Production - Confirmed Stable
2022-08-29
RR22Q4
https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/9b9213cd7d8c8c10553a4a4b2dfffe1256e970f6 [^]
No
0051446: Cashup update happening in orders and cashups is failing if the "paymentMethods" property is not defined, generating EWIs
As part of this project:

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/886 [^]

new data was added to the cashup information, and the corresponding classes that process and save it were changed, and they are now expecting it to be there (and specifically, the "paymentMethods" object inside the cashupReportInformation data).

However, if orders or cashups were generated while being offline, and then the customer is updated, this data will not be in the JSON, and the process will fail, generating records in Errors While Importing.

This is not correct, the code should be smart and first check if the "paymentMethods" property exist, and if it doesn't the corresponding code to save it should not be executed.
- Create orders or cashups while being offline in a release before this development
- Update to the newer version with this development, and then synchronize those orders
- Verify that they generate Errors While importing
Handle the case of "paymentMethods" property not being present, by just ignoring this part of the code.
No tags attached.
depends on backport 0051447RR22Q4.2 closed ranjith_qualiantech_com Cashup update happening in orders and cashups is failing if the "paymentMethods" property is not defined, generating EWIs 
depends on backport 0051448RR23Q1 closed ranjith_qualiantech_com Cashup update happening in orders and cashups is failing if the "paymentMethods" property is not defined, generating EWIs 
Issue History
2023-01-24 15:52marvintmNew Issue
2023-01-24 15:52marvintmAssigned To => Retail
2023-01-24 15:52marvintmRegression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/9b9213cd7d8c8c10553a4a4b2dfffe1256e970f6 [^]
2023-01-24 15:52marvintmTriggers an Emergency Pack => No
2023-01-24 15:53marvintmRegression level => Production - Confirmed Stable
2023-01-24 15:53marvintmRegression date => 2022-08-29
2023-01-24 15:53marvintmRegression introduced in release => RR22Q4
2023-01-24 15:53marvintmStatusnew => scheduled
2023-01-25 06:05ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2023-01-25 10:54hgbotNote Added: 0145826
2023-01-26 12:36hgbotResolutionopen => fixed
2023-01-26 12:36hgbotStatusscheduled => closed
2023-01-26 12:36hgbotNote Added: 0145864
2023-01-26 12:36hgbotFixed in Version => RR23Q2
2023-01-26 12:36hgbotNote Added: 0145865

Notes
(0145826)
hgbot   
2023-01-25 10:54   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1046 [^]
(0145864)
hgbot   
2023-01-26 12:36   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1046 [^]
(0145865)
hgbot   
2023-01-26 12:36   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: d97bf30fbd94638254d043a8f1d12184fe989e91
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 25-01-2023 14:50:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/d97bf30fbd94638254d043a8f1d12184fe989e91 [^]

Fixed ISSUE-51446: PaymentMethodCashup should updated with paymentMethods if exists
* If paymentMethods is exists in cashup json, then it should be used
  to create the PaymentMethodCashup

---
M src/org/openbravo/retail/posterminal/UpdateCashup.java
---