Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051445POS2POSpublic2023-01-23 18:042023-03-20 11:54
ReporterjavierRodriguez 
Assigned TojavierRodriguez 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051445: Create a mechanism to detect that POS is working with a duplicated ticket id
DescriptionAfter severals cases in production where the application is working with a brand new ticket which has a used id. This creates EWIs due to try to synchronise a ticket with duplicates ids.
Steps To ReproduceIn production, this problem appeared after an F5 (refresh) or after a delete ticket action.
Proposed SolutionThis duplicated id should be checked:
- After an F5
- When a new ticket is set in Ticket state model

The application could have different scenarios when a ticket is set in the state. Ticket could be
- Processed tickets
- brand new tickets
- No-processed ticket which are in ticket list with products or payments on it.

It is necessary to take into account this different scenarios and do actions depending on them.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 005153523Q1 closed javierRodriguez Create a mechanism to detect that POS is working with a duplicated ticket id 
depends on backport 005181122Q4.3 closed javierRodriguez Create a mechanism to detect that POS is working with a duplicated ticket id 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-01-23 18:04javierRodriguezNew Issue
2023-01-23 18:04javierRodriguezAssigned To => javierRodriguez
2023-01-23 18:04javierRodriguezTriggers an Emergency Pack => No
2023-01-31 16:54hgbotNote Added: 0146100
2023-01-31 17:52hgbotNote Added: 0146105
2023-02-02 12:36guilleaerStatusnew => scheduled
2023-02-02 12:36guilleaerStatusscheduled => acknowledged
2023-02-02 12:37guilleaerStatusacknowledged => scheduled
2023-02-03 11:04hgbotResolutionopen => fixed
2023-02-03 11:04hgbotStatusscheduled => closed
2023-02-03 11:04hgbotNote Added: 0146250
2023-02-03 11:04hgbotFixed in Version => RR23Q2
2023-02-03 11:04hgbotNote Added: 0146251
2023-02-03 11:04hgbotNote Added: 0146252
2023-02-03 11:04hgbotNote Added: 0146253
2023-02-09 18:51javierRodriguezStatusclosed => new
2023-02-09 18:51javierRodriguezResolutionfixed => open
2023-02-09 18:51javierRodriguezFixed in VersionRR23Q2 =>
2023-02-10 11:31hgbotNote Added: 0146367
2023-02-10 13:29hgbotNote Added: 0146384
2023-02-10 13:29hgbotNote Added: 0146385
2023-02-10 13:34javierRodriguezStatusnew => scheduled
2023-02-10 13:34javierRodriguezStatusscheduled => resolved
2023-02-10 13:34javierRodriguezResolutionopen => fixed
2023-02-10 13:34javierRodriguezStatusresolved => closed
2023-02-16 21:43hgbotNote Added: 0146665
2023-02-16 21:45hgbotNote Added: 0146666
2023-02-20 08:34hgbotNote Added: 0146742
2023-02-20 08:34hgbotNote Added: 0146743
2023-02-20 08:34hgbotNote Added: 0146744
2023-02-20 08:34hgbotNote Added: 0146745
2023-02-20 08:34hgbotNote Added: 0146746
2023-02-20 08:34hgbotNote Added: 0146747
2023-03-08 13:34javierRodriguezStatusclosed => new
2023-03-08 13:34javierRodriguezResolutionfixed => open
2023-03-08 13:34javierRodriguezStatusnew => scheduled
2023-03-08 13:37javierRodriguezStatusscheduled => resolved
2023-03-08 13:37javierRodriguezResolutionopen => fixed
2023-03-20 11:54javierRodriguezStatusresolved => closed

Notes
(0146100)
hgbot   
2023-01-31 16:54   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1052 [^]
(0146105)
hgbot   
2023-01-31 17:52   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1497 [^]
(0146250)
hgbot   
2023-02-03 11:04   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1052 [^]
(0146251)
hgbot   
2023-02-03 11:04   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: d6231e40d9b3f1604c7eea0f8cfff6306b8e185a
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 03-02-2023 09:04:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/d6231e40d9b3f1604c7eea0f8cfff6306b8e185a [^]

Fixed ISSUE-51445: Check before load a local ticket if it is using a duplicated order id

- Extract paid receipt request to use in different places
- Create ticket utility function isOrderIdUsedInBackend to check duplicate order ids
- Create new action preparation in load local ticket action

---
M web-test/model/business-object/ticket-list/actions/LoadLocalTicket.test.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket-list/actions/LoadLocalTicket.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/LoadTicketUtils.js
---
(0146252)
hgbot   
2023-02-03 11:04   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 3bd53e50059dabe84eb44d32618055e95b0a435e
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 03-02-2023 10:04:08
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/3bd53e50059dabe84eb44d32618055e95b0a435e [^]

Related to ISSUE-51445: Check if the current ticket is using a duplicated id

---
M web-jspack/org.openbravo.pos2/src/authentication/loginInitActions.js
---
(0146253)
hgbot   
2023-02-03 11:04   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1497 [^]
(0146367)
hgbot   
2023-02-10 11:31   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1062 [^]
(0146384)
hgbot   
2023-02-10 13:29   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: b1f29c07fe3a0237ebc5580219a5ead6d4414d8b
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 10-02-2023 12:28:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/b1f29c07fe3a0237ebc5580219a5ead6d4414d8b [^]

Related to ISSUE-51445: Ensure the is data in the paid receipt response

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket-list/actions/LoadLocalTicket.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/LoadTicketUtils.js
---
(0146385)
hgbot   
2023-02-10 13:29   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1062 [^]
(0146665)
hgbot   
2023-02-16 21:43   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1069 [^]
(0146666)
hgbot   
2023-02-16 21:45   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1531 [^]
(0146742)
hgbot   
2023-02-20 08:34   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 1da0e54adf901914f36136f1859983dde999246e
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 20-02-2023 07:34:35
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/1da0e54adf901914f36136f1859983dde999246e [^]

Related to ISSUE-51445: Send by payload the information to create a new ticket if it is needed

---
M web-jspack/org.openbravo.pos2/src/authentication/loginInitActions.js
---
(0146743)
hgbot   
2023-02-20 08:34   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 7134f2af747e0742a872fbb458f549222141edbd
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 20-02-2023 07:34:35
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/7134f2af747e0742a872fbb458f549222141edbd [^]

Related to ISSUE-51445: Add prehook to prepare payload in LoadLocalTicket user action

---
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/LoadLocalTicket.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/LoadLocalTicket.js
---
(0146744)
hgbot   
2023-02-20 08:34   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1531 [^]
(0146745)
hgbot   
2023-02-20 08:34   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: dd49e6fac0e8aa84b8f1d938fea7b157d80d2681
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 16-02-2023 18:25:31
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/dd49e6fac0e8aa84b8f1d938fea7b157d80d2681 [^]

Related to ISSUE-51445: Send by payload the information to create a new ticket if it is needed

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket-list/actions/LoadLocalTicket.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
M web/org.openbravo.retail.posterminal/js/utils/ticketListUtils.js
---
(0146746)
hgbot   
2023-02-20 08:34   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 39227d5c0454aa64ef8fc836dac466b56426b99d
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 17-02-2023 13:13:42
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/39227d5c0454aa64ef8fc836dac466b56426b99d [^]

Related to ISSUE-51445: Fix how th ticket list is set depending on createNewTicket flow

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket-list/actions/LoadLocalTicket.js
---
(0146747)
hgbot   
2023-02-20 08:34   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1069 [^]