Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051431Retail ModulesWeb POSpublic2023-01-20 14:422023-03-28 09:59
Reporterkousalya_r 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR23Q2 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051431: Rounding Issue when Payment Provider is Configured
Descriptionwhen payment provider is configured and rounding is added Payment rounding Tab then in POS the rounding performed after the transaction completes
Steps To ReproduceConfiguration:
1. Create Payment Method for Rounding in channel touch point type window as shown in screenshot-2023-01-20 18-31-41.
2. Link the rounding payment method under the Payment Rounding Tab to the cash payment method that we use in POS as shown in screenshot-2023-01-20 18-32-44. The payment method need to be linked to payment provider.
3. Add payment method created in step 1 and step2 in Channel TouchPoint window - Payment Type Tab

Transaction:
3. Add a product which has decimal value and select the payment method which we configured with payment provider and check in the popup the amount is not Rounded. It rounds the amount after the transaction but the expected result to be rounded before transaction.
Proposed SolutionThe logic to be applied should be the following one:
If (rounding configured && payment Provider flow && amount to be paid with rounding applied gets the ticket totally paid) {
  modify amount before doing the call to the Provider
} else {
  do nothing
}
Current logic is in addPaymentRounding in AddPaymentUtils.js

It will be needed to be applied in enyo and react.
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0052065 closed ranjith_qualiantech_com Rounding Issue in SCO when Payment Provider is Configured for Cash payment 
causes defect 0052478 closed ranjith_qualiantech_com WebPos - Functional BUG of the 'Overpayment' control 
Attached Filespng Screenshot from 2023-01-20 18-32-44.png (271,124) 2023-01-20 14:42
https://issues.openbravo.com/file_download.php?file_id=18049&type=bug
png Screenshot from 2023-01-20 18-31-41.png (258,917) 2023-01-20 14:42
https://issues.openbravo.com/file_download.php?file_id=18050&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2023-01-20 14:42kousalya_rNew Issue
2023-01-20 14:42kousalya_rAssigned To => Retail
2023-01-20 14:42kousalya_rFile Added: Screenshot from 2023-01-20 18-32-44.png
2023-01-20 14:42kousalya_rTriggers an Emergency Pack => No
2023-01-20 14:42kousalya_rFile Added: Screenshot from 2023-01-20 18-31-41.png
2023-01-20 14:47kousalya_rSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=25435#r25435
2023-01-25 08:43ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2023-01-25 08:43ranjith_qualiantech_comStatusnew => scheduled
2023-01-27 07:42marvintmNote Added: 0145898
2023-01-27 07:42marvintmTypedefect => design defect
2023-01-27 12:26ranjith_qualiantech_comAssigned Toranjith_qualiantech_com => Retail
2023-01-27 12:26ranjith_qualiantech_comStatusscheduled => acknowledged
2023-03-20 09:15guillermogilAssigned ToRetail => ranjith_qualiantech_com
2023-03-20 09:15guillermogilStatusacknowledged => scheduled
2023-03-20 09:15guillermogilNote Deleted: 0145898
2023-03-20 09:16guillermogilProposed Solution updated
2023-03-27 07:17hgbotNote Added: 0147973
2023-03-27 07:17hgbotNote Added: 0147974
2023-03-28 08:55hgbotNote Added: 0148016
2023-03-28 08:55hgbotResolutionopen => fixed
2023-03-28 08:55hgbotStatusscheduled => closed
2023-03-28 08:55hgbotFixed in Version => RR23Q2
2023-03-28 08:55hgbotNote Added: 0148017
2023-03-28 09:57hgbotNote Added: 0148021
2023-03-28 09:58hgbotNote Added: 0148022
2023-03-28 09:59hgbotNote Added: 0148023
2023-03-28 09:59hgbotNote Added: 0148024
2023-04-05 10:14maiteRelationship addedrelated to 0052065
2023-05-18 09:26ranjith_qualiantech_comRelationship addedcauses 0052478

Notes
(0147973)
hgbot   
2023-03-27 07:17   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1116 [^]
(0147974)
hgbot   
2023-03-27 07:17   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1635 [^]
(0148016)
hgbot   
2023-03-28 08:55   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1116 [^]
(0148017)
hgbot   
2023-03-28 08:55   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: b714a2ffb27e9bb3f3fa0a0b570263365f9c0f0d
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 27-03-2023 13:50:23
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/b714a2ffb27e9bb3f3fa0a0b570263365f9c0f0d [^]

Fixed ISSUE-51431: Rounding payment should be added when paying with payment provider
* When paying receipt with payment provider, rounding amount should be
  excluded from payment amount when processing transaction

---
M web/org.openbravo.retail.posterminal/js/components/modalpayment.js
M web/org.openbravo.retail.posterminal/js/components/modalprovidergroup.js
---
(0148021)
hgbot   
2023-03-28 09:57   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1635 [^]
(0148022)
hgbot   
2023-03-28 09:58   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1644 [^]
(0148023)
hgbot   
2023-03-28 09:59   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 1ea2d31a0507023efa0e6f261761bb04c9bfd1bd
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 28-03-2023 07:58:34
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/1ea2d31a0507023efa0e6f261761bb04c9bfd1bd [^]

Related to ISSUE-51431: Rounding payment should be added when paying with payment provider
* When paying receipt with payment provider, rounding amount should be
  excluded from payment amount when processing transaction

---
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentIntegration/processPayment.js
---
(0148024)
hgbot   
2023-03-28 09:59   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1644 [^]