Openbravo Issue Tracking System - POS2
View Issue Details
0051429POS2POSpublic2023-01-20 13:422023-03-09 18:16
ruben_jimenez 
ruben_jimenez 
normalminorhave not tried
closedfixed 
5
 
23Q123Q1.1 
No
0051429: Terminals without paymenbt methods and without transactions don't require to do a new cashup every day
Terminals without paymenbt methods and without transactins don't require to do a new cashup every day.

Modify logic to check if cashup is needed and avoid create new one if iti is not required

Conditions:
No payment methods configured for cashup
AND
No transactions in current cashup (we can get it from OB.App.State.getState().Cashup.totalCompleteTickets)


.
Hide from menu the cashup when the terminal type is marked as only draft orders.
No tags attached.
blocks feature request 0051801main closed ruben_jimenez RM-4405: Terminals without paymenbt methods and without transactions don't require to do a new cashup every day 
Issue History
2023-01-20 13:42ruben_jimenezNew Issue
2023-01-20 13:42ruben_jimenezAssigned To => ruben_jimenez
2023-01-20 13:42ruben_jimenezTriggers an Emergency Pack => No
2023-01-20 13:43ruben_jimenezStatusnew => scheduled
2023-01-20 13:58hgbotNote Added: 0145690
2023-01-23 13:10hgbotNote Added: 0145749
2023-01-23 14:09ruben_jimenezSummaryTerminal with draft order : Closure report shouldn't be present => SALAD-233: Terminal with draft order - Closure report shouldn't be present
2023-01-23 14:09ruben_jimenezNote Added: 0145761
2023-03-01 10:55guilleaerSummarySALAD-233: Terminal with draft order - Closure report shouldn't be present => Terminals without paymenbt methods and without transactions don't require to do a new cashup every day
2023-03-01 10:55guilleaerDescription Updatedbug_revision_view_page.php?rev_id=25609#r25609
2023-03-01 10:56guilleaerDescription Updatedbug_revision_view_page.php?rev_id=25610#r25610
2023-03-01 10:56guilleaerNote Deleted: 0145690
2023-03-01 10:56guilleaerNote Deleted: 0145749
2023-03-07 16:55hgbotNote Added: 0147338
2023-03-08 10:40ruben_jimenezTypefeature request => backport
2023-03-08 10:40ruben_jimenezTarget Version => 23Q1
2023-03-08 10:47ruben_jimenezRelationship addedblocks 0051801
2023-03-09 18:16hgbotNote Added: 0147423
2023-03-09 18:16hgbotResolutionopen => fixed
2023-03-09 18:16hgbotStatusscheduled => closed
2023-03-09 18:16hgbotFixed in Version => 23Q1.1
2023-03-09 18:16hgbotNote Added: 0147424

Notes
(0145761)
ruben_jimenez   
2023-01-23 14:09   
Merge Request created: https://gitlab.com/openbravo/customers/AGAP/com.openbravo.agapes.saladco.qrcodes/-/merge_requests/14 [^]
(0147338)
hgbot   
2023-03-07 16:55   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1576 [^]
(0147423)
hgbot   
2023-03-09 18:16   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1576 [^]
(0147424)
hgbot   
2023-03-09 18:16   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 9cefcbb4923a948cfe4001b2c30b11c215ffed21
Author: Ruben Jimenez <ruben.jimenez@openbravo.com>
Date: 09-03-2023 17:16:39
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/9cefcbb4923a948cfe4001b2c30b11c215ffed21 [^]

Fixed ISSUE-51429: Avoid cashup if there aren't payments methods

---
M web-jspack/org.openbravo.pos2/src/authentication/__test__/ForceCashup.test.jsx
M web-jspack/org.openbravo.pos2/src/authentication/shouldForceCashup.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/SwitchToPayments.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/SwitchToPayments.js
---