Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051402Retail ModulesDiscounts and Promotionspublic2023-01-18 13:492023-02-27 10:17
Reporterprakashmurugesan88 
Assigned Toprakashmurugesan88 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR23Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051402: Provide option to apply discount even qty is greater than max qty and Consider multiple prod to validate min/max qty
DescriptionIn Price Adjustment discount,
Currently discounts getting removed when the qty is greater than max qty.
So provide option to apply discount even qty is greater than max qty.

Currently single product's qty is considered for validating min/max qty.
Consider multiple products(All applicable) to validate min/max qty.

https://docs.google.com/document/d/1ckMEgQfzh275zL3BT9g2EPAg6nlE_Fo8hQmm6rtXZwA/edit# [^]
Steps To ReproduceNA
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-01-18 13:49prakashmurugesan88New Issue
2023-01-18 13:49prakashmurugesan88Assigned To => prakashmurugesan88
2023-01-18 13:49prakashmurugesan88Triggers an Emergency Pack => No
2023-01-18 13:50prakashmurugesan88Statusnew => scheduled
2023-01-23 08:02hgbotNote Added: 0145711
2023-01-23 08:02hgbotNote Added: 0145712
2023-01-23 08:02hgbotResolutionopen => fixed
2023-01-23 08:02hgbotStatusscheduled => resolved
2023-01-23 08:02hgbotFixed in Version => PR23Q2
2023-01-23 08:02hgbotNote Added: 0145713
2023-01-23 08:03hgbotFixed in VersionPR23Q2 => RR23Q2
2023-01-23 08:03hgbotNote Added: 0145714
2023-01-23 08:03hgbotNote Added: 0145715
2023-01-23 08:03hgbotNote Added: 0145716
2023-01-23 08:03hgbotNote Added: 0145717
2023-01-23 08:03hgbotNote Added: 0145718
2023-01-23 08:03hgbotNote Added: 0145719
2023-01-23 08:12marvintmReview Assigned To => marvintm
2023-01-23 08:12marvintmStatusresolved => closed
2023-01-23 09:50hgbotNote Added: 0145728
2023-02-24 16:43hgbotNote Added: 0146995
2023-02-24 16:44hgbotNote Added: 0146996
2023-02-24 16:57hgbotNote Added: 0146997
2023-02-27 07:39hgbotNote Added: 0147005
2023-02-27 07:39hgbotNote Added: 0147006
2023-02-27 10:17hgbotNote Added: 0147017

Notes
(0145711)
hgbot   
2023-01-23 08:02   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 15c4e570e1601c34d8e66852a0be299634880b1b
Author: Prakash M <prakash@qualiantech.com>
Date: 23-01-2023 12:07:15
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/15c4e570e1601c34d8e66852a0be299634880b1b [^]

Related to ISSUE-51402: Added new fields in Discount and Promotion
* Flag to Apply to products up to the max quantity
* Application Rule in case of multiple products
* Added event handler to validate mandatory to choose Priority Rule if there is max quantity

---
A src/org/openbravo/event/PriceAdjustmentHandler.java
M src-db/database/model/tables/M_OFFER.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
---
(0145712)
hgbot   
2023-01-23 08:02   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: ec76d2031ac877ae5aae37ea5d37af99bd7a4228
Author: Prakash M <prakash@qualiantech.com>
Date: 23-01-2023 12:07:15
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/ec76d2031ac877ae5aae37ea5d37af99bd7a4228 [^]

Related to ISSUE-51402: Field Apply to products up to the max quantity is displayed only when max qty is defined

---
M src-db/database/sourcedata/AD_FIELD.xml
---
(0145713)
hgbot   
2023-01-23 08:02   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 97a73f3e6e5bd4db673c3bbc344f6a19bbd64b38
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 23-01-2023 08:02:17
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/97a73f3e6e5bd4db673c3bbc344f6a19bbd64b38 [^]

Fixed ISSUE-51402: Merge branch 'fix/RM-889'

---
A src/org/openbravo/event/PriceAdjustmentHandler.java
M src-db/database/model/tables/M_OFFER.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
---
(0145714)
hgbot   
2023-01-23 08:03   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 977022d7db08f035498a4f2508ae70008cb86fce
Author: Prakash M <prakash@qualiantech.com>
Date: 18-01-2023 18:31:20
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/977022d7db08f035498a4f2508ae70008cb86fce [^]

Fixes ISSUE-51402: Changed discount calculation when min/maxQty is defined
* Considered all applicable product's qty in ticket to validate the maxQty
* When applyToProductsUpToTheMaxQuantity is true, discount will be applied upto maxQty even if total qty exceeds maxQty
* Based on PriorityRule discounts will be applied to applicable product's line
* If maxQty is defined without minQty then minQty is considered as 1

---
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/price-adjustment-discount.js
---
(0145715)
hgbot   
2023-01-23 08:03   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: f10e363a0aa7f0c50fda56c5f7e925412e7545a0
Author: Prakash M <prakash@qualiantech.com>
Date: 18-01-2023 18:32:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/f10e363a0aa7f0c50fda56c5f7e925412e7545a0 [^]

Fixes ISSUE-51402: Fixed PriceAdjustmentTest by including ApplyToProductsUpToTheMaxQuantity and PriorityRule properties

---
M src-test/org/openbravo/retail/discounts/test/base/model/definition/PriceAdjustment.java
M src-test/org/openbravo/retail/discounts/test/unittests/DiscountPriceAdjusmentTest.java
---
(0145716)
hgbot   
2023-01-23 08:03   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: a6d3673e29077afb0a1da6c36b2cb382248f3816
Author: Prakash M <prakash@qualiantech.com>
Date: 18-01-2023 18:32:28
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/a6d3673e29077afb0a1da6c36b2cb382248f3816 [^]

Fixes ISSUE-51402: Added new test to verify uptoMaxQty flag and Priority Rule for Max Qty

---
M src-test/org/openbravo/retail/discounts/test/unittests/DiscountPriceAdjusmentTest.java
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/price-adjustment-discount.js
---
(0145717)
hgbot   
2023-01-23 08:03   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 6a9a6cd43e098a3c75dfb0934448842a3de12b55
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 23-01-2023 08:03:06
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/6a9a6cd43e098a3c75dfb0934448842a3de12b55 [^]

Fixed ISSUE-51402: Merge branch 'fix/RM-889'

---
M src-test/org/openbravo/retail/discounts/test/base/model/definition/PriceAdjustment.java
M src-test/org/openbravo/retail/discounts/test/unittests/DiscountPriceAdjusmentTest.java
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/price-adjustment-discount.js
---
(0145718)
hgbot   
2023-01-23 08:03   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata [^]
Changeset: e40b80111f931658dfabf1edfbf7738ebf47b72e
Author: Prakash M <prakash@qualiantech.com>
Date: 18-01-2023 18:35:11
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/commit/e40b80111f931658dfabf1edfbf7738ebf47b72e [^]

Related to ISSUE-51402: Fix sampledata dbconsistency

---
M referencedata/sampledata/The_White_Valley_Group/M_OFFER.xml
---
(0145719)
hgbot   
2023-01-23 08:03   
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: 59091438084c656f72b5e1713b11417a72750157
Author: Prakash M <prakash@qualiantech.com>
Date: 23-01-2023 12:09:14
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/59091438084c656f72b5e1713b11417a72750157 [^]

Related to ISSUE-51402: Fixed test as now discounts will be applied considering multi products in ticket

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/SaleWithTwentyLinesII.java
---
(0145728)
hgbot   
2023-01-23 09:50   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata [^]
Changeset: 92c5f36cffde5f7d022f8de1143d5fec18e5bc74
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 23-01-2023 09:50:25
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/commit/92c5f36cffde5f7d022f8de1143d5fec18e5bc74 [^]

Related to ISSUE-51402: Fixed sampledata consistency

---
M referencedata/sampledata/Retail_Test/M_OFFER.xml
---
(0146995)
hgbot   
2023-02-24 16:43   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/830 [^]
(0146996)
hgbot   
2023-02-24 16:44   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/89 [^]
(0146997)
hgbot   
2023-02-24 16:57   
Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/273 [^]
(0147005)
hgbot   
2023-02-27 07:39   
Merge request closed: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/830 [^]
(0147006)
hgbot   
2023-02-27 07:39   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/89 [^]
(0147017)
hgbot   
2023-02-27 10:17   
Merge request closed: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/273 [^]