Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051355POS2POSpublic2023-01-12 09:142023-01-12 13:46
ReporterjavierRodriguez 
Assigned TojavierRodriguez 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version23Q1Fixed in Version23Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051355: The on exit validation is executing when the user applies discount into the ticket
DescriptionThe on exit validation is being executed when the user applies discount. this could cause problems with some customisation if same changes are done inside discountsFromUser ticket attribute
Steps To Reproduce-
Proposed Solution-
Additional Information
TagsNo tags attached.
Relationships
blocks design defect 0051348 closed javierRodriguez The on exit validation is executing when the user applies discount into the ticket 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-01-12 13:23guilleaerTypedesign defect => backport
2023-01-12 13:23guilleaerTarget Version => 23Q1
2023-01-12 13:34hgbotNote Added: 0145334
2023-01-12 13:46hgbotResolutionopen => fixed
2023-01-12 13:46hgbotStatusscheduled => closed
2023-01-12 13:46hgbotFixed in Version => 23Q1
2023-01-12 13:46hgbotNote Added: 0145335
2023-01-12 13:46hgbotNote Added: 0145336

Notes
(0145334)
hgbot   
2023-01-12 13:34   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1459 [^]
(0145335)
hgbot   
2023-01-12 13:46   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 7cf415f864f68bce7373b5788f2e34afc5357ea7
Author: Javier Rodríguez Regueiro <javier.rodriguez@openbravo.com>
Date: 12-01-2023 13:29:13
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/7cf415f864f68bce7373b5788f2e34afc5357ea7 [^]

Fixed ISSUE-51355: Skip on exit validation from order panel if the user applies the discounts

---
A web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/setIsAppliedDiscountFlow.test.js
A web-jspack/org.openbravo.pos2/src/model/user-interface/actions/discounts/setIsAppliedDiscountFlow.js
A web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/discounts/SetIsAppliedDiscountFlow.js
M web-jspack/org.openbravo.pos2/src/components/Discounts/shared/GenericDiscountOnExitDialog/GenericDiscountOnExitDialog.js
M web-jspack/org.openbravo.pos2/src/components/Discounts/shared/GenericDiscountOnExitDialog/__test__/GenericDiscountOnExitDialog.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/discounts/AddByTotalPromotionIntoTicket.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/UIExtension.js
M web-jspack/org.openbravo.pos2/src/ob-init.js
---
(0145336)
hgbot   
2023-01-12 13:46   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1459 [^]