Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051348POS2POSpublic2023-01-12 09:142023-01-12 13:24
ReporterjavierRodriguez 
Assigned TojavierRodriguez 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q2 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051348: The on exit validation is executing when the user applies discount into the ticket
DescriptionThe on exit validation is being executed when the user applies discount. this could cause problems with some customisation if same changes are done inside discountsFromUser ticket attribute
Steps To Reproduce-
Proposed Solution-
Additional Information
TagsNo tags attached.
Relationships
depends on backport 005135523Q1 closed javierRodriguez The on exit validation is executing when the user applies discount into the ticket 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-01-12 09:14javierRodriguezNew Issue
2023-01-12 09:14javierRodriguezAssigned To => javierRodriguez
2023-01-12 09:14javierRodriguezOBNetwork customer => No
2023-01-12 09:14javierRodriguezTriggers an Emergency Pack => No
2023-01-12 09:27hgbotMerge Request Status => open
2023-01-12 09:27hgbotNote Added: 0145313
2023-01-12 13:23guilleaerStatusnew => scheduled
2023-01-12 13:23hgbotMerge Request Statusopen => approved
2023-01-12 13:24hgbotNote Added: 0145332
2023-01-12 13:24hgbotResolutionopen => fixed
2023-01-12 13:24hgbotStatusscheduled => closed
2023-01-12 13:24hgbotFixed in Version => 23Q2
2023-01-12 13:24hgbotNote Added: 0145333

Notes
(0145313)
hgbot   
2023-01-12 09:27   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1456 [^]
(0145332)
hgbot   
2023-01-12 13:24   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1456 [^]
(0145333)
hgbot   
2023-01-12 13:24   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 05bb5a03c8953a0316bc7957b2cff3ad419d65a6
Author: Javier Rodríguez Regueiro <javier.rodriguez@openbravo.com>
Date: 12-01-2023 12:24:11
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/05bb5a03c8953a0316bc7957b2cff3ad419d65a6 [^]

Fixed ISSUE-51348: Skip on exit validation from order panel if the user applies the discounts

---
A web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/setIsAppliedDiscountFlow.test.js
A web-jspack/org.openbravo.pos2/src/model/user-interface/actions/discounts/setIsAppliedDiscountFlow.js
A web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/discounts/SetIsAppliedDiscountFlow.js
M web-jspack/org.openbravo.pos2/src/components/Discounts/shared/GenericDiscountOnExitDialog/GenericDiscountOnExitDialog.js
M web-jspack/org.openbravo.pos2/src/components/Discounts/shared/GenericDiscountOnExitDialog/__test__/GenericDiscountOnExitDialog.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/discounts/AddByTotalPromotionIntoTicket.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/UIExtension.js
M web-jspack/org.openbravo.pos2/src/ob-init.js
---