Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0005126 | Openbravo ERP | 02. Master data management | public | 2008-09-19 18:42 | 2009-04-21 11:05 |
|
| Reporter | shuehner | |
| Assigned To | shuehner | |
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | pi | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0005126: Product Selector does take a very long time to open with many products |
| Description | The SQL used in the product selector is not efficient when having 0029055:0075000 products.
=> the product selector does not work with this amount of work as it runs in a timeout |
| Steps To Reproduce | |
| Proposed Solution | |
| Additional Information | |
| Tags | performance2.40scrum, Sprint-1 |
| Relationships | | depends on | feature request | 0005124 | | closed | shuehner | DataGrid.js supports sortable=yes/no for each column, but not our DataGridStructure template for defining a grid | | depends on | backport | 0005152 | | closed | shuehner | Product Selector does take a very long time to open with many products | | related to | defect | 0007898 | | closed | shuehner | Product selector takes several time to show about 4000 products |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2008-09-19 18:42 | shuehner | New Issue | |
| 2008-09-19 18:42 | shuehner | Assigned To | => cromero |
| 2008-09-19 18:42 | shuehner | sf_bug_id | 0 => 2119573 |
| 2008-09-19 18:42 | shuehner | Regression testing | => No |
| 2008-09-19 18:42 | shuehner | Assigned To | cromero => shuehner |
| 2008-09-19 18:46 | shuehner | Tag Attached: performance2.40scrum | |
| 2008-09-19 18:51 | shuehner | Note Added: 0009105 | |
| 2008-09-19 18:52 | shuehner | Note Added: 0009106 | |
| 2008-09-19 18:53 | shuehner | Relationship added | depends on 0005124 |
| 2008-09-22 12:55 | cromero | Status | new => scheduled |
| 2008-09-22 12:55 | cromero | fix_in_branch | => trunk |
| 2008-09-23 11:55 | svnbot | Checkin | |
| 2008-09-23 11:55 | svnbot | Note Added: 0009150 | |
| 2008-09-23 11:55 | svnbot | Status | scheduled => resolved |
| 2008-09-23 11:55 | svnbot | Resolution | open => fixed |
| 2008-09-23 11:55 | svnbot | svn_revision | => 7709 |
| 2008-10-23 07:48 | iperdomo | Tag Attached: sprint1 | |
| 2008-10-24 18:19 | iperdomo | Tag Detached: sprint1 | |
| 2008-10-24 18:19 | iperdomo | Tag Attached: Sprint-1 | |
| 2008-10-30 19:13 | svnbot | Checkin | |
| 2008-10-30 19:13 | svnbot | Note Added: 0009859 | |
| 2008-10-30 19:13 | svnbot | svn_revision | 7709 => 9468 |
| 2009-03-02 16:42 | shuehner | Relationship added | related to 0007898 |
| 2009-04-21 11:05 | psarobe | Status | resolved => closed |
|
Notes |
|
|
|
The SQL does the calculation for all columns for all products before limiting the result to the currently used range of products (size of the grid).
Fix by rewriting the SQL to first filter and limit the rows and then calculate all other columns. |
|
|
|
|
|
The fix for this bug will disable sorting for all columns in the Product-selector besides (Search key and Name). This introduces a feature regression as it is not possible anymore to sort by the other columns! Readding the lost functionality is possible but needs further work later. |
|
|
|
(0009150)
|
|
svnbot
|
|
2008-09-23 11:55
|
|
Repository: openbravo
Revision: 7709
Author: huehner
Date: 2008-09-23 11:55:08 +0200 (Tue, 23 Sep 2008)
Fixed 5126
Improved performance of the product selector with many products:
- speed up counting of record in filter by using extra sql query
- rewrite data retrieving sql to first filter and limit and then calculate the rest of the data
- disable sorting of all columns besides: key,name (feature regression)
---
U trunk/src/org/openbravo/erpCommon/info/Product.java
U trunk/src/org/openbravo/erpCommon/info/Product_data.xsql
---
https://dev.openbravo.com/websvn/openbravo/?rev=7709&sc=1 [^]
|
|
|
|
(0009859)
|
|
svnbot
|
|
2008-10-30 19:13
|
|
Repository: openbravo
Revision: 9468
Author: huehner
Date: 2008-10-30 19:13:14 +0100 (Thu, 30 Oct 2008)
Issue 5126
Fix error introduced in r9465 which did not show all relevant products in some cases.
---
U trunk/src/org/openbravo/erpCommon/info/Product.java
U trunk/src/org/openbravo/erpCommon/info/Product_data.xsql
---
https://dev.openbravo.com/websvn/openbravo/?rev=9468&sc=1 [^]
|
|