Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051252Openbravo ERP07. Sales managementpublic2022-12-28 11:032023-02-13 12:46
Reporterngarcia 
Assigned ToRetail 
PriorityurgentSeveritymajorReproducibilityalways
StatusnewResolutionopen 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051252: Different behavior for "Included Characteristics: All of the values defined" discount configuration in the ERP and in POS
DescriptionDifferent behavior for "Included Characteristics: All of the values defined" discount configuration in the ERP and in POS
Steps To ReproduceIn the backoffice:
   Create a new record in Discounts And Promotions window
   Organization: *
   Discount/Promotion Type: Price Adjustment
   Included Characteristics: All of the values defined
   Discount %: 50

   Add two records in Include Characteristics tab:
      Characteristics: Brand, Characteristics Value: Lifesystems
      Characteristics: Brand, Characteristics Value: Poc

   Create a sales order
   Add Adhesive body warmers product that has characteristics to it
   Book it and check no discount is applied

In the POS:
   Create a receipt
   Add Adhesive body warmers product and check the discount is applied
Proposed SolutionFix the m_promotion_calculate function
Additional Information
TagsNo tags attached.
Relationships
related to defect 0047572 closed ranjith_qualiantech_com Retail Modules Discounts which include or exclude certain characteristic values are not working properly 
related to feature request 0027205 closed ioritzCia Openbravo ERP Discounts and Promotions should be able to filter by product characteristics 
related to feature request 0043502 closed nicola_uva Retail Modules Discounts characteristics filter should be improved for cases of multiple characteristic values to handle inclusion/exclusion 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-12-28 11:03ngarciaNew Issue
2022-12-28 11:03ngarciaAssigned To => Triage Omni OMS
2022-12-28 11:03ngarciaModules => Core
2022-12-28 11:03ngarciaTriggers an Emergency Pack => No
2022-12-28 12:33aferrazRelationship addedrelated to 0047572
2022-12-28 12:35PracticsIssue Monitored: Practics
2022-12-28 12:40aferrazRelationship addedrelated to 0027205
2022-12-28 12:45aferrazAssigned ToTriage Omni OMS => francisco_ofarril
2022-12-30 17:12hgbotNote Added: 0145104
2023-01-20 10:27hgbotNote Added: 0145682
2023-01-20 10:28aferrazReview Assigned To => aferraz
2023-01-20 10:28aferrazNote Added: 0145683
2023-01-20 10:28aferrazStatusnew => closed
2023-01-20 10:28aferrazResolutionopen => no change required
2023-01-20 12:20ngarciaAssigned Tofrancisco_ofarril =>
2023-01-20 12:20ngarciaStatusclosed => new
2023-01-20 12:20ngarciaResolutionno change required => open
2023-01-20 12:20ngarciaProjectOpenbravo ERP => Openbravo for Retail
2023-01-20 12:21ngarciaReview Assigned Toaferraz =>
2023-01-20 12:22ngarciaAssigned To => Retail
2023-01-20 12:22ngarciaNote Added: 0145687
2023-01-27 13:08ngarciaProjectOpenbravo for Retail => Retail Modules
2023-01-27 13:08ngarciaCategory07. Sales management => Web POS
2023-01-30 10:42ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2023-01-30 11:02ranjith_qualiantech_comRelationship addedrelated to 0043502
2023-02-13 07:57marvintmNote Added: 0146408
2023-02-13 07:57marvintmTypedefect => design defect
2023-02-13 07:58ranjith_qualiantech_comAssigned Toranjith_qualiantech_com => Retail
2023-02-13 12:45ngarciaProjectRetail Modules => Openbravo ERP
2023-02-13 12:46ngarciaCategoryWeb POS => 07. Sales management

Notes
(0145104)
hgbot   
2022-12-30 17:12   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/801 [^]
(0145682)
hgbot   
2023-01-20 10:27   
Merge request closed: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/801 [^]
(0145683)
aferraz   
2023-01-20 10:28   
As per documentation, current behaviour is the correct one: http://wiki.openbravo.com/wiki/Retail:Discounts_and_Promotions_Rules [^]

Included Characteristics: All of the values defined

All of the values defined: For included characteristics, this means that all values need to be present for the product to be able to receive the discount. For excluded characteristics, this means that only if all of the values are present for the product, the discount will not be applied.

Any of the ones defined: For included characteristics, this means that if any of the values is present for the product, the discount can be applied. For excluded characteristics, this means that if one of the values is present in the product, then the discount will not be applied.
(0145687)
ngarcia   
2023-01-20 12:22   
Changed from ERP to POS then
(0146408)
marvintm   
2023-02-13 07:57   
After further review, actually the behavior in the POS is the intended one. There was a project done with the goal of implementing this behavior:

https://issues.openbravo.com/view.php?id=43502 [^]

Therefore, the unintended behavior actually happens in the back office. I'm also changing this to design defect, as we are currently not maintaining the discounts functionality in the back office flows.