Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051238Openbravo ERPA. Platformpublic2022-12-23 09:212023-04-24 08:52
Reporterjarmendariz 
Assigned Tojarmendariz 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051238: Company Logo Configuration Refactor
DescriptionWe want to upgrade the definition of company logos at System, Client and Organization level in order to simplify and add support for new sets of icons (dark mode, alternative logos for portrait, etc.)

Technical document: https://docs.google.com/document/d/1rLpvmMHWWo9eORbCENGWOr97ufg8GPQ22HI-ia_euJk/edit# [^]
Steps To ReproduceSee description
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0050400 scheduled ablasco POS2 Portrait mode support 
related to feature request 0051357 closed igor_trebol Retail Modules Use Company Logo for receipts field in receipt templates 
related to defect 0051560 acknowledged Triage Platform Base Openbravo ERP Company logo in menu bar is cropped in Firefox 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-12-23 09:21jarmendarizNew Issue
2022-12-23 09:21jarmendarizAssigned To => jarmendariz
2022-12-23 09:21jarmendarizModules => Core
2022-12-23 09:21jarmendarizTriggers an Emergency Pack => No
2022-12-23 09:22jarmendarizRelationship addedrelated to 0050400
2023-01-09 14:17hgbotNote Added: 0145209
2023-01-09 14:19hgbotNote Added: 0145210
2023-01-09 18:09hgbotNote Added: 0145220
2023-01-10 16:05hgbotNote Added: 0145239
2023-01-10 16:06hgbotNote Added: 0145240
2023-01-10 16:09hgbotNote Added: 0145241
2023-01-10 16:11hgbotNote Added: 0145242
2023-01-12 05:51hgbotNote Added: 0145307
2023-01-12 05:59hgbotNote Added: 0145308
2023-01-12 13:55jarmendarizRelationship addedrelated to 0051357
2023-01-19 13:48hgbotNote Added: 0145641
2023-02-02 09:26hgbotNote Added: 0146149
2023-02-02 13:24hgbotNote Added: 0146168
2023-02-03 09:12hgbotNote Added: 0146206
2023-02-03 09:12hgbotNote Added: 0146207
2023-02-03 09:13hgbotNote Added: 0146208
2023-02-03 09:13hgbotNote Added: 0146209
2023-02-03 09:14hgbotNote Added: 0146210
2023-02-03 09:14hgbotNote Added: 0146211
2023-02-03 09:15hgbotNote Added: 0146212
2023-02-03 09:15hgbotNote Added: 0146213
2023-02-03 09:16hgbotNote Added: 0146214
2023-02-03 09:16hgbotNote Added: 0146215
2023-02-03 09:17hgbotNote Added: 0146216
2023-02-03 09:17hgbotNote Added: 0146217
2023-02-03 09:19hgbotNote Added: 0146219
2023-02-03 09:19hgbotNote Added: 0146220
2023-02-03 09:22hgbotResolutionopen => fixed
2023-02-03 09:22hgbotStatusnew => closed
2023-02-03 09:22hgbotFixed in Version => 23Q2
2023-02-03 09:22hgbotNote Added: 0146223
2023-02-03 09:22hgbotNote Added: 0146224
2023-02-03 09:23hgbotNote Added: 0146225
2023-02-03 09:23hgbotNote Added: 0146226
2023-02-03 09:24hgbotNote Added: 0146227
2023-02-03 09:24hgbotNote Added: 0146228
2023-02-03 09:25hgbotNote Added: 0146229
2023-02-03 09:25hgbotNote Added: 0146230
2023-02-03 09:26hgbotNote Added: 0146231
2023-02-03 09:26hgbotNote Added: 0146232
2023-02-03 10:18hgbotNote Added: 0146238
2023-02-03 11:20hgbotNote Added: 0146260
2023-02-09 18:46jarmendarizRelationship addedrelated to 0051560
2023-02-10 12:20hgbotNote Added: 0146376
2023-02-21 11:00hgbotNote Added: 0146812
2023-04-24 08:52hgbotNote Added: 0148762

Notes
(0145209)
hgbot   
2023-01-09 14:17   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1029 [^]
(0145210)
hgbot   
2023-01-09 14:19   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/456 [^]
(0145220)
hgbot   
2023-01-09 18:09   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/merge_requests/41 [^]
(0145239)
hgbot   
2023-01-10 16:05   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/956 [^]
(0145240)
hgbot   
2023-01-10 16:06   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1450 [^]
(0145241)
hgbot   
2023-01-10 16:09   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore/-/merge_requests/42 [^]
(0145242)
hgbot   
2023-01-10 16:11   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/806 [^]
(0145307)
hgbot   
2023-01-12 05:51   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/merge_requests/35 [^]
(0145308)
hgbot   
2023-01-12 05:59   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/55 [^]
(0145641)
hgbot   
2023-01-19 13:48   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.warehouse.advancedwarehouseoperations.sampledata/-/merge_requests/16 [^]
(0146149)
hgbot   
2023-02-02 09:26   
Merge Request created: https://gitlab.com/openbravo/product/mods/org.openbravo.distributionorder/-/merge_requests/34 [^]
(0146168)
hgbot   
2023-02-02 13:24   
Merge Request created: https://gitlab.com/openbravo/ci/backoffice-test/-/merge_requests/29 [^]
(0146206)
hgbot   
2023-02-03 09:12   
Repository: https://gitlab.com/openbravo/ci/backoffice-test [^]
Changeset: d3d08cd2c01df6d7c95f5bf9b09f8f0135c40339
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 03-02-2023 09:12:32
URL: https://gitlab.com/openbravo/ci/backoffice-test/-/commit/d3d08cd2c01df6d7c95f5bf9b09f8f0135c40339 [^]

Related to ISSUE-51238: Company Logo Refactor

---
A testfiles/ShowImageLogo.svg
M config/ci.properties
M geckodriver
M src-test/com/openbravo/test/integration/erp/modules/client/application/navigationbarcomponents/gui/NavigationBar.java
M src-test/com/openbravo/test/integration/erp/modules/userinterface/smartclient/gui/Image.java
---
(0146207)
hgbot   
2023-02-03 09:12   
Merge request merged: https://gitlab.com/openbravo/ci/backoffice-test/-/merge_requests/29 [^]
(0146208)
hgbot   
2023-02-03 09:13   
Repository: https://gitlab.com/openbravo/product/mods/org.openbravo.distributionorder [^]
Changeset: f5f2d43fef392124dc993fa75dc70c39aea131b6
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 03-02-2023 09:13:25
URL: https://gitlab.com/openbravo/product/mods/org.openbravo.distributionorder/-/commit/f5f2d43fef392124dc993fa75dc70c39aea131b6 [^]

Related to ISSUE-51238: Company Logo Refactor

---
M src/org/openbravo/distributionorder/erpReports/OBDO_DistOrder.jrxml
M src/org/openbravo/distributionorder/erpReports/OBDO_Movement.jrxml
---
(0146209)
hgbot   
2023-02-03 09:13   
Merge request merged: https://gitlab.com/openbravo/product/mods/org.openbravo.distributionorder/-/merge_requests/34 [^]
(0146210)
hgbot   
2023-02-03 09:14   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.warehouse.advancedwarehouseoperations.sampledata [^]
Changeset: 15f6a3f32dde9226a24020eabc97353323b6e51a
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 03-02-2023 09:14:09
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.warehouse.advancedwarehouseoperations.sampledata/-/commit/15f6a3f32dde9226a24020eabc97353323b6e51a [^]

Related to ISSUE-51238: Company Logo Refactor

---
M referencedata/sampledata/AWO_QA/AD_CLIENTINFO.xml
M referencedata/sampledata/AWO_QA/AD_IMAGE.xml
M referencedata/sampledata/AWO_QA/AD_ORGINFO.xml
---
(0146211)
hgbot   
2023-02-03 09:14   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.warehouse.advancedwarehouseoperations.sampledata/-/merge_requests/16 [^]
(0146212)
hgbot   
2023-02-03 09:15   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata [^]
Changeset: 0b5c47c4c12c6b399dd3e18ecdbec32e638940f1
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 03-02-2023 09:15:10
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/commit/0b5c47c4c12c6b399dd3e18ecdbec32e638940f1 [^]

Related to ISSUE-51238: Company Logo Refactor

---
M referencedata/sampledata/The_White_Valley_Group/AD_CLIENTINFO.xml
M referencedata/sampledata/The_White_Valley_Group/AD_IMAGE.xml
M referencedata/sampledata/The_White_Valley_Group/AD_ORGINFO.xml
---
(0146213)
hgbot   
2023-02-03 09:15   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/55 [^]
(0146214)
hgbot   
2023-02-03 09:16   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata [^]
Changeset: 08f2981f55785864308661fce0eeac65610b3a86
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 03-02-2023 09:16:00
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/commit/08f2981f55785864308661fce0eeac65610b3a86 [^]

Related to ISSUE-51238: Company Logo Refactor

---
M referencedata/sampledata/Retail_Test/AD_CLIENTINFO.xml
M referencedata/sampledata/Retail_Test/AD_IMAGE.xml
M referencedata/sampledata/Retail_Test/AD_ORGINFO.xml
---
(0146215)
hgbot   
2023-02-03 09:16   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/merge_requests/35 [^]
(0146216)
hgbot   
2023-02-03 09:17   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore [^]
Changeset: 566d054a65298f74af0176de008417b9ff57a854
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 03-02-2023 09:16:49
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore/-/commit/566d054a65298f74af0176de008417b9ff57a854 [^]

Related to ISSUE-51238: Company Logo Refactor

---
M src/org/openbravo/retail/copystore/process/CopyStoreProcess.java
---
(0146217)
hgbot   
2023-02-03 09:17   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore/-/merge_requests/42 [^]
(0146219)
hgbot   
2023-02-03 09:19   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/806 [^]
(0146220)
hgbot   
2023-02-03 09:19   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: ccd64391fb5304e8de801c6243f3198af5ca58ed
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 03-02-2023 09:18:45
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/ccd64391fb5304e8de801c6243f3198af5ca58ed [^]

Related to ISSUE-51238: Company Logo Refactor

---
---
(0146223)
hgbot   
2023-02-03 09:22   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 107e6b932c455db6ebf3b9e4828d70753f708848
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 03-02-2023 09:22:19
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/107e6b932c455db6ebf3b9e4828d70753f708848 [^]

Fixed ISSUE-51238: Company Logo Refactor

---
A web-jspack/org.openbravo.pos2/src/components/POSAppInfo/config/POSAppInfo.portrait.config.json
M web-jspack/org.openbravo.pos2/src/components/POSAppInfo/POSAppInfo.config.json
M web-jspack/org.openbravo.pos2/src/ob-init.js
---
(0146224)
hgbot   
2023-02-03 09:22   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1450 [^]
(0146225)
hgbot   
2023-02-03 09:23   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/956 [^]
(0146226)
hgbot   
2023-02-03 09:23   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: c0cdffb38b233bc27c84fe13563ca5a6e468fd4a
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 03-02-2023 09:23:21
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/c0cdffb38b233bc27c84fe13563ca5a6e468fd4a [^]

Related to ISSUE-51238: Company Logo Refactor

---
A web-jspack/org.openbravo.core2/src/assets/icons/logoOpenbravoSubmark.svg
A web-jspack/org.openbravo.core2/src/components/AppInfo/config/AppInfo.portrait.config.json
M web-jspack/org.openbravo.core2/src/assets/style/iconography.scss
M web-jspack/org.openbravo.core2/src/components/AppInfo/AppInfo.config.json
M web-jspack/org.openbravo.core2/src/components/AppInfo/AppInfo.jsx
M web-jspack/org.openbravo.core2/src/components/AppInfo/AppInfo.scss
M web-jspack/org.openbravo.core2/src/components/CompanyLogo/CompanyLogo.jsx
M web-jspack/org.openbravo.core2/src/components/CompanyLogo/CompanyLogo.scss
M web-jspack/org.openbravo.core2/src/ob-init.js
---
(0146227)
hgbot   
2023-02-03 09:24   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata [^]
Changeset: e45fc3267c7e666800bb85c63c617f313165bc40
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 03-02-2023 09:24:24
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/commit/e45fc3267c7e666800bb85c63c617f313165bc40 [^]

Related to ISSUE-51238: Company Logo Refactor

---
M referencedata/sampledata/The_White_Valley_Group/AD_CLIENTINFO.xml
M referencedata/sampledata/The_White_Valley_Group/AD_IMAGE.xml
M referencedata/sampledata/The_White_Valley_Group/AD_ORGINFO.xml
---
(0146228)
hgbot   
2023-02-03 09:24   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/merge_requests/41 [^]
(0146229)
hgbot   
2023-02-03 09:25   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: c97b54634fda08497e73e4117c4955ee46c4669a
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 03-02-2023 09:25:06
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/c97b54634fda08497e73e4117c4955ee46c4669a [^]

Related to ISSUE-51238: Company Logo Refactor

---
M src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java
M web/org.openbravo.mobile.core/app/web-printer/standardprinters.js
M web/org.openbravo.mobile.core/assets/css/obmobc-main.css
---
(0146230)
hgbot   
2023-02-03 09:25   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/456 [^]
(0146231)
hgbot   
2023-02-03 09:26   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 0026b1b7ec53f673c283cf18501b40b8ded46078
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 03-02-2023 09:26:20
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/0026b1b7ec53f673c283cf18501b40b8ded46078 [^]

Related to ISSUE-51238: Company Logo Refactor

---
A build/classes/org/openbravo/retail/posterminal/modulescript/MigrateClientCompanyLogo.class
A build/classes/org/openbravo/retail/posterminal/modulescript/MigrateClientCompanyLogoData.class
A build/classes/org/openbravo/retail/posterminal/modulescript/MigrateClientCompanyLogoSelectData.class
A src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/MigrateClientCompanyLogo.java
A src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/MigrateClientCompanyLogoSelect_data.xsql
A src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/MigrateClientCompanyLogo_data.xsql
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src/org/openbravo/retail/posterminal/LoginUtilsServlet.java
M src/org/openbravo/retail/posterminal/ad_reports/CashUpReport.jrxml
M src/org/openbravo/retail/posterminal/term/Terminal.java
---
(0146232)
hgbot   
2023-02-03 09:26   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1029 [^]
(0146238)
hgbot   
2023-02-03 10:18   
Repository: https://gitlab.com/openbravo/ci/backoffice-test [^]
Changeset: 544759e1dfc8f468e35e17bf705e2f453e323528
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 03-02-2023 10:18:24
URL: https://gitlab.com/openbravo/ci/backoffice-test/-/commit/544759e1dfc8f468e35e17bf705e2f453e323528 [^]

Related to ISSUE-51238: Company Logo refactor

---
A testfiles/ShowImageLogo.svg
M src-test/com/openbravo/test/integration/erp/modules/client/application/navigationbarcomponents/gui/NavigationBar.java
M src-test/com/openbravo/test/integration/erp/modules/userinterface/smartclient/gui/Image.java
---
(0146260)
hgbot   
2023-02-03 11:20   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 8ffdcb1243c706cc3c689069c3a9cd9984903a8a
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 03-02-2023 11:20:03
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/8ffdcb1243c706cc3c689069c3a9cd9984903a8a [^]

Related to ISSUE-51238: Use org client if available when fetching logos

---
M src/org/openbravo/erpCommon/utility/companylogo/CompanyLogoUtils.java
---
(0146376)
hgbot   
2023-02-10 12:20   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 58f8390fbd3960c18cdeeef999bc82e7bda5147c
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 10-02-2023 12:20:32
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/58f8390fbd3960c18cdeeef999bc82e7bda5147c [^]

Related to ISSUE-51238: Fixed copyright notice in modulescript files

---
M src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/MigrateClientCompanyLogo.java
M src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/MigrateClientCompanyLogoSelect_data.xsql
M src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/MigrateClientCompanyLogo_data.xsql
---
(0146812)
hgbot   
2023-02-21 11:00   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata [^]
Changeset: 406e298b3f9a1b636d70799020225b746c341c9c
Author: Aaron Calero <aaron.calero@openbravo.com>
Date: 21-02-2023 10:59:08
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/commit/406e298b3f9a1b636d70799020225b746c341c9c [^]

Related to ISSUE-51238: Restored C_EXTBP_ENABLED column removed by mistake

---
M referencedata/sampledata/The_White_Valley_Group/AD_CLIENTINFO.xml
---
(0148762)
hgbot   
2023-04-24 08:52   
Repository: https://gitlab.com/openbravo/ci/backoffice-test [^]
Changeset: 544759e1dfc8f468e35e17bf705e2f453e323528
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 03-02-2023 10:18:24
URL: https://gitlab.com/openbravo/ci/backoffice-test/-/commit/544759e1dfc8f468e35e17bf705e2f453e323528 [^]

Related to ISSUE-51238: Company Logo refactor

---
A testfiles/ShowImageLogo.svg
M src-test/com/openbravo/test/integration/erp/modules/client/application/navigationbarcomponents/gui/NavigationBar.java
M src-test/com/openbravo/test/integration/erp/modules/userinterface/smartclient/gui/Image.java
---