Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051235Retail ModulesDiscounts and Promotionspublic2022-12-22 17:282023-01-30 00:23
ReporterLcazaux 
Assigned Togdagnesses 
PriorityurgentSeveritymajorReproducibilityrandom
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051235: [Promotions] - Selected filters disappear with message "sélectionnez un enregistrement parent pour visualiser ses fils"
DescriptionIn Test Environment.

In Promotions module, the selected filters disappear from the corresponding tabs, quite often, without knowing the exact reason why or the action to make to see the values selected again.

Usually I try to click on the different levels of the screen (header, tabs, etc…) or refresh the screen but no result.

The only way to see the filter values in the tabs again is to completely close the promotion window and open it again.

NOTE : THIS DOES NOT REPRODUCE ALWAYS
Steps To Reproduce(See this note for other steps to reproduce: https://issues.openbravo.com/view.php?id=51235#c145063 [^])

In TEST:
- Go to Discount and Promotions
- Create a new promo with start and end dates
- Add "Only those defined" for Products and for Organization
- Select an organization in the sub tab
- Select at least 2 products in the sub tab
- Click on "Activate/Deactive"
Once it is activated, we can see that none of the Products we selected nor the organizations are still displayed --> the filters are down
Proposed SolutionAfter activating the Promo in Test, the filters must stay in any case
Additional Information
TagsFASH
Relationships
Attached Filespng 2022-12-22_17h26_56.png (104,497) 2022-12-22 17:28
https://issues.openbravo.com/file_download.php?file_id=17977&type=bug
png

png 2022-12-22_17h27_50.png (95,305) 2022-12-22 17:29
https://issues.openbravo.com/file_download.php?file_id=17978&type=bug
png

png 2022-12-22_17h24_35.png (96,647) 2022-12-22 17:29
https://issues.openbravo.com/file_download.php?file_id=17979&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2022-12-22 17:28LcazauxNew Issue
2022-12-22 17:28LcazauxAssigned To => Retail
2022-12-22 17:28LcazauxFile Added: 2022-12-22_17h26_56.png
2022-12-22 17:28LcazauxTriggers an Emergency Pack => No
2022-12-22 17:28LcazauxTag Attached: FASH
2022-12-22 17:29LcazauxFile Added: 2022-12-22_17h27_50.png
2022-12-22 17:29LcazauxFile Added: 2022-12-22_17h24_35.png
2022-12-28 07:44ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2022-12-28 07:44ranjith_qualiantech_comStatusnew => scheduled
2022-12-29 07:55ranjith_qualiantech_comSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=25318#r25318
2022-12-29 07:56ranjith_qualiantech_comSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=25319#r25319
2022-12-29 07:56ranjith_qualiantech_comNote Added: 0145063
2022-12-29 08:04ranjith_qualiantech_comIssue Monitored: ranjith_qualiantech_com
2022-12-29 09:12ranjith_qualiantech_comAssigned Toranjith_qualiantech_com => Triage Platform Base
2023-01-02 11:34ranjith_qualiantech_comNote Edited: 0145063bug_revision_view_page.php?bugnote_id=0145063#r25330
2023-01-02 11:36ranjith_qualiantech_comNote Edited: 0145063bug_revision_view_page.php?bugnote_id=0145063#r25331
2023-01-02 11:37ranjith_qualiantech_comNote Edited: 0145063bug_revision_view_page.php?bugnote_id=0145063#r25332
2023-01-17 12:01AugustoMauchAssigned ToTriage Platform Base => gdagnesses
2023-01-17 15:27AugustoMauchSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=25403#r25403
2023-01-17 15:27AugustoMauchNote Edited: 0145063bug_revision_view_page.php?bugnote_id=0145063#r25404
2023-01-17 15:32AugustoMauchNote Edited: 0145063bug_revision_view_page.php?bugnote_id=0145063#r25405
2023-01-18 23:32hgbotNote Added: 0145607
2023-01-30 00:23hgbotResolutionopen => fixed
2023-01-30 00:23hgbotStatusscheduled => closed
2023-01-30 00:23hgbotNote Added: 0145982
2023-01-30 00:23hgbotFixed in Version => PR23Q2
2023-01-30 00:23hgbotNote Added: 0145983

Notes
(0145063)
ranjith_qualiantech_com   
2022-12-29 07:56   
(edited on: 2023-01-17 15:32)
Steps to Reproduce in livebuilds Modules
https://livebuilds.openbravo.com/retail_modules_pgsql_pi/ [^]
Login with Openbravo User / Role: The White Valley Group Admin
1) Open Product Window
2) Search for Name - "Ultra Raptor W"
3) Open record in edit form the one with the Is Generic = false value
4) Button "Update Characteristics" is visible now <-- OK
5) Close Product Window
6) Open Product "Ultra Raptor W" from Workspace's "Recent Documents"
7) Button "Update Characteristics" is visible now.
8) Click Button "Update Characteristics" & Click "Ok" in the popup
9) Button "Update Characteristics" is not visible now <-- KO

Problem: In product window, if more than 100 records are present
And Selected record index is more than 100, then we are having this problem (Button are not visible)
https://gitlab.com/openbravo/product/openbravo/-/blob/master/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js#L2324 [^]
(0145607)
hgbot   
2023-01-18 23:32   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/811 [^]
(0145982)
hgbot   
2023-01-30 00:23   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/811 [^]
(0145983)
hgbot   
2023-01-30 00:23   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: a36802642325f7582010ac489ec80aae8e6edb7d
Author: Guillermo Dagnesses Segura <guillermo.dagnesses@doceleguas.com>
Date: 30-01-2023 00:12:13
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/a36802642325f7582010ac489ec80aae8e6edb7d [^]

Fixed ISSUE-51235: Toolbar button disappear when update product's characteristics

- In product window, if more than 100 records are present and the selected record index is greater than 100, then the button does not show

- Before refreshing the grid after executing a process, check if the view was opened with a target record. If so do not refresh it, as there is a risk of losing the current selection. Note that we are only preventing the refresh of the grid, the current record is still refreshed.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
---