Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051152Openbravo ERPA. Platformpublic2022-12-14 13:282022-12-21 08:23
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR23Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051152: Review and remove modulescripts only required for updates from <16Q1 - platform
DescriptionIssue 51068 blocks upgrades from versions older than 16Q1.

Any modulescript running on upgrades from <16Q1 is no longer needed and can be removed if it is marked as NOT running also during install.source

Many (very) old modulescripts when created before being able to declare executeOnInstall=false.
Those old ones need be reviewed one-by-one if they can be safely skipped during install and then be removed as obsolete
Steps To Reproduce51068 change ensures that old version (before update) is at least 16Q1 (x.x.28207)
Any buildvalidation defined with ExecutionLimits end-version before that (and moduleId of a module contained in backoffice repo) => is candidated to be removed.

Directly possible to remove it is also has executeOnInstall=false already.
If not it must be reviewed first is that flag applies to them also.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on feature request 0051068PR23Q1 closed shuehner Block direct upgrades from version older than 16Q1 to latest version 
related to defect 0051153 closed shuehner Review and remove modulescripts only required for updates from <16Q1 - omni 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-12-14 13:28shuehnerNew Issue
2022-12-14 13:28shuehnerAssigned To => shuehner
2022-12-14 13:28shuehnerOBNetwork customer => No
2022-12-14 13:28shuehnerModules => Core
2022-12-14 13:28shuehnerTriggers an Emergency Pack => No
2022-12-14 13:29shuehnerRelationship addeddepends on 0051068
2022-12-14 13:41hgbotMerge Request Status => open
2022-12-14 13:41hgbotNote Added: 0144678
2022-12-14 14:40shuehnerIssue cloned0051153
2022-12-14 14:40shuehnerRelationship addedrelated to 0051153
2022-12-21 08:22hgbotMerge Request Statusopen => approved
2022-12-21 08:23hgbotResolutionopen => fixed
2022-12-21 08:23hgbotStatusnew => closed
2022-12-21 08:23hgbotFixed in Version => PR23Q1
2022-12-21 08:23hgbotNote Added: 0144858
2022-12-21 08:23hgbotNote Added: 0144859

Notes
(0144678)
hgbot   
2022-12-14 13:41   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/791 [^]
(0144858)
hgbot   
2022-12-21 08:23   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/791 [^]
(0144859)
hgbot   
2022-12-21 08:23   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 9bffaae704fce4c0b5e8d5967a8524180bcd491d
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 21-12-2022 07:23:31
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/9bffaae704fce4c0b5e8d5967a8524180bcd491d [^]

fixed ISSUE-51152: Delete obsolete modulescripts

These scripts only ran on updates before MP16
ISSUE-51068 blocks updates from <16Q1 causing it to never run on
updates anymore.

---
R src-util/modulescript/build/classes/org/openbravo/modulescript/ConvertImages.class
R src-util/modulescript/build/classes/org/openbravo/modulescript/DeleteRedundantTranslations.class
R src-util/modulescript/build/classes/org/openbravo/modulescript/DeleteRedundantTranslationsData.class
R src-util/modulescript/build/classes/org/openbravo/modulescript/InitializeAlertStatus.class
R src-util/modulescript/build/classes/org/openbravo/modulescript/InitializeAlertStatusData.class
R src-util/modulescript/build/classes/org/openbravo/modulescript/PgJdbcDatesIssue.class
R src-util/modulescript/build/classes/org/openbravo/modulescript/PgJdbcDatesIssueData.class
R src-util/modulescript/build/classes/org/openbravo/modulescript/UpdateEmailPasswords.class
R src-util/modulescript/build/classes/org/openbravo/modulescript/UpdateEmailPasswordsData.class
R src-util/modulescript/build/classes/org/openbravo/modulescript/UpgradeToPocEmail.class
R src-util/modulescript/build/classes/org/openbravo/modulescript/UpgradeToPocEmailData.class
R src-util/modulescript/src/org/openbravo/modulescript/ConvertImages.java
R src-util/modulescript/src/org/openbravo/modulescript/DeleteRedundantTranslations.java
R src-util/modulescript/src/org/openbravo/modulescript/DeleteRedundantTranslations_data.xsql
R src-util/modulescript/src/org/openbravo/modulescript/InitializeAlertStatus.java
R src-util/modulescript/src/org/openbravo/modulescript/InitializeAlertStatus_data.xsql
R src-util/modulescript/src/org/openbravo/modulescript/PgJdbcDatesIssue.java
R src-util/modulescript/src/org/openbravo/modulescript/PgJdbcDatesIssue_data.xsql
R src-util/modulescript/src/org/openbravo/modulescript/UpdateEmailPasswords.java
R src-util/modulescript/src/org/openbravo/modulescript/UpdateEmailPasswords_Data.xsql
R src-util/modulescript/src/org/openbravo/modulescript/UpgradeToPocEmail.java
R src-util/modulescript/src/org/openbravo/modulescript/UpgradeToPocEmail_Data.xsql
---