0051095: OB.App.State.TerminalLog.addLog does not check preferences to send log

Openbravo Issue Tracking System - POS2

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0051095

POS2

Core

public

2022-12-12 10:20

Reporter

alostale

Assigned To

Triage Platform Base

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

new

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0051095: OB.App.State.TerminalLog.addLog does not check preferences to send log

Description

There are 2 client APIs to handle client logs:
1. OB.* (OB.error, OB.warn, OB.info...): it checks whether the log should be printed in console and/or sent to backend as terminal log
2. OB.App.State.TerminalLog.addLog: it sends the message to the backend as terminal log without further checks

The second option is a lower level API that should not be directly used by business logic code, but there are already some parts where it is used.

Steps To Reproduce

N/A: this issue is technical related to code APIs.

Proposed Solution

Decide whether OB.App.State.TerminalLog.addLog should be usable from business logic code. Options:

1. Keep it as low level:
  * Review current usage from business logic code and change it to OB.*
  * Document in JSDoc it is a low level API so it shouldn't be used

2. Open it up to be usable from business logic code
  * As action preparation (?) check whether the message should be actually sent. Note this would double the checks that are already being executed in OB.*. The save parts might be moved to be executed only here.

Additional Information