Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051073Openbravo ERP09. Financial managementpublic2022-12-05 17:222022-12-21 13:21
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR23Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051073: Delete obsolete code from prescript-* from before 2.50MP4
DescriptionIssue 10157 was included in 2.50MP4 release to auto set a value for a field being made mandatory in that release.

That was done adding code to both pg/ora prescript in this commit:
https://code.openbravo.com/erp/devel/pi/rev/1ae7761ffcf7614b771f6917131cd49f452e8ab7 [^]

Given that long time having passed and issue 51068 blocking direct updates from version <3.0MP16 (and indirectly any 2.5) that code is no longer useful.
Steps To ReproduceCheck code added in 10157 to prescript
Check that same field cb_cashtransfer_acct was made mandatory in the same issue
Proposed SolutionRemove that upgrade special code from both prescripts.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0010157 closed dalsasua API check build 99 fails 
depends on feature request 0051068PR23Q1 closed shuehner Block direct upgrades from version older than 16Q1 to latest version 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-12-05 17:22shuehnerNew Issue
2022-12-05 17:22shuehnerAssigned To => shuehner
2022-12-05 17:22shuehnerModules => Core
2022-12-05 17:22shuehnerTriggers an Emergency Pack => No
2022-12-05 17:22shuehnerRelationship addeddepends on 0051068
2022-12-05 17:22shuehnerRelationship addedrelated to 0010157
2022-12-05 17:32hgbotNote Added: 0144428
2022-12-21 13:21hgbotResolutionopen => fixed
2022-12-21 13:21hgbotStatusnew => closed
2022-12-21 13:21hgbotFixed in Version => PR23Q1
2022-12-21 13:21hgbotNote Added: 0144886
2022-12-21 13:21hgbotNote Added: 0144887

Notes
(0144428)
hgbot   
2022-12-05 17:32   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/780 [^]
(0144886)
hgbot   
2022-12-21 13:21   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 546c2f3957140ee8a3fae8312a544abbe5d05a2d
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 21-12-2022 12:21:03
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/546c2f3957140ee8a3fae8312a544abbe5d05a2d [^]

Fixed ISSUE-51073. Remove ancient pre 2.50MP4 upgrade code from prescript

in 2.50MP4 code was added to both prescripts (Oracle and PostgreSql) to
auto-fill the CB_CASHTRANSFER_ACCT field which was made mandatory back
then.

With Issue 51068 blocking direct upgrade from version < 3.0MP16 (which
also covers any 2.50) that code is no longer useful and is removed here.

---
M src-db/database/model/prescript-Oracle.sql
M src-db/database/model/prescript-PostgreSql.sql
---
(0144887)
hgbot   
2022-12-21 13:21   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/780 [^]