Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051060Retail ModulesWeb POSpublic2022-12-02 13:182022-12-27 08:33
Reportermalsasua 
Assigned Tojetxarri 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionno change required 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerGold
Support ticket53621
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051060: SAFT - TaxID is updated for the anonymous customer
DescriptionWhen the Customer TAX ID popup is used, the taxID is set to the receipt in the property saftrTaxId , but also, it is set to the anonymous customer and stored in local db.

In the PrepaymentHook, the line:
 receipt.get('bp').set('taxID', receipt.get('saftrTaxId'));
and later, the BP is save in local DB in the OBPOS_PreSyncReceipt hook, in line:
 OB.Dal.save(bp, null, null);

Steps To Reproducein POS:
1. in dev tools, check the taxID of the anonymous customer:
    select name, taxid from c_bpartner

2. add one product
3. click in total button > TAX ID Customer popup is displayed
4. fill the tax ID
5. complete the ticket

6. in dev tools, check the taxID of the anonymous customer >it changed
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0050996pi closed jetxarri TaxId missing in cross tore return 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-12-02 13:18malsasuaNew Issue
2022-12-02 13:18malsasuaAssigned To => Retail
2022-12-02 13:18malsasuaOBNetwork customer => Gold
2022-12-02 13:18malsasuaSupport ticket => 53621
2022-12-02 13:18malsasuaTriggers an Emergency Pack => No
2022-12-02 13:21malsasuaAssigned ToRetail => aferraz
2022-12-02 14:05aferrazAssigned Toaferraz => jetxarri
2022-12-14 13:21malsasuaNote Added: 0144676
2022-12-14 13:22aferrazRelationship addedrelated to 0050996
2022-12-27 08:33jetxarriReview Assigned To => aferraz
2022-12-27 08:33jetxarriNote Added: 0145013
2022-12-27 08:33jetxarriStatusnew => closed
2022-12-27 08:33jetxarriResolutionopen => no change required

Notes
(0144676)
malsasua   
2022-12-14 13:21   
New issue found: when the BP used is "Desconhecido" (it is not anonymous customer but it has got the taxID 999999990), the taxID popup is displayed and it should not be displayed.

It is a change in the behavior caused by this commit:
https://gitlab.com/openbravo/customers/DKTPT/com.practicsbs.saftpt.retail/-/commit/194155bc7dbdbf06c48d956c0ee1d6da0f1c7363 [^]
(0145013)
jetxarri   
2022-12-27 08:33   
This issue is not longer valid because the original issue 50996 has been fixed in a different way that does not create this issue