Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051052POS2POSpublic2022-12-02 10:012022-12-16 00:45
ReporterAugustoMauch 
Assigned TojavierRodriguez 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051052: Use the inactivity infrastructure to automatically close a ticket if the user did not interact with the POS for some time
DescriptionIn this issue [1] we added some infra that keeps track of the inactivity (no mouse movement, no click or screen touch) and that allows subscribers provide a function that will be invoked after a given number of seconds (provided by the subscriber) of inactivity).

In this feature request we will use that infrastructure to automatically delete or close a ticket if the user has not interacted with the POS in a given amount of time. The action itself and the number of seconds will be properties defined at terminal type level.

[1] https://issues.openbravo.com/view.php?id=50363 [^]
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
causes defect 0051227 closed javierRodriguez cannot change master data refresh interval 
causes defect 0051820 new Triage Platform Base Refresh masterdata forces to reload the app although terminal properties have not changed 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-12-02 10:01AugustoMauchNew Issue
2022-12-02 10:01AugustoMauchAssigned To => Retail
2022-12-02 10:01AugustoMauchTriggers an Emergency Pack => No
2022-12-02 10:01AugustoMauchAssigned ToRetail => javierRodriguez
2022-12-02 10:02AugustoMauchStatusnew => scheduled
2022-12-02 10:07hgbotNote Added: 0144357
2022-12-07 11:52hgbotNote Added: 0144473
2022-12-07 11:52hgbotNote Added: 0144474
2022-12-16 00:45hgbotResolutionopen => fixed
2022-12-16 00:45hgbotStatusscheduled => closed
2022-12-16 00:45hgbotFixed in Version => 23Q1
2022-12-16 00:45hgbotNote Added: 0144751
2022-12-22 10:32alostaleRelationship addedcauses 0051227
2023-03-09 10:28caristuRelationship addedcauses 0051820

Notes
(0144357)
hgbot   
2022-12-02 10:07   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/939 [^]
(0144473)
hgbot   
2022-12-07 11:52   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/939 [^]
(0144474)
hgbot   
2022-12-07 11:52   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: d098684bfa05394072203cb0131ed838a25e012d
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 07-12-2022 11:51:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/d098684bfa05394072203cb0131ed838a25e012d [^]

Related to ISSUE-51052: Inactivity infrastructure improvements

The following improvements have been done:
- If a new subscriber is added and the infrastructure was not started (event listeners, timer), it will start automatically
- Removes eventListers.js and integrates its code in InactivityTimeout
- Prevents a race condition by reading this.seconds once and reusing that value. Otherwise the timer might tick during the
execution of the function and the value of this.seconds would increase where we dont want it

---
M web-jspack/org.openbravo.core2/src/authentication/loginInitActions.js
M web-jspack/org.openbravo.core2/src/core/timeout/InactivityTimeout.js
M web-jspack/org.openbravo.core2/src/model/session/user-actions/Logout.js
R web-jspack/org.openbravo.core2/src/core/timeout/eventListeners.js
---
(0144751)
hgbot   
2022-12-16 00:45   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: c6ebbe82cd5739a46ec64cfa3d2e6098067665bd
Author: Javier Rodríguez Regueiro <javier.rodriguez@openbravo.com>
Date: 15-12-2022 23:45:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/c6ebbe82cd5739a46ec64cfa3d2e6098067665bd [^]

fixed ISSUE-51052 - Use the inactivity timeout feature to launch actions over the order

---
A src/org/openbravo/pos2/event/TerminalTypeTicketInactivityNotifyEventHandler.java
A src/org/openbravo/pos2/event/TerminalTypeTicketTimeoutEventHandler.java
A src/org/openbravo/pos2/login/TicketTimeoutProvider.java
A web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/timeout/TriggerOrderTimeout.js
A web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/timeout/__test__/TriggerOrderTimeout.test.js
A web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/timeout/mock/BookedTicketActionUserAction.js
A web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/timeout/mock/NewTicketActionUserAction.js
M src-db/database/model/modifiedTables/OBPOS_TERMINALTYPE.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M web-jspack/org.openbravo.pos2/src/authentication/loginInitActions.js
M web-jspack/org.openbravo.pos2/src/ob-init.js
---