Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051029ModulesCommercial Operationspublic2022-11-29 11:022022-12-22 12:28
Reporternoemieroussel 
Assigned Tojlopez 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customer
Regression introduced in release
Summary0051029: 0051027: [OPCOM] End date can be in the past when starting date in the past
DescriptionWhen the OPECOM starts before today, it is possible to select an ending date in the past.
Steps To ReproduceWe are the 29/11.

1-Create a new OPECOM with starting date=21/11, ending date=26/11 for example
--> KO, it is possible to save

It must be impossible either for an OPECOM creation or for an OPECOM updating
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0050501 closed yogaskarnik Retail Modules [OPECOM] End date could be <= start date and should be >= sysdate (today) 
related to defect 0051027 closed jlopez Modules [OPCOM] Start date and end date can be equal or higher || store level 
Attached Filespng ending date in the past.png (141,276) 2022-11-29 11:07
https://issues.openbravo.com/file_download.php?file_id=17892&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2022-11-29 11:02noemierousselNew Issue
2022-11-29 11:02noemierousselAssigned To => Triage Omni OMS
2022-11-29 11:07noemierousselFile Added: ending date in the past.png
2022-11-29 11:07noemierousselSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=25180#r25180
2022-11-29 11:14rafarodaRelationship addedrelated to 0050501
2022-11-29 12:35LcazauxSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=25181#r25181
2022-11-29 19:16aferrazAssigned ToTriage Omni OMS => jlopez
2022-12-02 14:56aferrazRelationship addedrelated to 0051027
2022-12-20 09:58hgbotNote Added: 0144830
2022-12-21 09:47hgbotNote Added: 0144863
2022-12-21 09:47hgbotResolutionopen => fixed
2022-12-21 09:47hgbotStatusnew => closed
2022-12-21 09:47hgbotNote Added: 0144864
2022-12-22 12:28hgbotNote Added: 0144927

Notes
(0144830)
hgbot   
2022-12-20 09:58   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/merge_requests/34 [^]
(0144863)
hgbot   
2022-12-21 09:47   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/merge_requests/34 [^]
(0144864)
hgbot   
2022-12-21 09:47   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations [^]
Changeset: 6dbc969f4b691155d3978e3bc3e2e6a8ab7d9ca8
Author: Javier López <javier.lopez@precognis.com>
Date: 21-12-2022 08:47:18
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/commit/6dbc969f4b691155d3978e3bc3e2e6a8ab7d9ca8 [^]

Fixes ISSUE-51029: Ending date must be greater than or equal to today's date

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/commercialoperations/events/CommercialOperationEventHandler.java
---
(0144927)
hgbot   
2022-12-22 12:28   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations [^]
Changeset: 2ff3e65eb7902bc1647cf535c74a96b858264794
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 22-12-2022 12:28:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/commit/2ff3e65eb7902bc1647cf535c74a96b858264794 [^]

Related to ISSUE-51029: Fix tests

---
M src-test/org/openbravo/commercialoperations/util/CommercialOperationTestConstants.java
---