Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050959POS2POSpublic2022-11-21 13:532023-01-03 17:01
Reportermontse_cabanas 
Assigned Tomontse_cabanas 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050959: Update email and optin of the customer with the dematerialized popup
DescriptionAfter a sale, when the POS is asking to choose between printing the ticket or sending by email, we wants :

add the tickbox for email optin

if the seller fullfill an email or the optin with different value than customer data loaded from Heroku, the POS should ask the seller “Do you want to change update the email of the customer ? YES / NO”

if the seller choose YES, the WEPOS should call the customer API to update the email or the uptin of the cusotmer in the RCU Heroku.
Steps To Reproduce1-Make a sale by selecting a customer
2-A popup will appear for the end user to decide if the ticket (and other related printables) will be printed and/or emailed)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng ReceiptDelivery.png (23,275) 2022-11-21 13:53
https://issues.openbravo.com/file_download.php?file_id=17864&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2022-11-21 13:53montse_cabanasNew Issue
2022-11-21 13:53montse_cabanasAssigned To => Retail
2022-11-21 13:53montse_cabanasFile Added: ReceiptDelivery.png
2022-11-21 13:53montse_cabanasOBNetwork customer => No
2022-11-21 13:53montse_cabanasTriggers an Emergency Pack => No
2022-11-21 14:18hgbotMerge Request Status => open
2022-11-21 14:18hgbotNote Added: 0143916
2022-12-12 13:17hgbotNote Added: 0144520
2022-12-13 12:57hgbotNote Added: 0144588
2022-12-13 13:01hgbotNote Added: 0144589
2022-12-19 12:04aferrazAssigned ToRetail => montse_cabanas
2022-12-19 12:06hgbotNote Added: 0144814
2022-12-19 12:07aferrazNote Deleted: 0144588
2022-12-19 12:07aferrazNote Deleted: 0144814
2022-12-20 13:17hgbotMerge Request Statusopen => approved
2022-12-20 13:18hgbotNote Added: 0144834
2022-12-21 10:54hgbotResolutionopen => fixed
2022-12-21 10:54hgbotStatusnew => closed
2022-12-21 10:54hgbotFixed in Version => PR23Q1
2022-12-21 10:54hgbotNote Added: 0144870
2022-12-21 10:54hgbotNote Added: 0144871
2022-12-21 10:55hgbotNote Added: 0144872
2022-12-21 10:55hgbotFixed in VersionPR23Q1 => RR23Q1
2022-12-21 10:55hgbotNote Added: 0144873
2022-12-21 10:57hgbotFixed in VersionRR23Q1 => 23Q1
2022-12-21 10:57hgbotNote Added: 0144874
2022-12-21 10:57hgbotNote Added: 0144875
2022-12-21 10:57hgbotNote Added: 0144876
2022-12-21 10:57hgbotNote Added: 0144877
2022-12-21 13:52hgbotNote Added: 0144902
2022-12-22 16:23jrakotobeNote Added: 0144938
2022-12-23 14:11hgbotNote Added: 0144988
2022-12-28 12:36hgbotNote Added: 0145049
2022-12-29 15:03hgbotNote Added: 0145079
2023-01-03 17:01hgbotNote Added: 0145138

Notes
(0143916)
hgbot   
2022-11-21 14:18   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/772 [^]
(0144520)
hgbot   
2022-12-12 13:17   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1411 [^]
(0144589)
hgbot   
2022-12-13 13:01   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/444 [^]
(0144834)
hgbot   
2022-12-20 13:18   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/52 [^]
(0144870)
hgbot   
2022-12-21 10:54   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 894245dcf9c6399a7d03b4fa3b05e35ba3cc6eb6
Author: Montserrat Cabañas <montserrat.cabanas@openbravo.com>
Date: 21-12-2022 09:54:10
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/894245dcf9c6399a7d03b4fa3b05e35ba3cc6eb6 [^]

Fixes FR-50959: Add Marketing Consent for Email to CRM configuration

---
M src-db/database/model/tables/C_EXTBP_CONFIG_PROPERTY.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
---
(0144871)
hgbot   
2022-12-21 10:54   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/772 [^]
(0144872)
hgbot   
2022-12-21 10:55   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/444 [^]
(0144873)
hgbot   
2022-12-21 10:55   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 59fca78e4cfdc2399173a7714b6c509b941c8412
Author: Montserrat Cabañas <montserrat.cabanas@openbravo.com>
Date: 21-12-2022 09:55:25
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/59fca78e4cfdc2399173a7714b6c509b941c8412 [^]

Fixes FR-50959: Add Marketing Consent for Email to CRM configuration

---
M web/org.openbravo.mobile.core/app/integration/external-business-partner/ExternalBusinessPartner.js
---
(0144875)
hgbot   
2022-12-21 10:57   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 0d5be4af1f33977b608dcae5a4c9df453727eae1
Author: Montserrat Cabañas <montserrat.cabanas@openbravo.com>
Date: 21-12-2022 09:57:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/0d5be4af1f33977b608dcae5a4c9df453727eae1 [^]

Fixes FR-50959: Add Marketing Consent for Email to CRM configuration

---
A web-jspack/org.openbravo.pos2/src/components/ReceiptDeliveryOptions/SharedReceiptDeliveryOptions/ReceiptDeliveryOptionsEmailMarketingConsentCheckBox/ReceiptDeliveryOptionsEmailMarketingConsentCheckBox.jsx
A web-jspack/org.openbravo.pos2/src/components/ReceiptDeliveryOptions/SharedReceiptDeliveryOptions/ReceiptDeliveryOptionsEmailMarketingConsentCheckBox/ReceiptDeliveryOptionsEmailMarketingConsentCheckBox.scss
A web-jspack/org.openbravo.pos2/src/components/ReceiptDeliveryOptions/SharedReceiptDeliveryOptions/ReceiptDeliveryOptionsEmailMarketingConsentCheckBox/__test__/ReceiptDeliveryOptionsEmailMarketingConsentCheckBox.test.jsx
A web-jspack/org.openbravo.pos2/src/components/ReceiptDeliveryOptions/SharedReceiptDeliveryOptions/ReceiptDeliveryOptionsEmailMarketingConsentCheckBox/index.js
M src-db/database/sourcedata/AD_MESSAGE.xml
M web-jspack/org.openbravo.pos2/src/components/BusinessPartnerEmailUpdate/BusinessPartnerEmailUpdate.jsx
M web-jspack/org.openbravo.pos2/src/components/BusinessPartnerEmailUpdate/BusinessPartnerEmailUpdateDialog/BusinessPartnerEmailUpdateDialog.jsx
M web-jspack/org.openbravo.pos2/src/components/BusinessPartnerEmailUpdate/BusinessPartnerEmailUpdateDialog/stories/UpdateEmailInfoDialog.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/BusinessPartnerEmailUpdate/UpdateEmailInfo/UpdateEmailInfo.jsx
M web-jspack/org.openbravo.pos2/src/components/BusinessPartnerEmailUpdate/UpdateEmailInfo/__test__/UpdateEmailInfo.test.jsx
M web-jspack/org.openbravo.pos2/src/components/ReceiptDeliveryOptions/ReceiptDeliveryOptions.jsx
M web-jspack/org.openbravo.pos2/src/components/ReceiptDeliveryOptions/ReceiptDeliveryOptionsDialog.jsx
M web-jspack/org.openbravo.pos2/src/components/ReceiptDeliveryOptions/__test__/ReceiptDeliveryOptions.test.jsx
M web-jspack/org.openbravo.pos2/src/components/ReceiptDeliveryOptions/__test__/ReceiptDeliveryOptionsDialog.test.jsx
M web-jspack/org.openbravo.pos2/src/components/ReceiptDeliveryOptions/stories/ReceiptDeliveryOptionsStoriesUtils.jsx
M web-jspack/org.openbravo.pos2/src/model/ticket/AskForBusinessPartnerUpdateEmailIfNeeded.js
M web-jspack/org.openbravo.pos2/src/model/ticket/GetTicketDeliveryOption.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/AskForBusinessPartnerUpdateEmailIfNeeded.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/GetTicketDeliveryOption.test.js
---
(0144874)
hgbot   
2022-12-21 10:57   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1411 [^]
(0144876)
hgbot   
2022-12-21 10:57   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata [^]
Changeset: 5cd811d27424caa48f60d51260c9f737e5d78916
Author: Montserrat Cabañas <montserrat.cabanas@openbravo.com>
Date: 21-12-2022 09:57:48
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/commit/5cd811d27424caa48f60d51260c9f737e5d78916 [^]

Fixes FR-50959: Add Marketing Consent for Email to CRM configuration

---
M referencedata/sampledata/The_White_Valley_Group/C_EXTBP_CONFIG_PROPERTY.xml
---
(0144877)
hgbot   
2022-12-21 10:57   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/52 [^]
(0144902)
hgbot   
2022-12-21 13:52   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata [^]
Changeset: 0e36be7cad606e8863279bb42b17037a308e0da7
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 21-12-2022 13:51:55
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/commit/0e36be7cad606e8863279bb42b17037a308e0da7 [^]

Related to FR-50959: Fix sampledata dbconsinstency

---
M referencedata/sampledata/The_White_Valley_Group/C_EXTBP_CONFIG_PROPERTY.xml
---
(0144938)
jrakotobe   
2022-12-22 16:23   
Hello, after testing this ticket : the normal flow where we update email address works

However when we check optin email (marketing consent for email) , the value is not set to TRUE in the customer object so it is never updated on the external system
(0144988)
hgbot   
2022-12-23 14:11   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 3ea348b3169a20a987c2eb73b342531951a2a686
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 23-12-2022 14:11:32
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/3ea348b3169a20a987c2eb73b342531951a2a686 [^]

Related to ISSUE-50959: Use first empty seqno for Use as Marketing Consent for Email field

---
M src-db/database/sourcedata/AD_FIELD.xml
---
(0145049)
hgbot   
2022-12-28 12:36   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: d7f9857083f72153d929b4a2616f418123ad8e7d
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 28-12-2022 12:34:49
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/d7f9857083f72153d929b4a2616f418123ad8e7d [^]

Related to ISSUE-50959: Add new Use as Marketing Consent for Email field also to API Property for Customer tab

---
M src-db/database/sourcedata/AD_FIELD.xml
---
(0145079)
hgbot   
2022-12-29 15:03   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: d052e601feb8841337ca34a2bdc3803279cc416e
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 29-12-2022 14:57:19
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/d052e601feb8841337ca34a2bdc3803279cc416e [^]

Related to ISSUE-50959: Fix property name used to identify Use as Marketing Consent for Email CRM API Property

---
M web/org.openbravo.mobile.core/app/integration/external-business-partner/ExternalBusinessPartner.js
---
(0145138)
hgbot   
2023-01-03 17:01   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: a0fe2a4f070b2a5be0d7f98aeca9c6f9562f08c9
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 03-01-2023 14:57:41
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/a0fe2a4f070b2a5be0d7f98aeca9c6f9562f08c9 [^]

Related to ISSUE-50959: Update emailMarketingConsent property correctly when using CRM

---
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/UpdateBpEmail.js
---