Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050927POS2POSpublic2022-11-16 22:462022-11-22 12:38
Reporterjonae 
Assigned Tojonae 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050927: The execution of the initial count action needs to be validated inside the action based on the parameters given.
DescriptionIf pre and post hooks needs to be added to the OpenInitialCount process, the validation to shown the window needs to be done inside the action based on the parameters given.
Steps To ReproduceIf pre and post hooks needs to be added to the OpenInitialCount process, the validation to shown the window needs to be done inside the action based on the parameters given.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on feature request 0050230 closed aferraz Retail Modules Implement open/close store process in ReactPOS 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-11-16 22:46jonaeNew Issue
2022-11-16 22:46jonaeAssigned To => jonae
2022-11-16 22:46jonaeOBNetwork customer => No
2022-11-16 22:46jonaeTriggers an Emergency Pack => No
2022-11-16 22:50hgbotMerge Request Status => open
2022-11-16 22:50hgbotNote Added: 0143755
2022-11-21 10:07dmiguelezRelationship addedduplicate of 0050937
2022-11-21 10:07dmiguelezRelationship replacedhas duplicate 0050937
2022-11-22 07:47jonaeRelationship deletedhas duplicate 0050937
2022-11-22 08:12hgbotNote Added: 0143929
2022-11-22 08:39jonaeRelationship addeddepends on 0050230
2022-11-22 09:35hgbotMerge Request Statusopen => approved
2022-11-22 12:37hgbotNote Added: 0143997
2022-11-22 12:37hgbotResolutionopen => fixed
2022-11-22 12:37hgbotStatusnew => closed
2022-11-22 12:37hgbotFixed in Version => 23Q1
2022-11-22 12:37hgbotNote Added: 0143998
2022-11-22 12:38hgbotNote Added: 0143999
2022-11-22 12:38hgbotNote Added: 0144000

Notes
(0143755)
hgbot   
2022-11-16 22:50   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1373 [^]
(0143929)
hgbot   
2022-11-22 08:12   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/merge_requests/59 [^]
(0143997)
hgbot   
2022-11-22 12:37   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1373 [^]
(0143998)
hgbot   
2022-11-22 12:37   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 4ee9c92a36ac2f9738ce3697e1544bb992a2fa0a
Author: Jon Alegría <jon.alegria@openbravo.com>
Date: 22-11-2022 11:37:28
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/4ee9c92a36ac2f9738ce3697e1544bb992a2fa0a [^]

Fixes ISSUE-50927: Moving the validation to execute the initial count window inside the user action. With this changes, modules around the functionality can add prehooks to the initial count visualization.

---
A web-jspack/org.openbravo.pos2/src/authentication/openInitialCount.js
A web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/initialCount/__test__/OpenInitialCount.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/initialCount/OpenInitialCount.js
M web-jspack/org.openbravo.pos2/src/ob-init.js
---
(0143999)
hgbot   
2022-11-22 12:38   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/merge_requests/59 [^]
(0144000)
hgbot   
2022-11-22 12:38   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^]
Changeset: 15f8670426be9f24ce36d3b8e28c5dbd47d482ed
Author: Jon Alegría <jon.alegria@openbravo.com>
Date: 22-11-2022 11:38:57
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/15f8670426be9f24ce36d3b8e28c5dbd47d482ed [^]

Fixes ISSUE-50927: The date change check in the login has to be using the store date and the current day in the till.

---
M web-jspack/org.openbravo.retail.sessions/src/model/till/user-actions/ValidateClosedTillsNotClosedStore.js
M web-jspack/org.openbravo.retail.sessions/src/model/till/user-actions/__test__/validateClosedTillsNotClosedStore.test.jsx
---