0005092: Bad usage of advisePopUp - Openbravo Issue Tracking System

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0005092

Openbravo ERP

A. Platform

public

2008-09-17 18:24

2008-12-11 13:58

Reporter

rafaroda

Assigned To

Hennadzi

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Ubuntu 7.10

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0005092: Bad usage of advisePopUp

Description

'advisePopUp' method can be used in two ways:

1) advisePopUp(response, Utility.messageBD(this, "strTitle", vars.getLanguage()), Utility.messageBD(this, "strText", vars.getLanguage()))

2) advisePopUp(response, strMessageType, Utility.messageBD(this, "strTitle", vars.getLanguage()), Utility.messageBD(this, "strText", vars.getLanguage()))

In some files there is no translation of 'strTitle' so the title is always displayed in English.

Steps To Reproduce

1) Inside /info/AttributeSetInstance.java (2 times):
1.1) advisePopUp(response, "Info", Utility.messageBD(this, "PAttributeNoSelection", vars.getLanguage())); should be advisePopUp(response, "INFO" Utility.messageBD(this, "Info", vars.getLanguage()), Utility.messageBD(this, "PAttributeNoSelection", vars.getLanguage()));

2) Inside /utility/WindowTree.java:
2.1) advisePopUp(response, "Error", Utility.messageBD(this, "AccessTableNoView", vars.getLanguage())) should be advisePopUp(response, "ERROR", Utility.messageBD(this, "Error", vars.getLanguage()), Utility.messageBD(this, "AccessTableNoView", vars.getLanguage()))

3) Inside /ad_process/Register.java (4 times):
3.1) advisePopUp(response, "ERROR", "Registration", message) should be advisePopUp(response, "ERROR", Utility.messageBD(this, "Registration", vars.getLanguage()), message)

4) Inside /ad_process/TestHeartbeat.java:
4.1) (2 times) advisePopUp(response, "ERROR", "Heartbeat", message) should be advisePopUp(response, "ERROR", Utility.messageBD(this, "Heartbeat", vars.getLanguage()), message)
4.2) (4 times) advisePopUp(response, "ERROR", "Heartbeat Configuration", message) should be advisePopUp(response, "ERROR", Utility.messageBD(this, "Heartbeat Configuration", vars.getLanguage()), message)

Proposed Solution

Additional Information