Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050868POS2Corepublic2022-11-14 08:082023-01-31 16:51
Reportercaristu 
Assigned Tocaristu 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q2 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050868: Persist user actions reasons and approvals
DescriptionIt would if it would be possible to persist into the backoffice the information of the reasons and approvals given before the execution of any user action regardless of the model they are linked to.

Currently only user actions linked to state actions of the Ticket model are being persisted.
Steps To Reproduce.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on feature request 0050865 closed caristu Retail Modules Support defining hooks that are executed after the execution of any state action 
depends on feature request 0050878 closed caristu Retail Modules DataSynchronizationProcess after saving record hooks 
depends on feature request 0050791 closed caristu POS2 User Action Reasons 
related to feature request 0051508 closed njimenez POS2 Include reason and approval history tab in return from customer window 
related to defect 0051518 closed njimenez POS2 The user action reasons and approvals persisted info can be duplicated in some cases 
related to defect 0051929 closed alostale POS2 removed cause of error from EWI when processing approvals 
blocks feature request 0051249 closed njimenez POS2 Action Reasons in Open till and Cashup with differences 
causes defect 0051765 closed caristu POS2 Reasons and approvals of deleted ticket lines are not removed from the state 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-11-14 08:08caristuNew Issue
2022-11-14 08:08caristuAssigned To => caristu
2022-11-14 08:08caristuTriggers an Emergency Pack => No
2022-11-14 08:08caristuIssue generated from0050791
2022-11-14 08:08caristuRelationship addedrelated to 0050791
2022-11-14 08:09caristuRelationship addeddepends on 0050865
2022-11-14 11:33caristuRelationship addeddepends on 0050878
2022-11-14 15:44hgbotNote Added: 0143578
2022-11-16 17:19caristuRelationship deletedrelated to 0050791
2022-11-16 17:19caristuRelationship addeddepends on 0050791
2022-11-21 12:52hgbotNote Added: 0143909
2022-11-28 10:54hgbotNote Added: 0144189
2022-12-28 17:46njimenezRelationship addedblocks 0051249
2023-01-12 14:09hgbotNote Added: 0145338
2023-01-17 12:52hgbotResolutionopen => fixed
2023-01-17 12:52hgbotStatusnew => closed
2023-01-17 12:52hgbotFixed in Version => 23Q2
2023-01-17 12:52hgbotNote Added: 0145486
2023-01-17 12:52hgbotNote Added: 0145487
2023-01-17 12:54hgbotNote Added: 0145488
2023-01-17 12:54hgbotNote Added: 0145489
2023-01-17 12:56hgbotNote Added: 0145490
2023-01-17 12:56hgbotNote Added: 0145491
2023-01-17 12:57hgbotNote Added: 0145492
2023-01-18 17:47hgbotNote Added: 0145584
2023-01-30 16:02njimenezRelationship addedrelated to 0051508
2023-01-31 14:42njimenezRelationship addedrelated to 0051518
2023-01-31 16:14caristuRelationship addedrelated to 0051519
2023-01-31 16:51caristuRelationship deletedrelated to 0051519
2023-03-03 09:01caristuRelationship addedcauses 0051765
2023-03-21 14:38alostaleRelationship addedrelated to 0051929

Notes
(0143578)
hgbot   
2022-11-14 15:44   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/912 [^]
(0143909)
hgbot   
2022-11-21 12:52   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1379 [^]
(0144189)
hgbot   
2022-11-28 10:54   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1000 [^]
(0145338)
hgbot   
2023-01-12 14:09   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/201 [^]
(0145486)
hgbot   
2023-01-17 12:52   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 75af993327993f0b6134d45a72b034256089500a
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 17-01-2023 12:51:23
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/75af993327993f0b6134d45a72b034256089500a [^]

fixes FR-50868: support persisting user actions reasons and approvals

---
A src-db/database/model/tables/OBC2_APPROVAL_REASON_HIST.xml
A src-test/org/openbravo/core2/synchronization/ReasonAndApprovalPersisterTest.java
A src/org/openbravo/core2/synchronization/ReasonAndApprovalDataPersister.java
A web-jspack/org.openbravo.core2/src/model/common/ReasonsAndApprovalsHook.js
A web-jspack/org.openbravo.core2/src/model/common/__test__/ReasonsAndApprovalsHook.test.js
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_TABLE.xml
M src-test/org/openbravo/core2/StandaloneTestSuite.java
M src-test/org/openbravo/core2/master/UserActionReasonTest.java
M src-test/org/openbravo/core2/util/Core2TestUtils.java
M src/org/openbravo/core2/login/GrantedUserActionsProvider.java
M web-jspack/org.openbravo.core2/src/core/user-action/UserAction.js
M web-jspack/org.openbravo.core2/src/core/user-action/__test__/UserAction.test.js
M web-jspack/org.openbravo.core2/src/ob-init.js
---
(0145487)
hgbot   
2023-01-17 12:52   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/912 [^]
(0145488)
hgbot   
2023-01-17 12:54   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: d5897f7decdc988f0a952c6c77bb7f19e0398e2d
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 17-01-2023 12:53:46
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/d5897f7decdc988f0a952c6c77bb7f19e0398e2d [^]

related to FR-50868: changes for approval/reason persistence

  - Adds pos2 columns into OBC2_APPROVAL_REASON_HIST
  - Adds Approval/Reason History subtabs
  - Implement getReasonItems in the user actions that handle ticket lines

---
A src-db/database/model/modifiedTables/OBC2_APPROVAL_REASON_HIST.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_TAB.xml
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/DeleteLine.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/ReturnLine.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/SetLinePrice.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/SetNoteToLine.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/SplitLines.js
---
(0145489)
hgbot   
2023-01-17 12:54   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1379 [^]
(0145490)
hgbot   
2023-01-17 12:56   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: c4ee3bce8c27b9479b8658d2fbf9c95f751e6b6b
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 17-01-2023 11:50:43
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/c4ee3bce8c27b9479b8658d2fbf9c95f751e6b6b [^]

related to FR-50868: extract approvals ticket model hook from the BL bundle

---
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
---
(0145491)
hgbot   
2023-01-17 12:56   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1000 [^]
(0145492)
hgbot   
2023-01-17 12:57   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/201 [^]
(0145584)
hgbot   
2023-01-18 17:47   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 5a8846a4a1a163780f752f9b697123005d91fa2a
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 18-01-2023 17:45:18
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/5a8846a4a1a163780f752f9b697123005d91fa2a [^]

related to FR-50868: fix test

  Fix test failing when not having a tab for the
OBC2_ApprovalReasonHistory entity.

---
M src-test/org/openbravo/core2/synchronization/ReasonAndApprovalPersisterTest.java
---